| Message ID | 1415098610-28570-1-git-send-email-timo@exertus.fi |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Timo, On Tue, 4 Nov 2014 12:56:50 +0200 Timo Ketola <timo@exertus.fi> wrote: > > diff --git a/doc/README.kwbimage b/doc/README.kwbimage > index 13f6f92..8c02298 100644 > --- a/doc/README.kwbimage > +++ b/doc/README.kwbimage > @@ -30,10 +30,10 @@ kwbimage support available with mkimage utility will generate kirkwood boot > image that can be flashed on the board NAND/SPI flash. The make target > which uses mkimage to produce such an image is "u-boot.kwb". For example: > > - export BUILD_DIR=/tmp/build > + export KBUILD_OUTPUT=/tmp/build Correct. > make distclean > make yourboard_config > - make $BUILD_DIR/u-boot.kwb > + make $KBUILD_OUTPUT/u-boot.kwb > > Should be make yourboard_defconfig make u-boot.kwb Best Regards Masahiro Yamada
On 05.11.2014 09:16, Masahiro Yamada wrote: > On Tue, 4 Nov 2014 12:56:50 +0200 > Timo Ketola <timo@exertus.fi> wrote: >> make distclean >> make yourboard_config >> - make $BUILD_DIR/u-boot.kwb >> + make $KBUILD_OUTPUT/u-boot.kwb > > Should be > make yourboard_defconfig > make u-boot.kwb Sounds logical. But that means that the older version was already broken (even when BUILD_DIR was correct variable), doesn't it? Should I edit the patch that way or leave the file alone? -- Timo
Hi Timo, 2014-11-05 17:12 GMT+09:00 Timo Ketola <Timo.Ketola@exertus.fi>: > On 05.11.2014 09:16, Masahiro Yamada wrote: >> On Tue, 4 Nov 2014 12:56:50 +0200 >> Timo Ketola <timo@exertus.fi> wrote: >>> make distclean >>> make yourboard_config >>> - make $BUILD_DIR/u-boot.kwb >>> + make $KBUILD_OUTPUT/u-boot.kwb >> >> Should be >> make yourboard_defconfig >> make u-boot.kwb > > Sounds logical. But that means that the older version was already broken > (even when BUILD_DIR was correct variable), doesn't it? > > Should I edit the patch that way or leave the file alone? > Both "make $BUILD_DIR/u-boot.kwb" and "make "$KBUILD_OUTPUT/u-boot.kwb" are wrong. "make u-boot.kwb" is correct. Please fix the patch as I suggested.
diff --git a/README b/README index 7b5538e..c3a9dfc 100644 --- a/README +++ b/README @@ -5012,14 +5012,14 @@ this behavior and build U-Boot to some external directory: make O=/tmp/build NAME_defconfig make O=/tmp/build all -2. Set environment variable BUILD_DIR to point to the desired location: +2. Set environment variable KBUILD_OUTPUT to point to the desired location: - export BUILD_DIR=/tmp/build + export KBUILD_OUTPUT=/tmp/build make distclean make NAME_defconfig make all -Note that the command line "O=" setting overrides the BUILD_DIR environment +Note that the command line "O=" setting overrides the KBUILD_OUTPUT environment variable. diff --git a/doc/README.kwbimage b/doc/README.kwbimage index 13f6f92..8c02298 100644 --- a/doc/README.kwbimage +++ b/doc/README.kwbimage @@ -30,10 +30,10 @@ kwbimage support available with mkimage utility will generate kirkwood boot image that can be flashed on the board NAND/SPI flash. The make target which uses mkimage to produce such an image is "u-boot.kwb". For example: - export BUILD_DIR=/tmp/build + export KBUILD_OUTPUT=/tmp/build make distclean make yourboard_config - make $BUILD_DIR/u-boot.kwb + make $KBUILD_OUTPUT/u-boot.kwb Board specific configuration file specifications:
Correct environment variable is KBUILD_OUTPUT. Signed-off-by: Timo Ketola <timo@exertus.fi> --- README | 6 +++--- doc/README.kwbimage | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-)