| Message ID | 1401779120-20306-6-git-send-email-rainer.boschung@keymile.com |
|---|---|
| State | Accepted |
| Delegated to: | York Sun |
| Headers | show |
Rainer, Once this patch is enabled, we have warning: implicit declaration of function 'init_85xx_watchdog' [-Wimplicit-function-declaration] Please fix. York On 06/03/2014 12:05 AM, Rainer Boschung wrote: > The booting of the board is now protected by the CPU watchdog. > A failure during the boot phase will end up in board reset. > > Signed-off-by: Rainer Boschung <rainer.boschung@keymile.com> > --- > include/configs/km/kmp204x-common.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/configs/km/kmp204x-common.h b/include/configs/km/kmp204x-common.h > index efd9635..a0f9d29 100644 > --- a/include/configs/km/kmp204x-common.h > +++ b/include/configs/km/kmp204x-common.h > @@ -377,6 +377,14 @@ int get_scl(void); > #define CONFIG_SYS_LOADS_BAUD_CHANGE /* allow baudrate change */ > > /* > + * Hardware Watchdog > + */ > +#define CONFIG_WATCHDOG /* enable CPU watchdog */ > +#define CONFIG_WATCHDOG_PRESC 34 /* wdog prescaler 2^(64-34) (~10min) */ > +#define CONFIG_WATCHDOG_RC WRC_CHIP /* reset chip on watchdog event */ > + > + > +/* > * additionnal command line configuration. > */ > #define CONFIG_CMD_PCI >
Rainer, Did you get a chance to fix your patch? York On 07/18/2014 03:21 PM, York Sun wrote: > Rainer, > > Once this patch is enabled, we have > > warning: implicit declaration of function 'init_85xx_watchdog' > [-Wimplicit-function-declaration] > > Please fix. > > York > > > On 06/03/2014 12:05 AM, Rainer Boschung wrote: >> The booting of the board is now protected by the CPU watchdog. >> A failure during the boot phase will end up in board reset. >> >> Signed-off-by: Rainer Boschung <rainer.boschung@keymile.com> >> --- >> include/configs/km/kmp204x-common.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/include/configs/km/kmp204x-common.h b/include/configs/km/kmp204x-common.h >> index efd9635..a0f9d29 100644 >> --- a/include/configs/km/kmp204x-common.h >> +++ b/include/configs/km/kmp204x-common.h >> @@ -377,6 +377,14 @@ int get_scl(void); >> #define CONFIG_SYS_LOADS_BAUD_CHANGE /* allow baudrate change */ >> >> /* >> + * Hardware Watchdog >> + */ >> +#define CONFIG_WATCHDOG /* enable CPU watchdog */ >> +#define CONFIG_WATCHDOG_PRESC 34 /* wdog prescaler 2^(64-34) (~10min) */ >> +#define CONFIG_WATCHDOG_RC WRC_CHIP /* reset chip on watchdog event */ >> + >> + >> +/* >> * additionnal command line configuration. >> */ >> #define CONFIG_CMD_PCI >> > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >
Since you are on a long vacation, I will fix it for you this time. York On 07/23/2014 02:34 PM, York Sun wrote: > Rainer, > > Did you get a chance to fix your patch? > > York > > > On 07/18/2014 03:21 PM, York Sun wrote: >> Rainer, >> >> Once this patch is enabled, we have >> >> warning: implicit declaration of function 'init_85xx_watchdog' >> [-Wimplicit-function-declaration] >> >> Please fix. >> >> York >> >> >> On 06/03/2014 12:05 AM, Rainer Boschung wrote: >>> The booting of the board is now protected by the CPU watchdog. >>> A failure during the boot phase will end up in board reset. >>> >>> Signed-off-by: Rainer Boschung <rainer.boschung@keymile.com> >>> --- >>> include/configs/km/kmp204x-common.h | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/include/configs/km/kmp204x-common.h b/include/configs/km/kmp204x-common.h >>> index efd9635..a0f9d29 100644 >>> --- a/include/configs/km/kmp204x-common.h >>> +++ b/include/configs/km/kmp204x-common.h >>> @@ -377,6 +377,14 @@ int get_scl(void); >>> #define CONFIG_SYS_LOADS_BAUD_CHANGE /* allow baudrate change */ >>> >>> /* >>> + * Hardware Watchdog >>> + */ >>> +#define CONFIG_WATCHDOG /* enable CPU watchdog */ >>> +#define CONFIG_WATCHDOG_PRESC 34 /* wdog prescaler 2^(64-34) (~10min) */ >>> +#define CONFIG_WATCHDOG_RC WRC_CHIP /* reset chip on watchdog event */ >>> + >>> + >>> +/* >>> * additionnal command line configuration. >>> */ >>> #define CONFIG_CMD_PCI >>> >> >> _______________________________________________ >> U-Boot mailing list >> U-Boot@lists.denx.de >> http://lists.denx.de/mailman/listinfo/u-boot >> > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >
diff --git a/include/configs/km/kmp204x-common.h b/include/configs/km/kmp204x-common.h index efd9635..a0f9d29 100644 --- a/include/configs/km/kmp204x-common.h +++ b/include/configs/km/kmp204x-common.h @@ -377,6 +377,14 @@ int get_scl(void); #define CONFIG_SYS_LOADS_BAUD_CHANGE /* allow baudrate change */ /* + * Hardware Watchdog + */ +#define CONFIG_WATCHDOG /* enable CPU watchdog */ +#define CONFIG_WATCHDOG_PRESC 34 /* wdog prescaler 2^(64-34) (~10min) */ +#define CONFIG_WATCHDOG_RC WRC_CHIP /* reset chip on watchdog event */ + + +/* * additionnal command line configuration. */ #define CONFIG_CMD_PCI
The booting of the board is now protected by the CPU watchdog. A failure during the boot phase will end up in board reset. Signed-off-by: Rainer Boschung <rainer.boschung@keymile.com> --- include/configs/km/kmp204x-common.h | 8 ++++++++ 1 file changed, 8 insertions(+)