diff mbox

[U-Boot,1/5] add a generic set of configs to enable Distros to more easier support u-boot based systems

Message ID 1386296295-28658-2-git-send-email-dennis@ausil.us
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Dennis Gilmore Dec. 6, 2013, 2:18 a.m. UTC 
Signed-off-by: Dennis Gilmore <dennis@ausil.us>
---
 include/common.h                |  5 +++++
 include/config_distro_default.h | 49 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 54 insertions(+)
 create mode 100644 include/config_distro_default.h

Comments

Wolfgang Denk Dec. 6, 2013, 10:53 a.m. UTC | #1 
Dear Dennis Gilmore,

In message <1386296295-28658-2-git-send-email-dennis@ausil.us> you wrote:
>
> +#if defined(__arm__)
> +#define CONFIG_BOOTP_PXE_CLIENTARCH     0x100
> +#define CONFIG_BOOTP_VCI_STRING         "U-boot.armv7"
> +#endif

This cannot be right.  Not all the world is an ARMv7.

Please also note that the correct spelling (when using capitalization)
is "U-Boot" (i. e. with a capital 'B').

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/include/common.h b/include/common.h
index 8ca67f6..c558422 100644
--- a/include/common.h
+++ b/include/common.h
@@ -99,6 +99,11 @@  typedef volatile unsigned char	vu_char;
 #include <flash.h>
 #include <image.h>
 
+/* use generic distro config */
+#ifdef DISTRO_DEFAULTS
+#include <config_distro_default.h>
+#endif
+
 #ifdef DEBUG
 #define _DEBUG	1
 #else
diff --git a/include/config_distro_default.h b/include/config_distro_default.h
new file mode 100644
index 0000000..bd9b4a0
--- /dev/null
+++ b/include/config_distro_default.h
@@ -0,0 +1,49 @@ 
+/*
+ * Copyright 2013 Red Hat, Inc.
+ *
+ * SPDX-License-Identifier:     GPL-2.0+
+ */
+
+#ifndef _CONFIG_CMD_DISTRO_DEFAULT_H
+#define _CONFIG_CMD_DISTRO_DEFAULT_H
+
+/*
+ * List of all commands and options that when defined enables support for features
+ * required by distros to support boards in a standardised and consitant manner.
+ */
+
+#define CONFIG_BOOTP_BOOTPATH
+#define CONFIG_BOOTP_DNS
+#define CONFIG_BOOTP_GATEWAY
+#define CONFIG_BOOTP_HOSTNAME
+#define CONFIG_BOOTP_PXE
+#define CONFIG_BOOTP_SUBNETMASK
+
+#if defined(__arm__)
+#define CONFIG_BOOTP_PXE_CLIENTARCH     0x100
+#define CONFIG_BOOTP_VCI_STRING         "U-boot.armv7"
+#endif
+
+#define CONFIG_OF_LIBFDT
+
+#define CONFIG_CMD_BOOTZ
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_ELF
+#define CONFIG_CMD_EXT2
+#define CONFIG_CMD_FAT
+#define CONFIG_CMD_MII
+#define CONFIG_CMD_NET
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_PXE
+
+#define CONFIG_CMDLINE_EDITING
+#define CONFIG_AUTO_COMPLETE
+#define CONFIG_BOOTDELAY     2
+#define CONFIG_SYS_LONGHELP
+#define CONFIG_MENU
+#define CONFIG_DOS_PARTITION
+#define CONFIG_EFI_PARTITION
+#define CONFIG_SUPPORT_RAW_INITRD
+#define CONFIG_SYS_HUSH_PARSER
+
+#endif	/* _CONFIG_CMD_DISTRO_DEFAULT_H */