| Message ID | 1355242795-16606-1-git-send-email-fabio.estevam@freescale.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
On 11/12/2012 17:19, Fabio Estevam wrote: > Set the gpio value in gpio_direction_output() instead of an extra gpio_set_value > call. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > board/woodburn/woodburn.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/board/woodburn/woodburn.c b/board/woodburn/woodburn.c > index 66a0d35..d74f360 100644 > --- a/board/woodburn/woodburn.c > +++ b/board/woodburn/woodburn.c > @@ -133,8 +133,7 @@ int woodburn_init(void) > mxc_request_iomux(MX35_PIN_SCKR, MUX_CONFIG_ALT5); > gpio_direction_output(4, 1); > mxc_request_iomux(MX35_PIN_HCKT, MUX_CONFIG_ALT5); > - gpio_direction_output(9, 0); > - gpio_set_value(9, 1); > + gpio_direction_output(9, 1); > > return 0; > } > Thanks ! Acked-by: Stefano Babic <sbabic@denx.de> Regards, Stefano
On 11/12/2012 17:19, Fabio Estevam wrote: > Set the gpio value in gpio_direction_output() instead of an extra gpio_set_value > call. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > board/woodburn/woodburn.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/board/woodburn/woodburn.c b/board/woodburn/woodburn.c > index 66a0d35..d74f360 100644 > --- a/board/woodburn/woodburn.c > +++ b/board/woodburn/woodburn.c > @@ -133,8 +133,7 @@ int woodburn_init(void) > mxc_request_iomux(MX35_PIN_SCKR, MUX_CONFIG_ALT5); > gpio_direction_output(4, 1); > mxc_request_iomux(MX35_PIN_HCKT, MUX_CONFIG_ALT5); > - gpio_direction_output(9, 0); > - gpio_set_value(9, 1); > + gpio_direction_output(9, 1); > > return 0; > } > Applied to u-boot-imx, thanks. Best regards, Stefano Babic
diff --git a/board/woodburn/woodburn.c b/board/woodburn/woodburn.c index 66a0d35..d74f360 100644 --- a/board/woodburn/woodburn.c +++ b/board/woodburn/woodburn.c @@ -133,8 +133,7 @@ int woodburn_init(void) mxc_request_iomux(MX35_PIN_SCKR, MUX_CONFIG_ALT5); gpio_direction_output(4, 1); mxc_request_iomux(MX35_PIN_HCKT, MUX_CONFIG_ALT5); - gpio_direction_output(9, 0); - gpio_set_value(9, 1); + gpio_direction_output(9, 1); return 0; }
Set the gpio value in gpio_direction_output() instead of an extra gpio_set_value call. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- board/woodburn/woodburn.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)