diff mbox

[U-Boot,2/2] Use loop block device in sandbox board

Message ID 1346505549-6795-2-git-send-email-morpheus.ibis@gmail.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Pavel Herrmann Sept. 1, 2012, 1:19 p.m. UTC 
Signed-off-by: Pavel Herrmann <morpheus.ibis@gmail.com>
---
 include/configs/sandbox.h | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Marek Vasut Sept. 1, 2012, 2:20 p.m. UTC | #1 
Dear Pavel Herrmann,

I don't understand what this patch does from the lacking description. Please add 
proper description to the patch. ALWAYS!

> Signed-off-by: Pavel Herrmann <morpheus.ibis@gmail.com>
> ---
>  include/configs/sandbox.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h
> index 0220386..3126542 100644
> --- a/include/configs/sandbox.h
> +++ b/include/configs/sandbox.h
> @@ -93,4 +93,13 @@
>  					"stdout=serial\0" \
>  					"stderr=serial\0"
> 
> +/* SATA loopback device */
> +#define CONFIG_CMD_SATA
> +#define CONFIG_SATA_LOOP
> +#define CONFIG_SATA_LOOP_DISKS {"disk1", "obscenelylongfilename", "disk3"}
> +#define CONFIG_SYS_SATA_MAX_DEVICE 3
> +#define CONFIG_DOS_PARTITION
> +#define CONFIG_CMD_FAT
> +#define CONFIG_CMD_EXT2
> +
>  #endif

Best regards,
Marek Vasut
Pavel Herrmann Sept. 3, 2012, 5:24 p.m. UTC | #2 
Hi

On Saturday 01 of September 2012 16:20:12 Marek Vasut wrote:
> Dear Pavel Herrmann,
> 
> I don't understand what this patch does from the lacking description. Please
> add proper description to the patch. ALWAYS!

see $title perhaps? there is not much more to say.

v2 on the way

Pavel Herrmann
diff mbox

Patch

diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h
index 0220386..3126542 100644
--- a/include/configs/sandbox.h
+++ b/include/configs/sandbox.h
@@ -93,4 +93,13 @@ 
 					"stdout=serial\0" \
 					"stderr=serial\0"
 
+/* SATA loopback device */
+#define CONFIG_CMD_SATA
+#define CONFIG_SATA_LOOP
+#define CONFIG_SATA_LOOP_DISKS {"disk1", "obscenelylongfilename", "disk3"}
+#define CONFIG_SYS_SATA_MAX_DEVICE 3
+#define CONFIG_DOS_PARTITION
+#define CONFIG_CMD_FAT
+#define CONFIG_CMD_EXT2
+
 #endif