diff mbox

[U-Boot] patman: Allow for changelog use in first version of a series

Message ID 1344888502-29178-1-git-send-email-otavio@ossystems.com.br
State Accepted
Commit d5f81d8acd14329095722879cf17a9b5295111dd
Delegated to: Wolfgang Denk
Headers show

Commit Message

Otavio Salvador Aug. 13, 2012, 8:08 p.m. UTC
When a patchset had a RFC series, a v1 might have a changelog of
changes done since the RFC. The patch changes the range checked for
changelog and allow it to start for version 1.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 tools/patman/series.py |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Simon Glass Aug. 17, 2012, 9:25 p.m. UTC | #1
On Mon, Aug 13, 2012 at 1:08 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> When a patchset had a RFC series, a v1 might have a changelog of
> changes done since the RFC. The patch changes the range checked for
> changelog and allow it to start for version 1.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Acked-by: Simon Glass <sjg@chromium.org>

> ---
>  tools/patman/series.py |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tools/patman/series.py b/tools/patman/series.py
> index 05d9e73..eda1e9b 100644
> --- a/tools/patman/series.py
> +++ b/tools/patman/series.py
> @@ -174,12 +174,13 @@ class Series(dict):
>          col = terminal.Color()
>          if self.get('version'):
>              changes_copy = dict(self.changes)
> -            for version in range(2, int(self.version) + 1):
> +            for version in range(1, int(self.version) + 1):
>                  if self.changes.get(version):
>                      del changes_copy[version]
>                  else:
> -                    str = 'Change log missing for v%d' % version
> -                    print col.Color(col.RED, str)
> +                    if version > 1:
> +                        str = 'Change log missing for v%d' % version
> +                        print col.Color(col.RED, str)
>              for version in changes_copy:
>                  str = 'Change log for unknown version v%d' % version
>                  print col.Color(col.RED, str)
> --
> 1.7.10.4
>
Wolfgang Denk Sept. 2, 2012, 2:25 p.m. UTC | #2
Dear Otavio Salvador,

In message <1344888502-29178-1-git-send-email-otavio@ossystems.com.br> you wrote:
> When a patchset had a RFC series, a v1 might have a changelog of
> changes done since the RFC. The patch changes the range checked for
> changelog and allow it to start for version 1.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  tools/patman/series.py |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/tools/patman/series.py b/tools/patman/series.py
index 05d9e73..eda1e9b 100644
--- a/tools/patman/series.py
+++ b/tools/patman/series.py
@@ -174,12 +174,13 @@  class Series(dict):
         col = terminal.Color()
         if self.get('version'):
             changes_copy = dict(self.changes)
-            for version in range(2, int(self.version) + 1):
+            for version in range(1, int(self.version) + 1):
                 if self.changes.get(version):
                     del changes_copy[version]
                 else:
-                    str = 'Change log missing for v%d' % version
-                    print col.Color(col.RED, str)
+                    if version > 1:
+                        str = 'Change log missing for v%d' % version
+                        print col.Color(col.RED, str)
             for version in changes_copy:
                 str = 'Change log for unknown version v%d' % version
                 print col.Color(col.RED, str)