| Message ID | 1340482108-18468-2-git-send-email-otavio@ossystems.com.br |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
Dear Otavio Salvador, In message <1340482108-18468-2-git-send-email-otavio@ossystems.com.br> you wrote: > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > Cc: Marek Vasut <marex@denx.de> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Fabio Estevam <fabio.estevam@freescale.com> > --- > board/freescale/mx53loco/mx53loco.c | 2 ++ > 1 file changed, 2 insertions(+) Argh!!! Plese read http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions Please mark updated versions of a patch in the Subject:, and include a change log. > +/* Needs to be available on the board file to be called in board_init, > + * instead of normal order */ This cmment makes no sense to me. Also, this is incorrect multi-line comment style. Best regards, Wolfgang Denk
On Sun, Jun 24, 2012 at 4:53 AM, Wolfgang Denk <wd@denx.de> wrote: > Please mark updated versions of a patch in the Subject:, and include a > change log. This was sent by mistake; the updated patch has been sent together. Sorry for the noise.
Dear Otavio Salvador, In message <CAP9ODKr7a4cfoxT3S_XZxYB22Y3nWYngJ+_pz52OzYv0pOYuxQ@mail.gmail.com> you wrote: > On Sun, Jun 24, 2012 at 4:53 AM, Wolfgang Denk <wd@denx.de> wrote: > > Please mark updated versions of a patch in the Subject:, and include a > > change log. > > This was sent by mistake; the updated patch has been sent together. > Sorry for the noise. But the updated patch did not contaiy indication of an pdate either, nor any change log. This is what I'm complaining about! Best regards, Wolfgang Denk
On Sun, Jun 24, 2012 at 7:04 PM, Wolfgang Denk <wd@denx.de> wrote: > But the updated patch did not contaiy indication of an pdate either, > nor any change log. > > This is what I'm complaining about! Stop complaining! I SAID SORRY... For the third time ... I sent it by mistake; read the another...
diff --git a/board/freescale/mx53loco/mx53loco.c b/board/freescale/mx53loco/mx53loco.c index 445d022..9fae5e8 100644 --- a/board/freescale/mx53loco/mx53loco.c +++ b/board/freescale/mx53loco/mx53loco.c @@ -413,6 +413,8 @@ int board_early_init_f(void) return 0; } +/* Needs to be available on the board file to be called in board_init, + * instead of normal order */ int print_cpuinfo(void) { u32 cpurev;
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> Cc: Marek Vasut <marex@denx.de> Cc: Stefano Babic <sbabic@denx.de> Cc: Fabio Estevam <fabio.estevam@freescale.com> --- board/freescale/mx53loco/mx53loco.c | 2 ++ 1 file changed, 2 insertions(+)