diff mbox

[U-Boot,1/6] imx31_phycore: Remove CONFIG_SYS_I2C_SLAVE definition

Message ID 1338710010-13709-1-git-send-email-festevam@gmail.com
State Accepted
Commit 29ee7f5487b8081d264e91daaa2ae98577cca7aa
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam June 3, 2012, 7:53 a.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

According to include/i2c.h:

"/*
 * Many boards/controllers/drivers don't support an I2C slave interface so
 * provide a default slave address for them for use in common code.  A real
 * value for CONFIG_SYS_I2C_SLAVE should be defined for any board which does
 * support a slave interface.
 */
#ifndef	CONFIG_SYS_I2C_SLAVE
#define	CONFIG_SYS_I2C_SLAVE	0xfe
#endif
"

As the mxc_i2c driver does not support slave mode, there is no need
to define CONFIG_SYS_I2C_SLAVE in i.MX board file.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 include/configs/imx31_phycore.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Stefano Babic June 15, 2012, 2:43 p.m. UTC | #1 
On 03/06/2012 09:53, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> According to include/i2c.h:
> 
> "/*
>  * Many boards/controllers/drivers don't support an I2C slave interface so
>  * provide a default slave address for them for use in common code.  A real
>  * value for CONFIG_SYS_I2C_SLAVE should be defined for any board which does
>  * support a slave interface.
>  */
> #ifndef	CONFIG_SYS_I2C_SLAVE
> #define	CONFIG_SYS_I2C_SLAVE	0xfe
> #endif

Whole series applied to u-boot-imx, thanks.

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/include/configs/imx31_phycore.h b/include/configs/imx31_phycore.h
index 3153eb5..b3244b9 100644
--- a/include/configs/imx31_phycore.h
+++ b/include/configs/imx31_phycore.h
@@ -56,7 +56,6 @@ 
 #define CONFIG_I2C_MXC
 #define CONFIG_SYS_I2C_MX31_PORT2
 #define CONFIG_SYS_I2C_SPEED		100000
-#define CONFIG_SYS_I2C_SLAVE		0xfe
 
 #define CONFIG_MXC_UART
 #define CONFIG_MXC_UART_BASE		UART1_BASE