diff mbox

[U-Boot,V2] checkpatch: add check for whitespace before semicolon at end-of-line

Message ID 1336147186-27853-1-git-send-email-eric.nelson@boundarydevices.com
State Changes Requested
Headers show

Commit Message

Eric Nelson May 4, 2012, 3:59 p.m. UTC 
Requires --strict option during invocation:
	~/linux$ scripts/checkpatch --strict foo.patch

This tests for a bad habits of mine like this:

	return 0 ;

Note that it does allow a special case of a bare semicolon
for empty loops:

	while (foo())
		;

---
V2 adds the special case and requirement for --strict based on
recommendations of Joe Perches.

 scripts/checkpatch.pl |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
diff mbox

Patch

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a3b9782..e711122 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3227,6 +3227,12 @@  sub process {
 			 "Statements terminations use 1 semicolon\n" . $herecurr);
 		}
 
+# check for whitespace before semicolon - not allowed at end-of-line
+		if ($line =~ /\S+\s+;$/) {
+		    CHK("SPACING",
+			 "Whitespace before semicolon\n" . $herecurr);
+		}
+
 # check for gcc specific __FUNCTION__
 		if ($line =~ /__FUNCTION__/) {
 			WARN("USE_FUNC",