| Message ID | 1334825735-27992-8-git-send-email-timo@exertus.fi |
|---|---|
| State | Accepted |
| Commit | 8f385e958dbccb2c9d38e3a5239f8b840c916419 |
| Headers | show |
On 19/04/2012 10:55, Timo Ketola wrote: > types.h must be included in imx-regs.h if one wants to include > imx-regs.h in a board configuration file. That for one's part is > necessary, if one wants to use addresses defined in imx-regs.h. > > For example, fsl_esdhc.c needs CONFIG_SYS_FSL_ESDHC_ADDR defined and > a proper thing is to define it with IMX_MMC_SDHCx_BASE in board > configuration file. This patch fixes the build in that case. > > Signed-off-by: Timo Ketola <timo@exertus.fi> > --- > > Changes in v4: > - Proper fix was found so this patch changes altogether - subject, > message and touched file > > Changes in v2: > - New patch in this series > > arch/arm/include/asm/arch-mx25/imx-regs.h | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/include/asm/arch-mx25/imx-regs.h b/arch/arm/include/asm/arch-mx25/imx-regs.h > index 7f9449b..cf925d7 100644 > --- a/arch/arm/include/asm/arch-mx25/imx-regs.h > +++ b/arch/arm/include/asm/arch-mx25/imx-regs.h > @@ -34,6 +34,9 @@ > #define _IMX_REGS_H > > #ifndef __ASSEMBLY__ > + > +#include <asm/types.h> > + > #ifdef CONFIG_FEC_MXC > extern void mx25_fec_init_pins(void); > #endif Acked-by: Stefano Babic <sbabic@denx.de> Best regards, Stefano Babic
On 19/04/2012 10:55, Timo Ketola wrote: > types.h must be included in imx-regs.h if one wants to include > imx-regs.h in a board configuration file. That for one's part is > necessary, if one wants to use addresses defined in imx-regs.h. > > For example, fsl_esdhc.c needs CONFIG_SYS_FSL_ESDHC_ADDR defined and > a proper thing is to define it with IMX_MMC_SDHCx_BASE in board > configuration file. This patch fixes the build in that case. > > Signed-off-by: Timo Ketola <timo@exertus.fi> > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic
diff --git a/arch/arm/include/asm/arch-mx25/imx-regs.h b/arch/arm/include/asm/arch-mx25/imx-regs.h index 7f9449b..cf925d7 100644 --- a/arch/arm/include/asm/arch-mx25/imx-regs.h +++ b/arch/arm/include/asm/arch-mx25/imx-regs.h @@ -34,6 +34,9 @@ #define _IMX_REGS_H #ifndef __ASSEMBLY__ + +#include <asm/types.h> + #ifdef CONFIG_FEC_MXC extern void mx25_fec_init_pins(void); #endif
types.h must be included in imx-regs.h if one wants to include imx-regs.h in a board configuration file. That for one's part is necessary, if one wants to use addresses defined in imx-regs.h. For example, fsl_esdhc.c needs CONFIG_SYS_FSL_ESDHC_ADDR defined and a proper thing is to define it with IMX_MMC_SDHCx_BASE in board configuration file. This patch fixes the build in that case. Signed-off-by: Timo Ketola <timo@exertus.fi> --- Changes in v4: - Proper fix was found so this patch changes altogether - subject, message and touched file Changes in v2: - New patch in this series arch/arm/include/asm/arch-mx25/imx-regs.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)