diff mbox

[U-Boot,V2] devkit8000: Move CONFIG_SYS_TEXT_BASE out of bss

Message ID 1323162988-8873-1-git-send-email-simonschwarzcor@gmail.com
State Accepted, archived
Delegated to: Tom Rini
Headers show

Commit Message

Simon Schwarz Dec. 6, 2011, 9:16 a.m. UTC
This moves CONFIG_SYS_TEXT_BASE one MB after beginning of SD-RAM. Move
CONFIG_SYS_SPL_MALLOC_START to have one MB of free space for the u-boot
image.

CONFIG_SYS_TEXT_BASE was in the middle of the bss-section. This was the
reason for the problems with MMC boot described here:
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/118711

Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
---
V2 changes:
CHG added a more comprehensive comment on CONFIG_SYS_TEXT_BASE
CHG Moved CONFIG_SYS_SPL_MALLOC_START from 0x80200000 to 0x80208000 to be
  		consistent with beagle board

Cc: s-paulraj@ti.com
Cc: trini@ti.com
Cc: albert.u.boot@aribaud.net
---
 include/configs/devkit8000.h |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

Comments

Thomas Weber Dec. 6, 2011, 1:52 p.m. UTC | #1
On 06.12.2011 10:16, Simon Schwarz wrote:
> This moves CONFIG_SYS_TEXT_BASE one MB after beginning of SD-RAM. Move
> CONFIG_SYS_SPL_MALLOC_START to have one MB of free space for the u-boot
> image.
> 
> CONFIG_SYS_TEXT_BASE was in the middle of the bss-section. This was the
> reason for the problems with MMC boot described here:
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/118711
> 
> Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
> ---
> V2 changes:
> CHG added a more comprehensive comment on CONFIG_SYS_TEXT_BASE
> CHG Moved CONFIG_SYS_SPL_MALLOC_START from 0x80200000 to 0x80208000 to be
>   		consistent with beagle board
> 
> Cc: s-paulraj@ti.com
> Cc: trini@ti.com
> Cc: albert.u.boot@aribaud.net
> ---
>  include/configs/devkit8000.h |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
> index e1743dc..a2e1d2d 100644
> --- a/include/configs/devkit8000.h
> +++ b/include/configs/devkit8000.h
> @@ -37,7 +37,13 @@
>  #define CONFIG_OMAP3430		1	/* which is in a 3430 */
>  #define CONFIG_OMAP3_DEVKIT8000	1	/* working with DevKit8000 */
>  
> -#define	CONFIG_SYS_TEXT_BASE	0x80008000
> +/*
> + * 1MB into the SDRAM to allow for SPL's bss at the beginning of SDRAM
> + * 64 bytes before this address should be set aside for u-boot.img's
> + * header. That is 0x800FFFC0--0x80100000 should not be used for any
> + * other needs.
> + */
> +#define	CONFIG_SYS_TEXT_BASE	0x80100000
>  
>  #define CONFIG_SDRC	/* The chip has SDRC controller */
>  
> @@ -359,7 +365,7 @@
>  #define CONFIG_SYS_NAND_U_BOOT_OFFS	0x80000
>  #define CONFIG_SYS_NAND_U_BOOT_SIZE	0x200000
>  
> -#define CONFIG_SYS_SPL_MALLOC_START	0x80108000
> +#define CONFIG_SYS_SPL_MALLOC_START	0x80208000
>  #define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000	/* 1 MB */
>  
>  #endif /* __CONFIG_H */

Tested-by: Thomas Weber <weber@corscience.de>

Thanks,
Thomas
diff mbox

Patch

diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
index e1743dc..a2e1d2d 100644
--- a/include/configs/devkit8000.h
+++ b/include/configs/devkit8000.h
@@ -37,7 +37,13 @@ 
 #define CONFIG_OMAP3430		1	/* which is in a 3430 */
 #define CONFIG_OMAP3_DEVKIT8000	1	/* working with DevKit8000 */
 
-#define	CONFIG_SYS_TEXT_BASE	0x80008000
+/*
+ * 1MB into the SDRAM to allow for SPL's bss at the beginning of SDRAM
+ * 64 bytes before this address should be set aside for u-boot.img's
+ * header. That is 0x800FFFC0--0x80100000 should not be used for any
+ * other needs.
+ */
+#define	CONFIG_SYS_TEXT_BASE	0x80100000
 
 #define CONFIG_SDRC	/* The chip has SDRC controller */
 
@@ -359,7 +365,7 @@ 
 #define CONFIG_SYS_NAND_U_BOOT_OFFS	0x80000
 #define CONFIG_SYS_NAND_U_BOOT_SIZE	0x200000
 
-#define CONFIG_SYS_SPL_MALLOC_START	0x80108000
+#define CONFIG_SYS_SPL_MALLOC_START	0x80208000
 #define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000	/* 1 MB */
 
 #endif /* __CONFIG_H */