| Message ID | 1319915380-23631-1-git-send-email-ecc@cmu.edu |
|---|---|
| State | Superseded |
| Headers | show |
Hi Eric, On Sat, 29 Oct 2011 15:09:40 -0400 Eric Cooper <ecc@cmu.edu> wrote: > Commit a7efd719f415833a833d6a8e46bcd470a0847ecc removed some #includes > from kirkwood.h that must now be done in dockstar.c > > Signed-off-by: Eric Cooper <ecc@cmu.edu> > --- > board/Seagate/dockstar/dockstar.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) There is another similar patch also fixing compiler warning for mvgbe.c: http://patchwork.ozlabs.org/patch/122552/ Thanks, Anatolij
On Sat, Oct 29, 2011 at 09:41:45PM +0200, Anatolij Gustschin wrote: > There is another similar patch also fixing compiler warning for mvgbe.c: > > http://patchwork.ozlabs.org/patch/122552/ Yes, please go ahead and use yours. I'd suggest moving the #includes in dockstar.c up a few lines, though, so that '#include "dockstar.h"' is the last one, to be consistent with other board files like sheevaplug.c etc.
diff --git a/board/Seagate/dockstar/dockstar.c b/board/Seagate/dockstar/dockstar.c index cab3a83..9aab62d 100644 --- a/board/Seagate/dockstar/dockstar.c +++ b/board/Seagate/dockstar/dockstar.c @@ -27,6 +27,8 @@ #include <common.h> #include <miiphy.h> +#include <asm/io.h> +#include <asm/arch/cpu.h> #include <asm/arch/kirkwood.h> #include <asm/arch/mpp.h> #include "dockstar.h"
Commit a7efd719f415833a833d6a8e46bcd470a0847ecc removed some #includes from kirkwood.h that must now be done in dockstar.c Signed-off-by: Eric Cooper <ecc@cmu.edu> --- board/Seagate/dockstar/dockstar.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)