diff mbox

[U-Boot,3/8] PPC: Fix i82365.c by removing ifdef around "buf"

Message ID 1317603450-7527-4-git-send-email-marek.vasut@gmail.com
State Changes Requested
Headers show

Commit Message

Marek Vasut Oct. 3, 2011, 12:57 a.m. UTC 
From: Marek Vasut <marex@pollux.denx.de>

As the "buf" is cleared at runtime, this might introduce a slight overhead.

Signed-off-by: Marek Vasut <marex@pollux.denx.de>
---
 drivers/pcmcia/i82365.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)


Q: Can this be squashed into char buf[200] = {0}; ? That'd help the
   optimization to remove the overhead altogether again.

Comments

Wolfgang Denk Oct. 3, 2011, 2:29 p.m. UTC | #1 
Dear Marek Vasut,

In message <1317603450-7527-4-git-send-email-marek.vasut@gmail.com> you wrote:
> From: Marek Vasut <marex@pollux.denx.de>

Fix...

> As the "buf" is cleared at runtime, this might introduce a slight overhead.
> 
> Signed-off-by: Marek Vasut <marex@pollux.denx.de>
> ---
>  drivers/pcmcia/i82365.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)

NAK due to code size increase.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/drivers/pcmcia/i82365.c b/drivers/pcmcia/i82365.c
index 1bcb3a5..968d35a 100644
--- a/drivers/pcmcia/i82365.c
+++ b/drivers/pcmcia/i82365.c
@@ -272,11 +272,9 @@  static u_int cirrus_set_opts (socket_info_t * s)
 {
 	cirrus_state_t *p = &s->c_state;
 	u_int mask = 0xffff;
-#if DEBUG
 	char buf[200];
 
 	memset (buf, 0, 200);
-#endif
 
 	if (has_ring == -1)
 		has_ring = 1;