diff mbox

[U-Boot,v3] Let source cross-reference targets follow symbolic links

Message ID 1310988078-30444-1-git-send-email-hkronsto@frequentis.com
State Accepted
Commit 857d9ea67a4d70baf88a4495f8b70fef9f626ddc
Headers show

Commit Message

Horst Kronstorfer July 18, 2011, 11:21 a.m. UTC
From: Horst Kronstorfer <hkronsto@frequentis.com>

Tell 'find' to follow symbolic links, so that files under include/asm
and arch/$(ARCH)/include/asm/arch are added to the indexing file list.

Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
---
Changes for v2:
    - Apply this change to all source cross-reference targets
Changes for v3:
    - Introduce FINDFLAGS

 Makefile |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

Comments

Detlev Zundel July 19, 2011, 4:32 p.m. UTC | #1
Hi,

> From: Horst Kronstorfer <hkronsto@frequentis.com>
>
> Tell 'find' to follow symbolic links, so that files under include/asm
> and arch/$(ARCH)/include/asm/arch are added to the indexing file list.
>
> Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>

I guess I would have placed the definitions more at the beginning of the
makefile but probably that's personal taste.  So

Acked-by: Detlev Zundel <dzu@denx.de>

Thanks!
  Detlev
Wolfgang Denk July 28, 2011, 2:30 p.m. UTC | #2
Dear hkronsto@frequentis.com,

In message <1310988078-30444-1-git-send-email-hkronsto@frequentis.com> you wrote:
> From: Horst Kronstorfer <hkronsto@frequentis.com>
> 
> Tell 'find' to follow symbolic links, so that files under include/asm
> and arch/$(ARCH)/include/asm/arch are added to the indexing file list.
> 
> Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
> ---
> Changes for v2:
>     - Apply this change to all source cross-reference targets
> Changes for v3:
>     - Introduce FINDFLAGS
> 
>  Makefile |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/Makefile b/Makefile
index e56fa02..bc51428 100644
--- a/Makefile
+++ b/Makefile
@@ -471,15 +471,19 @@  TAG_SUBDIRS = $(SUBDIRS)
 TAG_SUBDIRS += $(dir $(__LIBS))
 TAG_SUBDIRS += include
 
+FIND := find
+FINDFLAGS := -L
+
 tags ctags:
-		ctags -w -o $(obj)ctags `find $(TAG_SUBDIRS) \
+		ctags -w -o $(obj)ctags `$(FIND) $(FINDFLAGS) $(TAG_SUBDIRS) \
 						-name '*.[chS]' -print`
 
 etags:
-		etags -a -o $(obj)etags `find $(TAG_SUBDIRS) \
+		etags -a -o $(obj)etags `$(FIND) $(FINDFLAGS) $(TAG_SUBDIRS) \
 						-name '*.[chS]' -print`
 cscope:
-		find $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files
+		$(FIND) $(FINDFLAGS) $(TAG_SUBDIRS) -name '*.[chS]' -print > \
+						cscope.files
 		cscope -b -q -k
 
 SYSTEM_MAP = \