| Message ID | 1301642195-15280-2-git-send-email-hs@denx.de |
|---|---|
| State | Accepted |
| Commit | 7c6db910492520a4b21bdd9071d89b6f87069d13 |
| Headers | show |
On Fri, 1 Apr 2011 09:16:13 +0200 Heiko Schocher <hs@denx.de> wrote: > add following functions to common.h, to prevent > extern declarations: > > void disable_addr_trans(void); > void enable_addr_trans(void); > void ddr_enable_ecc(unsigned int dram_size); > > Signed-off-by: Heiko Schocher <hs@denx.de> > cc: Kim Phillips <kim.phillips@freescale.com> > cc: Holger Brunck <holger.brunck@keymile.com> > cc: Wolfgang Denk <wd@denx.de> > cc: Detlev Zundel <dzu@denx.de> > cc: Valentin Longchamp <valentin.longchamp@keymile.com> > --- Signed-off-by: Kim Phillips <kim.phillips@freescale.com> Kim
Hi Kim, Le 02/04/2011 00:31, Kim Phillips a écrit : > On Fri, 1 Apr 2011 09:16:13 +0200 > Heiko Schocher<hs@denx.de> wrote: > >> add following functions to common.h, to prevent >> extern declarations: >> >> void disable_addr_trans(void); >> void enable_addr_trans(void); >> void ddr_enable_ecc(unsigned int dram_size); >> >> Signed-off-by: Heiko Schocher<hs@denx.de> >> cc: Kim Phillips<kim.phillips@freescale.com> >> cc: Holger Brunck<holger.brunck@keymile.com> >> cc: Wolfgang Denk<wd@denx.de> >> cc: Detlev Zundel<dzu@denx.de> >> cc: Valentin Longchamp<valentin.longchamp@keymile.com> >> --- > > Signed-off-by: Kim Phillips<kim.phillips@freescale.com> Do you mean Acked-by? Amicalement,
On Sat, 2 Apr 2011 15:04:00 +0200 Albert ARIBAUD <albert.aribaud@free.fr> wrote: > Le 02/04/2011 00:31, Kim Phillips a écrit : > > On Fri, 1 Apr 2011 09:16:13 +0200 > > Heiko Schocher<hs@denx.de> wrote: > > > >> add following functions to common.h, to prevent > >> extern declarations: > >> > >> void disable_addr_trans(void); > >> void enable_addr_trans(void); > >> void ddr_enable_ecc(unsigned int dram_size); > >> > >> Signed-off-by: Heiko Schocher<hs@denx.de> > >> cc: Kim Phillips<kim.phillips@freescale.com> > >> cc: Holger Brunck<holger.brunck@keymile.com> > >> cc: Wolfgang Denk<wd@denx.de> > >> cc: Detlev Zundel<dzu@denx.de> > >> cc: Valentin Longchamp<valentin.longchamp@keymile.com> > >> --- > > > > Signed-off-by: Kim Phillips<kim.phillips@freescale.com> > > Do you mean Acked-by? sure. Kim
diff --git a/include/common.h b/include/common.h index d8c912d..2d6980a 100644 --- a/include/common.h +++ b/include/common.h @@ -447,6 +447,11 @@ void out16(unsigned int, unsigned short value); #if defined (CONFIG_MPC83xx) void ppcDWload(unsigned int *addr, unsigned int *ret); void ppcDWstore(unsigned int *addr, unsigned int *value); +void disable_addr_trans(void); +void enable_addr_trans(void); +#if defined(CONFIG_DDR_ECC) && !defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER) +void ddr_enable_ecc(unsigned int dram_size); +#endif #endif /* $(CPU)/cpu.c */
add following functions to common.h, to prevent extern declarations: void disable_addr_trans(void); void enable_addr_trans(void); void ddr_enable_ecc(unsigned int dram_size); Signed-off-by: Heiko Schocher <hs@denx.de> cc: Kim Phillips <kim.phillips@freescale.com> cc: Holger Brunck <holger.brunck@keymile.com> cc: Wolfgang Denk <wd@denx.de> cc: Detlev Zundel <dzu@denx.de> cc: Valentin Longchamp <valentin.longchamp@keymile.com> --- Changes for v3: - new patch in v3, to avoid externs in keymile code Changes for v4: - add the functions in include/common.h not in include/mpc83xx.h as Kim Phillips suggested include/common.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)