| Message ID | 0e0cfb7afae9dc710af285909dc0009fd87f9356.1576767508.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | 724caaba4c32a375b32674dab0ff1638054ff317 |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | arm64: zynqmp: Do not call bss init and board_init_r from board_init_f | expand |
čt 19. 12. 2019 v 15:58 odesílatel Michal Simek <michal.simek@xilinx.com> napsal: > > There is no reason to clear bss and call board_init_r() from board_init_f() > beca it can be called directly from crt0_64.S with also support for SPL > stack relocation to SDRAM. > For more information please take a look at arch/arm/lib/crt0_64.S > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > arch/arm/mach-zynqmp/spl.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/arm/mach-zynqmp/spl.c b/arch/arm/mach-zynqmp/spl.c > index 76bafcdd2a38..095b4e61a590 100644 > --- a/arch/arm/mach-zynqmp/spl.c > +++ b/arch/arm/mach-zynqmp/spl.c > @@ -28,13 +28,6 @@ void board_init_f(ulong dummy) > #endif > /* Delay is required for clocks to be propagated */ > udelay(1000000); > - > - debug("Clearing BSS 0x%p - 0x%p\n", __bss_start, __bss_end); > - /* Clear the BSS */ > - memset(__bss_start, 0, __bss_end - __bss_start); > - > - /* No need to call timer init - it is empty for ZynqMP */ > - board_init_r(NULL, 0); > } > > static void ps_mode_reset(ulong mode) > -- > 2.24.0 > Applied. M
diff --git a/arch/arm/mach-zynqmp/spl.c b/arch/arm/mach-zynqmp/spl.c index 76bafcdd2a38..095b4e61a590 100644 --- a/arch/arm/mach-zynqmp/spl.c +++ b/arch/arm/mach-zynqmp/spl.c @@ -28,13 +28,6 @@ void board_init_f(ulong dummy) #endif /* Delay is required for clocks to be propagated */ udelay(1000000); - - debug("Clearing BSS 0x%p - 0x%p\n", __bss_start, __bss_end); - /* Clear the BSS */ - memset(__bss_start, 0, __bss_end - __bss_start); - - /* No need to call timer init - it is empty for ZynqMP */ - board_init_r(NULL, 0); } static void ps_mode_reset(ulong mode)
There is no reason to clear bss and call board_init_r() from board_init_f() beca it can be called directly from crt0_64.S with also support for SPL stack relocation to SDRAM. For more information please take a look at arch/arm/lib/crt0_64.S Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- arch/arm/mach-zynqmp/spl.c | 7 ------- 1 file changed, 7 deletions(-)