| Message ID | 0bf164f937df551d689dda2a35f9489c2e46b4ab.1638277017.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | ac64f536af078a2e5a9dce984b0e42d92e87f87e |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | dt-bindings: versal: Add new PM_DEV_I2C_PMC macro | expand |
On Tue, Nov 30, 2021 at 01:56:58PM +0100, Michal Simek wrote: > From: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@xilinx.com> > > Add new macro for PMC I2C power domain. > > Signed-off-by: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > include/dt-bindings/power/xlnx-versal-power.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/power/xlnx-versal-power.h b/include/dt-bindings/power/xlnx-versal-power.h > index 1b75175edce5..4a727754ad02 100644 > --- a/include/dt-bindings/power/xlnx-versal-power.h > +++ b/include/dt-bindings/power/xlnx-versal-power.h > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > /* > - * Copyright (C) 2019 - 2020 Xilinx, Inc. > + * Copyright (C) 2019 - 2021 Xilinx, Inc. > */ > > #ifndef _DT_BINDINGS_VERSAL_POWER_H > @@ -26,6 +26,7 @@ > #define PM_DEV_OSPI (0x1822402aU) > #define PM_DEV_QSPI (0x1822402bU) > #define PM_DEV_GPIO_PMC (0x1822402cU) > +#define PM_DEV_I2C_PMC (0x1822402dU) > #define PM_DEV_SDIO_0 (0x1822402eU) > #define PM_DEV_SDIO_1 (0x1822402fU) > #define PM_DEV_RTC (0x18224034U) So, where is this binding upstreamed, is it U-Boot specific?
On 11/30/21 17:56, Tom Rini wrote: > On Tue, Nov 30, 2021 at 01:56:58PM +0100, Michal Simek wrote: > >> From: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@xilinx.com> >> >> Add new macro for PMC I2C power domain. >> >> Signed-off-by: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@xilinx.com> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- >> >> include/dt-bindings/power/xlnx-versal-power.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/include/dt-bindings/power/xlnx-versal-power.h b/include/dt-bindings/power/xlnx-versal-power.h >> index 1b75175edce5..4a727754ad02 100644 >> --- a/include/dt-bindings/power/xlnx-versal-power.h >> +++ b/include/dt-bindings/power/xlnx-versal-power.h >> @@ -1,6 +1,6 @@ >> /* SPDX-License-Identifier: GPL-2.0 */ >> /* >> - * Copyright (C) 2019 - 2020 Xilinx, Inc. >> + * Copyright (C) 2019 - 2021 Xilinx, Inc. >> */ >> >> #ifndef _DT_BINDINGS_VERSAL_POWER_H >> @@ -26,6 +26,7 @@ >> #define PM_DEV_OSPI (0x1822402aU) >> #define PM_DEV_QSPI (0x1822402bU) >> #define PM_DEV_GPIO_PMC (0x1822402cU) >> +#define PM_DEV_I2C_PMC (0x1822402dU) >> #define PM_DEV_SDIO_0 (0x1822402eU) >> #define PM_DEV_SDIO_1 (0x1822402fU) >> #define PM_DEV_RTC (0x18224034U) > > So, where is this binding upstreamed, is it U-Boot specific? I didn't push this file to upstream Linux because didn't push any versal specific dtsi file there yet. But this file is just IDs which are used by power domain driver which is upstream already. Here you can see support for xlnx,versal-firmware driver. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/xilinx/zynqmp.c?h=v5.16-rc3#n1493 Here you can see full structure used on versal. https://github.com/Xilinx/u-boot-xlnx/blob/master/arch/arm/dts/versal-clk.dtsi#L153 Thanks, Michal
On Tue, Nov 30, 2021 at 06:48:02PM +0100, Michal Simek wrote: > > > On 11/30/21 17:56, Tom Rini wrote: > > On Tue, Nov 30, 2021 at 01:56:58PM +0100, Michal Simek wrote: > > > > > From: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@xilinx.com> > > > > > > Add new macro for PMC I2C power domain. > > > > > > Signed-off-by: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@xilinx.com> > > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > > > --- > > > > > > include/dt-bindings/power/xlnx-versal-power.h | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/include/dt-bindings/power/xlnx-versal-power.h b/include/dt-bindings/power/xlnx-versal-power.h > > > index 1b75175edce5..4a727754ad02 100644 > > > --- a/include/dt-bindings/power/xlnx-versal-power.h > > > +++ b/include/dt-bindings/power/xlnx-versal-power.h > > > @@ -1,6 +1,6 @@ > > > /* SPDX-License-Identifier: GPL-2.0 */ > > > /* > > > - * Copyright (C) 2019 - 2020 Xilinx, Inc. > > > + * Copyright (C) 2019 - 2021 Xilinx, Inc. > > > */ > > > #ifndef _DT_BINDINGS_VERSAL_POWER_H > > > @@ -26,6 +26,7 @@ > > > #define PM_DEV_OSPI (0x1822402aU) > > > #define PM_DEV_QSPI (0x1822402bU) > > > #define PM_DEV_GPIO_PMC (0x1822402cU) > > > +#define PM_DEV_I2C_PMC (0x1822402dU) > > > #define PM_DEV_SDIO_0 (0x1822402eU) > > > #define PM_DEV_SDIO_1 (0x1822402fU) > > > #define PM_DEV_RTC (0x18224034U) > > > > So, where is this binding upstreamed, is it U-Boot specific? > > I didn't push this file to upstream Linux because didn't push any versal > specific dtsi file there yet. But this file is just IDs which are used by > power domain driver which is upstream already. > > Here you can see support for xlnx,versal-firmware driver. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/xilinx/zynqmp.c?h=v5.16-rc3#n1493 > > Here you can see full structure used on versal. > > https://github.com/Xilinx/u-boot-xlnx/blob/master/arch/arm/dts/versal-clk.dtsi#L153 OK. Yeah, I don't have a problem with this patch as-is, but please do make sure it's on the TODO list to upstream this part as well. Thanks!
On 11/30/21 18:52, Tom Rini wrote: > On Tue, Nov 30, 2021 at 06:48:02PM +0100, Michal Simek wrote: >> >> >> On 11/30/21 17:56, Tom Rini wrote: >>> On Tue, Nov 30, 2021 at 01:56:58PM +0100, Michal Simek wrote: >>> >>>> From: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@xilinx.com> >>>> >>>> Add new macro for PMC I2C power domain. >>>> >>>> Signed-off-by: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@xilinx.com> >>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>>> --- >>>> >>>> include/dt-bindings/power/xlnx-versal-power.h | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/include/dt-bindings/power/xlnx-versal-power.h b/include/dt-bindings/power/xlnx-versal-power.h >>>> index 1b75175edce5..4a727754ad02 100644 >>>> --- a/include/dt-bindings/power/xlnx-versal-power.h >>>> +++ b/include/dt-bindings/power/xlnx-versal-power.h >>>> @@ -1,6 +1,6 @@ >>>> /* SPDX-License-Identifier: GPL-2.0 */ >>>> /* >>>> - * Copyright (C) 2019 - 2020 Xilinx, Inc. >>>> + * Copyright (C) 2019 - 2021 Xilinx, Inc. >>>> */ >>>> #ifndef _DT_BINDINGS_VERSAL_POWER_H >>>> @@ -26,6 +26,7 @@ >>>> #define PM_DEV_OSPI (0x1822402aU) >>>> #define PM_DEV_QSPI (0x1822402bU) >>>> #define PM_DEV_GPIO_PMC (0x1822402cU) >>>> +#define PM_DEV_I2C_PMC (0x1822402dU) >>>> #define PM_DEV_SDIO_0 (0x1822402eU) >>>> #define PM_DEV_SDIO_1 (0x1822402fU) >>>> #define PM_DEV_RTC (0x18224034U) >>> >>> So, where is this binding upstreamed, is it U-Boot specific? >> >> I didn't push this file to upstream Linux because didn't push any versal >> specific dtsi file there yet. But this file is just IDs which are used by >> power domain driver which is upstream already. >> >> Here you can see support for xlnx,versal-firmware driver. >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/xilinx/zynqmp.c?h=v5.16-rc3#n1493 >> >> Here you can see full structure used on versal. >> >> https://github.com/Xilinx/u-boot-xlnx/blob/master/arch/arm/dts/versal-clk.dtsi#L153 > > OK. Yeah, I don't have a problem with this patch as-is, but please do > make sure it's on the TODO list to upstream this part as well. Thanks! We are trying to upstream everything based on time we have. Thanks, Michal
út 30. 11. 2021 v 13:57 odesílatel Michal Simek <michal.simek@xilinx.com> napsal: > > From: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@xilinx.com> > > Add new macro for PMC I2C power domain. > > Signed-off-by: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > include/dt-bindings/power/xlnx-versal-power.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/power/xlnx-versal-power.h b/include/dt-bindings/power/xlnx-versal-power.h > index 1b75175edce5..4a727754ad02 100644 > --- a/include/dt-bindings/power/xlnx-versal-power.h > +++ b/include/dt-bindings/power/xlnx-versal-power.h > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > /* > - * Copyright (C) 2019 - 2020 Xilinx, Inc. > + * Copyright (C) 2019 - 2021 Xilinx, Inc. > */ > > #ifndef _DT_BINDINGS_VERSAL_POWER_H > @@ -26,6 +26,7 @@ > #define PM_DEV_OSPI (0x1822402aU) > #define PM_DEV_QSPI (0x1822402bU) > #define PM_DEV_GPIO_PMC (0x1822402cU) > +#define PM_DEV_I2C_PMC (0x1822402dU) > #define PM_DEV_SDIO_0 (0x1822402eU) > #define PM_DEV_SDIO_1 (0x1822402fU) > #define PM_DEV_RTC (0x18224034U) > -- > 2.33.1 > Applied. M
diff --git a/include/dt-bindings/power/xlnx-versal-power.h b/include/dt-bindings/power/xlnx-versal-power.h index 1b75175edce5..4a727754ad02 100644 --- a/include/dt-bindings/power/xlnx-versal-power.h +++ b/include/dt-bindings/power/xlnx-versal-power.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * Copyright (C) 2019 - 2020 Xilinx, Inc. + * Copyright (C) 2019 - 2021 Xilinx, Inc. */ #ifndef _DT_BINDINGS_VERSAL_POWER_H @@ -26,6 +26,7 @@ #define PM_DEV_OSPI (0x1822402aU) #define PM_DEV_QSPI (0x1822402bU) #define PM_DEV_GPIO_PMC (0x1822402cU) +#define PM_DEV_I2C_PMC (0x1822402dU) #define PM_DEV_SDIO_0 (0x1822402eU) #define PM_DEV_SDIO_1 (0x1822402fU) #define PM_DEV_RTC (0x18224034U)