mbox series

[0/3] phy: marvell: cp110: fix Armada 8k rev B0 boot hang

Message ID cover.1603027887.git.baruch@tkos.co.il
Headers show
Series phy: marvell: cp110: fix Armada 8k rev B0 boot hang | expand

Message

Baruch Siach Oct. 18, 2020, 2:11 p.m. UTC 
Boot of Armada 8040 rev B0 hangs when U-Boot attempts to initialize the PCIe 
serdes. Adapt patches from downstream Marvell tree that move serdes 
initialization to ATF.

This series requires upstream ATF version 2.1 or newer.

Grzegorz Jaszczyk (2):
  phy: marvell: cp110: let the firmware configure the comphy
  phy: marvell: cp110: let the firmware configure comphy for PCIe

Igal Liberman (1):
  phy: marvell: cp110: update mode parameter for pcie power on calls

 drivers/phy/marvell/comphy_cp110.c | 1270 +++-------------------------
 1 file changed, 104 insertions(+), 1166 deletions(-)

Comments

Stefan Roese Oct. 20, 2020, 7:38 a.m. UTC | #1 
Hi Baruch,

On 18.10.20 16:11, Baruch Siach wrote:
> Boot of Armada 8040 rev B0 hangs when U-Boot attempts to initialize the PCIe
> serdes. Adapt patches from downstream Marvell tree that move serdes
> initialization to ATF.
> 
> This series requires upstream ATF version 2.1 or newer.

Is there a way to detect if an older ATF is installed and print
an error message (warning) in this case?

Thanks,
Stefan
Baruch Siach Oct. 20, 2020, 9:12 a.m. UTC | #2 
Hi Stefan,

On Tue, Oct 20 2020, Stefan Roese wrote:
> On 18.10.20 16:11, Baruch Siach wrote:
>> Boot of Armada 8040 rev B0 hangs when U-Boot attempts to initialize the PCIe
>> serdes. Adapt patches from downstream Marvell tree that move serdes
>> initialization to ATF.
>>
>> This series requires upstream ATF version 2.1 or newer.
>
> Is there a way to detect if an older ATF is installed and print
> an error message (warning) in this case?

I see no way to detect ATF version using smc_call().

Downstream Marvell ATF have the required code[1] in the 18.12.2
release[2], which is based on ATF 1.5. This is the last ATF version from
Marvell that was released on github.

[1] https://github.com/MarvellEmbeddedProcessors/atf-marvell/commit/4db85ae088a5e2f51e9a5a671f531cb80a632067

[2] https://github.com/MarvellEmbeddedProcessors/atf-marvell/commits/atf-v1.5-armada-18.12

baruch
Stefan Roese Oct. 29, 2020, 2:29 p.m. UTC | #3 
On 18.10.20 16:11, Baruch Siach wrote:
> Boot of Armada 8040 rev B0 hangs when U-Boot attempts to initialize the PCIe
> serdes. Adapt patches from downstream Marvell tree that move serdes
> initialization to ATF.
> 
> This series requires upstream ATF version 2.1 or newer.
> 
> Grzegorz Jaszczyk (2):
>    phy: marvell: cp110: let the firmware configure the comphy
>    phy: marvell: cp110: let the firmware configure comphy for PCIe
> 
> Igal Liberman (1):
>    phy: marvell: cp110: update mode parameter for pcie power on calls
> 
>   drivers/phy/marvell/comphy_cp110.c | 1270 +++-------------------------
>   1 file changed, 104 insertions(+), 1166 deletions(-)
> 

Applied to u-boot-marvell/master

Thanks,
Stefan