mbox series

[0/3] Fix driver for misc/atsha204a

Message ID 20240219163213.855667-1-barnas@google.com
Headers show
Series Fix driver for misc/atsha204a | expand

Message

Michał Barnaś Feb. 19, 2024, 4:32 p.m. UTC 
Fix the driver to behave like the chip datasheet requires.
Improve wake up function to send low signal on SDA line for at least
60us as chip requires to wake up. Fix sleep function to move the chip
into sleep mode, not into idle mode. Remove unnecessary for loop,
which would never run for more than one iteration.



Michał Barnaś (3):
  misc: atsha204a: remove broken for loop
  misc: atsha204a: fix sleep function
  misc: atsha204a: fix wakeup function

 drivers/misc/atsha204a-i2c.c | 90 ++++++++++++++++++++++++------------
 1 file changed, 61 insertions(+), 29 deletions(-)

Comments

Tom Rini March 5, 2024, 1:17 p.m. UTC | #1 
On Mon, 19 Feb 2024 16:32:01 +0000, Michał Barnaś wrote:

> Fix the driver to behave like the chip datasheet requires.
> Improve wake up function to send low signal on SDA line for at least
> 60us as chip requires to wake up. Fix sleep function to move the chip
> into sleep mode, not into idle mode. Remove unnecessary for loop,
> which would never run for more than one iteration.
> 
> 
> [...]

Applied to u-boot/next, thanks!
Michał Barnaś March 8, 2024, 5:13 p.m. UTC | #2 
Thank you very much!

On Tue, Mar 5, 2024 at 2:17 PM Tom Rini <trini@konsulko.com> wrote:
>
> On Mon, 19 Feb 2024 16:32:01 +0000, Michał Barnaś wrote:
>
> > Fix the driver to behave like the chip datasheet requires.
> > Improve wake up function to send low signal on SDA line for at least
> > 60us as chip requires to wake up. Fix sleep function to move the chip
> > into sleep mode, not into idle mode. Remove unnecessary for loop,
> > which would never run for more than one iteration.
> >
> >
> > [...]
>
> Applied to u-boot/next, thanks!
>
> --
> Tom
>
>