| Message ID | 20230720145010.84791-1-detlev.casanova@collabora.com |
|---|---|
| Headers | show |
| Series | Introduce the sysinfo command | expand |
On Thu, Jul 20, 2023 at 3:50 PM Detlev Casanova <detlev.casanova@collabora.com> wrote: > > The command can be used to show various information that can be used to > identify the running system. > > Currently supported subcommands are: > * model: A string representing the model > * id: The id of the board > * revision: The revision of this board. How does this differ from the bdinfo and some of the other commands that provide similar info? > Changes since v3: > - Fix documentation typo. > Changes since v2: > - Fix code style. > - Use printf() instead of debug(). > - Clarify sysinfo new ids types (int). > - Add a test for sysinfo command. > - Add documentation for sysinfo command. > Changes since v1: > - Removed shell function to select linux device tree. This will be > distributions job. > - Break revision in rev_major and rev_minor in the sysinfo driver. > > Detlev Casanova (6): > sysinfo: Add IDs for board id and revision > cmd: Add a sysinfo command > sysinfo: Add a test > sysinfo: Add documentation > sysinfo: rcar3: Use int instead of char for revision > sysinfo: rcar3: Implement BOARD_ID and BOARD_REV_* > > cmd/Kconfig | 6 ++ > cmd/Makefile | 1 + > cmd/sysinfo.c | 133 +++++++++++++++++++++++++++++++++++ > configs/sandbox_defconfig | 1 + > doc/usage/cmd/sysinfo.rst | 56 +++++++++++++++ > drivers/sysinfo/rcar3.c | 141 ++++++++++++++++++++++++++------------ > drivers/sysinfo/sandbox.c | 17 +++++ > include/sysinfo.h | 5 ++ > test/cmd/Makefile | 1 + > test/cmd/test_sysinfo.c | 51 ++++++++++++++ > 10 files changed, 370 insertions(+), 42 deletions(-) > create mode 100644 cmd/sysinfo.c > create mode 100644 doc/usage/cmd/sysinfo.rst > create mode 100644 test/cmd/test_sysinfo.c > > -- > 2.41.0 >
On Tuesday, August 8, 2023 10:21:11 A.M. EDT Peter Robinson wrote: > On Thu, Jul 20, 2023 at 3:50 PM Detlev Casanova > > <detlev.casanova@collabora.com> wrote: > > The command can be used to show various information that can be used to > > identify the running system. > > > > Currently supported subcommands are: > > * model: A string representing the model > > * id: The id of the board > > * revision: The revision of this board. > > How does this differ from the bdinfo and some of the other commands > that provide similar info? If I'm not wrong, the bdinfo command is about showing what hardware is present on the board. The sysinfo command is about showing board identification information. > > Changes since v3: > > - Fix documentation typo. > > > > Changes since v2: > > - Fix code style. > > - Use printf() instead of debug(). > > - Clarify sysinfo new ids types (int). > > - Add a test for sysinfo command. > > - Add documentation for sysinfo command. > > > > Changes since v1: > > - Removed shell function to select linux device tree. This will be > > > > distributions job. > > > > - Break revision in rev_major and rev_minor in the sysinfo driver. > > > > Detlev Casanova (6): > > sysinfo: Add IDs for board id and revision > > cmd: Add a sysinfo command > > sysinfo: Add a test > > sysinfo: Add documentation > > sysinfo: rcar3: Use int instead of char for revision > > sysinfo: rcar3: Implement BOARD_ID and BOARD_REV_* > > > > cmd/Kconfig | 6 ++ > > cmd/Makefile | 1 + > > cmd/sysinfo.c | 133 +++++++++++++++++++++++++++++++++++ > > configs/sandbox_defconfig | 1 + > > doc/usage/cmd/sysinfo.rst | 56 +++++++++++++++ > > drivers/sysinfo/rcar3.c | 141 ++++++++++++++++++++++++++------------ > > drivers/sysinfo/sandbox.c | 17 +++++ > > include/sysinfo.h | 5 ++ > > test/cmd/Makefile | 1 + > > test/cmd/test_sysinfo.c | 51 ++++++++++++++ > > 10 files changed, 370 insertions(+), 42 deletions(-) > > create mode 100644 cmd/sysinfo.c > > create mode 100644 doc/usage/cmd/sysinfo.rst > > create mode 100644 test/cmd/test_sysinfo.c > > > > -- > > 2.41.0
On Tue, Aug 8, 2023 at 3:27 PM Detlev Casanova <detlev.casanova@collabora.com> wrote: > > On Tuesday, August 8, 2023 10:21:11 A.M. EDT Peter Robinson wrote: > > On Thu, Jul 20, 2023 at 3:50 PM Detlev Casanova > > > > <detlev.casanova@collabora.com> wrote: > > > The command can be used to show various information that can be used to > > > identify the running system. > > > > > > Currently supported subcommands are: > > > * model: A string representing the model > > > * id: The id of the board > > > * revision: The revision of this board. > > > > How does this differ from the bdinfo and some of the other commands > > that provide similar info? > > If I'm not wrong, the bdinfo command is about showing what hardware is > present on the board. The sysinfo command is about showing board > identification information. Why can't bdinfo be extended rather than adding yet another command? > > > Changes since v3: > > > - Fix documentation typo. > > > > > > Changes since v2: > > > - Fix code style. > > > - Use printf() instead of debug(). > > > - Clarify sysinfo new ids types (int). > > > - Add a test for sysinfo command. > > > - Add documentation for sysinfo command. > > > > > > Changes since v1: > > > - Removed shell function to select linux device tree. This will be > > > > > > distributions job. > > > > > > - Break revision in rev_major and rev_minor in the sysinfo driver. > > > > > > Detlev Casanova (6): > > > sysinfo: Add IDs for board id and revision > > > cmd: Add a sysinfo command > > > sysinfo: Add a test > > > sysinfo: Add documentation > > > sysinfo: rcar3: Use int instead of char for revision > > > sysinfo: rcar3: Implement BOARD_ID and BOARD_REV_* > > > > > > cmd/Kconfig | 6 ++ > > > cmd/Makefile | 1 + > > > cmd/sysinfo.c | 133 +++++++++++++++++++++++++++++++++++ > > > configs/sandbox_defconfig | 1 + > > > doc/usage/cmd/sysinfo.rst | 56 +++++++++++++++ > > > drivers/sysinfo/rcar3.c | 141 ++++++++++++++++++++++++++------------ > > > drivers/sysinfo/sandbox.c | 17 +++++ > > > include/sysinfo.h | 5 ++ > > > test/cmd/Makefile | 1 + > > > test/cmd/test_sysinfo.c | 51 ++++++++++++++ > > > 10 files changed, 370 insertions(+), 42 deletions(-) > > > create mode 100644 cmd/sysinfo.c > > > create mode 100644 doc/usage/cmd/sysinfo.rst > > > create mode 100644 test/cmd/test_sysinfo.c > > > > > > -- > > > 2.41.0 > > > >
On 8/8/23 16:31, Peter Robinson wrote: > On Tue, Aug 8, 2023 at 3:27 PM Detlev Casanova > <detlev.casanova@collabora.com> wrote: >> >> On Tuesday, August 8, 2023 10:21:11 A.M. EDT Peter Robinson wrote: >>> On Thu, Jul 20, 2023 at 3:50 PM Detlev Casanova >>> >>> <detlev.casanova@collabora.com> wrote: >>>> The command can be used to show various information that can be used to >>>> identify the running system. >>>> >>>> Currently supported subcommands are: >>>> * model: A string representing the model >>>> * id: The id of the board >>>> * revision: The revision of this board. >>> >>> How does this differ from the bdinfo and some of the other commands >>> that provide similar info? >> >> If I'm not wrong, the bdinfo command is about showing what hardware is >> present on the board. The sysinfo command is about showing board >> identification information. > > Why can't bdinfo be extended rather than adding yet another command? It could , but it feels like overloading bdinfo . Sysinfo is system identification (i.e. stuff in eeprom), bdinfo is things like memory layout.