mbox series

[v2,0/5] Support the required clocks to enable USB on SAM9X60

Message ID 20230308143954.1580743-1-claudiu.beznea@microchip.com
Headers show
Series Support the required clocks to enable USB on SAM9X60 | expand

Message

Claudiu Beznea March 8, 2023, 2:39 p.m. UTC
This patch series originates from a bigger patch series:
https://lists.denx.de/pipermail/u-boot/2022-December/502865.html

A driver for clock operations on SAM9X60's USB clock has been added as
well as its registration on CCF. In order for USB to work properly, the
UPLL and USBCK need an initial frequency before probing the OHCI/EHCI
driver. Furthermore enable this driver in the defconfigs.

Changes in v2:
- fix build error for sam9x60_curiosity_mmc1_defconfig
- took over the upstream process from Sergiu

Claudiu Beznea (1):
  clk: at91: pmc: export clock setup to pmc

Sergiu Moga (4):
  clk: at91: Add support for sam9x60 USB clock
  clk: at91: sam9x60: Register the required clocks for USB
  clk: at91: sam9x60: Add initial setup of UPLL and USBCK rates
  configs: at91: sam9x60: Add required configs for the USB clock

 configs/sam9x60_curiosity_mmc1_defconfig |   1 +
 configs/sam9x60_curiosity_mmc_defconfig  |   1 +
 configs/sam9x60ek_mmc_defconfig          |   1 +
 configs/sam9x60ek_nandflash_defconfig    |   1 +
 configs/sam9x60ek_qspiflash_defconfig    |   1 +
 drivers/clk/at91/Kconfig                 |   7 +
 drivers/clk/at91/Makefile                |   1 +
 drivers/clk/at91/clk-sam9x60-usb.c       | 157 +++++++++++++++++++++++
 drivers/clk/at91/pmc.c                   |  42 ++++++
 drivers/clk/at91/pmc.h                   |  27 ++++
 drivers/clk/at91/sam9x60.c               |  63 +++++++++
 drivers/clk/at91/sama7g5.c               |  48 +------
 12 files changed, 308 insertions(+), 42 deletions(-)
 create mode 100644 drivers/clk/at91/clk-sam9x60-usb.c

Comments

Eugen Hristev March 9, 2023, 12:30 p.m. UTC | #1
On 3/8/23 16:39, Claudiu Beznea wrote:
> This patch series originates from a bigger patch series:
> https://lists.denx.de/pipermail/u-boot/2022-December/502865.html
> 
> A driver for clock operations on SAM9X60's USB clock has been added as
> well as its registration on CCF. In order for USB to work properly, the
> UPLL and USBCK need an initial frequency before probing the OHCI/EHCI
> driver. Furthermore enable this driver in the defconfigs.
> 
> Changes in v2:
> - fix build error for sam9x60_curiosity_mmc1_defconfig
> - took over the upstream process from Sergiu
> 
> Claudiu Beznea (1):
>    clk: at91: pmc: export clock setup to pmc
> 
> Sergiu Moga (4):
>    clk: at91: Add support for sam9x60 USB clock
>    clk: at91: sam9x60: Register the required clocks for USB
>    clk: at91: sam9x60: Add initial setup of UPLL and USBCK rates
>    configs: at91: sam9x60: Add required configs for the USB clock
> 
>   configs/sam9x60_curiosity_mmc1_defconfig |   1 +
>   configs/sam9x60_curiosity_mmc_defconfig  |   1 +
>   configs/sam9x60ek_mmc_defconfig          |   1 +
>   configs/sam9x60ek_nandflash_defconfig    |   1 +
>   configs/sam9x60ek_qspiflash_defconfig    |   1 +
>   drivers/clk/at91/Kconfig                 |   7 +
>   drivers/clk/at91/Makefile                |   1 +
>   drivers/clk/at91/clk-sam9x60-usb.c       | 157 +++++++++++++++++++++++
>   drivers/clk/at91/pmc.c                   |  42 ++++++
>   drivers/clk/at91/pmc.h                   |  27 ++++
>   drivers/clk/at91/sam9x60.c               |  63 +++++++++
>   drivers/clk/at91/sama7g5.c               |  48 +------
>   12 files changed, 308 insertions(+), 42 deletions(-)
>   create mode 100644 drivers/clk/at91/clk-sam9x60-usb.c
> 

Thank you Claudiu for resubmitting this series, I have collected a 
branch with all the patches (USB , clocks and defconfigs), available here:

https://source.denx.de/u-boot/custodians/u-boot-at91/-/tree/testing

Eugen
Eugen Hristev March 17, 2023, 6:34 p.m. UTC | #2
On 3/9/23 14:30, Eugen Hristev wrote:
> On 3/8/23 16:39, Claudiu Beznea wrote:
>> This patch series originates from a bigger patch series:
>> https://lists.denx.de/pipermail/u-boot/2022-December/502865.html
>>
>> A driver for clock operations on SAM9X60's USB clock has been added as
>> well as its registration on CCF. In order for USB to work properly, the
>> UPLL and USBCK need an initial frequency before probing the OHCI/EHCI
>> driver. Furthermore enable this driver in the defconfigs.
>>
>> Changes in v2:
>> - fix build error for sam9x60_curiosity_mmc1_defconfig
>> - took over the upstream process from Sergiu
>>
>> Claudiu Beznea (1):
>>    clk: at91: pmc: export clock setup to pmc
>>
>> Sergiu Moga (4):
>>    clk: at91: Add support for sam9x60 USB clock
>>    clk: at91: sam9x60: Register the required clocks for USB
>>    clk: at91: sam9x60: Add initial setup of UPLL and USBCK rates
>>    configs: at91: sam9x60: Add required configs for the USB clock
>>
>>   configs/sam9x60_curiosity_mmc1_defconfig |   1 +
>>   configs/sam9x60_curiosity_mmc_defconfig  |   1 +
>>   configs/sam9x60ek_mmc_defconfig          |   1 +
>>   configs/sam9x60ek_nandflash_defconfig    |   1 +
>>   configs/sam9x60ek_qspiflash_defconfig    |   1 +
>>   drivers/clk/at91/Kconfig                 |   7 +
>>   drivers/clk/at91/Makefile                |   1 +
>>   drivers/clk/at91/clk-sam9x60-usb.c       | 157 +++++++++++++++++++++++
>>   drivers/clk/at91/pmc.c                   |  42 ++++++
>>   drivers/clk/at91/pmc.h                   |  27 ++++
>>   drivers/clk/at91/sam9x60.c               |  63 +++++++++
>>   drivers/clk/at91/sama7g5.c               |  48 +------
>>   12 files changed, 308 insertions(+), 42 deletions(-)
>>   create mode 100644 drivers/clk/at91/clk-sam9x60-usb.c
>>
> 
> Thank you Claudiu for resubmitting this series, I have collected a 
> branch with all the patches (USB , clocks and defconfigs), available here:
> 
> https://source.denx.de/u-boot/custodians/u-boot-at91/-/tree/testing
> 
> Eugen


Hi Sean,

As you reviewed already the v1 of the series, would you like to take 
care of this v2 as well? Currently in patchwork the patches are assigned 
to me but feel free to take them or I can reassign them if you agree.

Thanks,
Eugen
Eugen Hristev March 27, 2023, 1:08 p.m. UTC | #3
On 3/17/23 20:34, Eugen Hristev wrote:
> On 3/9/23 14:30, Eugen Hristev wrote:
>> On 3/8/23 16:39, Claudiu Beznea wrote:
>>> This patch series originates from a bigger patch series:
>>> https://lists.denx.de/pipermail/u-boot/2022-December/502865.html
>>>
>>> A driver for clock operations on SAM9X60's USB clock has been added as
>>> well as its registration on CCF. In order for USB to work properly, the
>>> UPLL and USBCK need an initial frequency before probing the OHCI/EHCI
>>> driver. Furthermore enable this driver in the defconfigs.
>>>
>>> Changes in v2:
>>> - fix build error for sam9x60_curiosity_mmc1_defconfig
>>> - took over the upstream process from Sergiu
>>>
>>> Claudiu Beznea (1):
>>>    clk: at91: pmc: export clock setup to pmc
>>>
>>> Sergiu Moga (4):
>>>    clk: at91: Add support for sam9x60 USB clock
>>>    clk: at91: sam9x60: Register the required clocks for USB
>>>    clk: at91: sam9x60: Add initial setup of UPLL and USBCK rates
>>>    configs: at91: sam9x60: Add required configs for the USB clock
>>>
>>>   configs/sam9x60_curiosity_mmc1_defconfig |   1 +
>>>   configs/sam9x60_curiosity_mmc_defconfig  |   1 +
>>>   configs/sam9x60ek_mmc_defconfig          |   1 +
>>>   configs/sam9x60ek_nandflash_defconfig    |   1 +
>>>   configs/sam9x60ek_qspiflash_defconfig    |   1 +
>>>   drivers/clk/at91/Kconfig                 |   7 +
>>>   drivers/clk/at91/Makefile                |   1 +
>>>   drivers/clk/at91/clk-sam9x60-usb.c       | 157 +++++++++++++++++++++++
>>>   drivers/clk/at91/pmc.c                   |  42 ++++++
>>>   drivers/clk/at91/pmc.h                   |  27 ++++
>>>   drivers/clk/at91/sam9x60.c               |  63 +++++++++
>>>   drivers/clk/at91/sama7g5.c               |  48 +------
>>>   12 files changed, 308 insertions(+), 42 deletions(-)
>>>   create mode 100644 drivers/clk/at91/clk-sam9x60-usb.c
>>>
>>
>> Thank you Claudiu for resubmitting this series, I have collected a 
>> branch with all the patches (USB , clocks and defconfigs), available 
>> here:
>>
>> https://source.denx.de/u-boot/custodians/u-boot-at91/-/tree/testing
>>
>> Eugen
> 
> 
> Hi Sean,
> 
> As you reviewed already the v1 of the series, would you like to take 
> care of this v2 as well? Currently in patchwork the patches are assigned 
> to me but feel free to take them or I can reassign them if you agree.
> 
> Thanks,
> Eugen


Applied series to u-boot-at91/next, thanks !