mbox series

[v2,0/8] vidconsole: refactoring and support for wider fonts

Message ID 20230213165700.982691-1-dsankouski@gmail.com
Headers show
Series vidconsole: refactoring and support for wider fonts | expand

Message

Dzmitry Sankouski Feb. 13, 2023, 4:56 p.m. UTC
Modern mobile phones typically have high pixel density.
Bootmenu is hardly readable on those with 8x16 font.

This patch series aims to add wider fonts for devices with high ppi.

Add 16x32, 12x22 fonts from linux, and allow font size configuration.

There was significant changes in version 3:
- fix video tests failures
- add runtime font size configuration
- add test for 12x22 font

Dzmitry Sankouski (8):
  video console: unite normal and rotated files
  video console: refactoring and optimization
  video console: add support for fonts wider than 1 byte
  video console: add select font logic to vidconsole uclass driver
  video console: allow font size configuration at runtime
  video console: add 12x22 Sun font from linux
  video console: add 16x32 Terminus font from linux
  video console: add 12x22 console simple font test

 cmd/Kconfig                       |    8 +
 cmd/Makefile                      |    2 +-
 cmd/font.c                        |    7 +-
 common/splash.c                   |    7 +-
 configs/qemu-x86_defconfig        |    1 +
 configs/sandbox_defconfig         |    3 +
 drivers/video/Kconfig             |   38 +-
 drivers/video/Makefile            |    3 +-
 drivers/video/console_normal.c    |  178 -
 drivers/video/console_rotate.c    |  497 ---
 drivers/video/console_simple.c    |  638 +++
 drivers/video/console_truetype.c  |    6 +-
 drivers/video/vidconsole-uclass.c |   22 +
 include/video.h                   |    1 +
 include/video_console.h           |   18 +-
 include/video_font.h              |   31 +-
 include/video_font_4x6.h          |   11 +-
 include/video_font_8x16.h         | 4624 ++++++++++++++++++++++
 include/video_font_data.h         | 4644 +---------------------
 include/video_font_sun12x22.h     | 6158 +++++++++++++++++++++++++++++
 include/video_font_ter16x32.h     | 2062 ++++++++++
 test/dm/video.c                   |   41 +
 22 files changed, 13681 insertions(+), 5319 deletions(-)
 delete mode 100644 drivers/video/console_normal.c
 delete mode 100644 drivers/video/console_rotate.c
 create mode 100644 drivers/video/console_simple.c
 create mode 100644 include/video_font_8x16.h
 create mode 100644 include/video_font_sun12x22.h
 create mode 100644 include/video_font_ter16x32.h

Comments

Simon Glass Feb. 14, 2023, 1:14 p.m. UTC | #1
Hi Dzmitry,

On Mon, 13 Feb 2023 at 10:03, Dzmitry Sankouski <dsankouski@gmail.com> wrote:
>
> Modern mobile phones typically have high pixel density.
> Bootmenu is hardly readable on those with 8x16 font.
>
> This patch series aims to add wider fonts for devices with high ppi.
>
> Add 16x32, 12x22 fonts from linux, and allow font size configuration.
>
> There was significant changes in version 3:
> - fix video tests failures
> - add runtime font size configuration
> - add test for 12x22 font
>
> Dzmitry Sankouski (8):
>   video console: unite normal and rotated files
>   video console: refactoring and optimization
>   video console: add support for fonts wider than 1 byte
>   video console: add select font logic to vidconsole uclass driver
>   video console: allow font size configuration at runtime
>   video console: add 12x22 Sun font from linux
>   video console: add 16x32 Terminus font from linux
>   video console: add 12x22 console simple font test
>
>  cmd/Kconfig                       |    8 +
>  cmd/Makefile                      |    2 +-
>  cmd/font.c                        |    7 +-
>  common/splash.c                   |    7 +-
>  configs/qemu-x86_defconfig        |    1 +
>  configs/sandbox_defconfig         |    3 +
>  drivers/video/Kconfig             |   38 +-
>  drivers/video/Makefile            |    3 +-
>  drivers/video/console_normal.c    |  178 -
>  drivers/video/console_rotate.c    |  497 ---
>  drivers/video/console_simple.c    |  638 +++
>  drivers/video/console_truetype.c  |    6 +-
>  drivers/video/vidconsole-uclass.c |   22 +
>  include/video.h                   |    1 +
>  include/video_console.h           |   18 +-
>  include/video_font.h              |   31 +-
>  include/video_font_4x6.h          |   11 +-
>  include/video_font_8x16.h         | 4624 ++++++++++++++++++++++
>  include/video_font_data.h         | 4644 +---------------------
>  include/video_font_sun12x22.h     | 6158 +++++++++++++++++++++++++++++
>  include/video_font_ter16x32.h     | 2062 ++++++++++
>  test/dm/video.c                   |   41 +
>  22 files changed, 13681 insertions(+), 5319 deletions(-)
>  delete mode 100644 drivers/video/console_normal.c
>  delete mode 100644 drivers/video/console_rotate.c
>  create mode 100644 drivers/video/console_simple.c
>  create mode 100644 include/video_font_8x16.h
>  create mode 100644 include/video_font_sun12x22.h
>  create mode 100644 include/video_font_ter16x32.h
>
> --
> 2.30.2
>

I am unable to apply these. Can you please check that they are against
-master or -next ?

Thanks,
Simon
Dzmitry Sankouski Feb. 14, 2023, 3:56 p.m. UTC | #2
Hi, I'll rebase it

вт, 14 февр. 2023 г. в 16:14, Simon Glass <sjg@chromium.org>:
>
> Hi Dzmitry,
>
> On Mon, 13 Feb 2023 at 10:03, Dzmitry Sankouski <dsankouski@gmail.com> wrote:
> >
> > Modern mobile phones typically have high pixel density.
> > Bootmenu is hardly readable on those with 8x16 font.
> >
> > This patch series aims to add wider fonts for devices with high ppi.
> >
> > Add 16x32, 12x22 fonts from linux, and allow font size configuration.
> >
> > There was significant changes in version 3:
> > - fix video tests failures
> > - add runtime font size configuration
> > - add test for 12x22 font
> >
> > Dzmitry Sankouski (8):
> >   video console: unite normal and rotated files
> >   video console: refactoring and optimization
> >   video console: add support for fonts wider than 1 byte
> >   video console: add select font logic to vidconsole uclass driver
> >   video console: allow font size configuration at runtime
> >   video console: add 12x22 Sun font from linux
> >   video console: add 16x32 Terminus font from linux
> >   video console: add 12x22 console simple font test
> >
> >  cmd/Kconfig                       |    8 +
> >  cmd/Makefile                      |    2 +-
> >  cmd/font.c                        |    7 +-
> >  common/splash.c                   |    7 +-
> >  configs/qemu-x86_defconfig        |    1 +
> >  configs/sandbox_defconfig         |    3 +
> >  drivers/video/Kconfig             |   38 +-
> >  drivers/video/Makefile            |    3 +-
> >  drivers/video/console_normal.c    |  178 -
> >  drivers/video/console_rotate.c    |  497 ---
> >  drivers/video/console_simple.c    |  638 +++
> >  drivers/video/console_truetype.c  |    6 +-
> >  drivers/video/vidconsole-uclass.c |   22 +
> >  include/video.h                   |    1 +
> >  include/video_console.h           |   18 +-
> >  include/video_font.h              |   31 +-
> >  include/video_font_4x6.h          |   11 +-
> >  include/video_font_8x16.h         | 4624 ++++++++++++++++++++++
> >  include/video_font_data.h         | 4644 +---------------------
> >  include/video_font_sun12x22.h     | 6158 +++++++++++++++++++++++++++++
> >  include/video_font_ter16x32.h     | 2062 ++++++++++
> >  test/dm/video.c                   |   41 +
> >  22 files changed, 13681 insertions(+), 5319 deletions(-)
> >  delete mode 100644 drivers/video/console_normal.c
> >  delete mode 100644 drivers/video/console_rotate.c
> >  create mode 100644 drivers/video/console_simple.c
> >  create mode 100644 include/video_font_8x16.h
> >  create mode 100644 include/video_font_sun12x22.h
> >  create mode 100644 include/video_font_ter16x32.h
> >
> > --
> > 2.30.2
> >
>
> I am unable to apply these. Can you please check that they are against
> -master or -next ?
>
> Thanks,
> Simon