| Message ID | 20221202172243.21046-1-holger.brunck@hitachienergy.com |
|---|---|
| Headers | show |
| Series | updates for km board series | expand |
On Fri, Dec 02, 2022 at 06:22:36PM +0100, Holger Brunck wrote: > - migrate all boards to environment.txt files > - migrate PPC boards to DM_I2C > - some cleanup > > Holger Brunck (7): > board/km: move ls102xa boards to environment text files > km/powerpc: migrate to env.txt file > board/km/cent2: migrate to environment text file > board/km/secu: migrate to use environment text files > board/km: remove obsolete ARCH_KIRKWOOD > km/ppc: migrate all mpc83xx to DM_I2C > km/mpc8360: remove unused CONFIG_SYS_PAXE defines Thanks for doing this. As this is the first in my mind big environment conversion, do you have any further feedback on the mechanism, things that would make this easier / more useful, etc?
> > - migrate all boards to environment.txt files > > - migrate PPC boards to DM_I2C > > - some cleanup > > > > Holger Brunck (7): > > board/km: move ls102xa boards to environment text files > > km/powerpc: migrate to env.txt file > > board/km/cent2: migrate to environment text file > > board/km/secu: migrate to use environment text files > > board/km: remove obsolete ARCH_KIRKWOOD > > km/ppc: migrate all mpc83xx to DM_I2C > > km/mpc8360: remove unused CONFIG_SYS_PAXE defines > > Thanks for doing this. As this is the first in my mind big environment conversion, > do you have any further feedback on the mechanism, things that would make > this easier / more useful, etc? > it was quite straight forward and especially for board series which use a hierarchical structure as we do it is easy to use and afterwards much easier to read and to maintain. I only struggled about the strings I had defined in Kconfig as discussed in another thread about double quoted strings. I removed them from there in the end. What would maybe be helpful to have a small script which converts the generated include/generated/environment.h into a textfile which then looks like the environment in your u-boot if you dump it. Then you can quickly do a diff between a dump from your old and your textfile to see if your newly migrated environment is identical. Best regards Holger
On Wed, Dec 07, 2022 at 02:27:37PM +0000, Holger Brunck wrote: > > > - migrate all boards to environment.txt files > > > - migrate PPC boards to DM_I2C > > > - some cleanup > > > > > > Holger Brunck (7): > > > board/km: move ls102xa boards to environment text files > > > km/powerpc: migrate to env.txt file > > > board/km/cent2: migrate to environment text file > > > board/km/secu: migrate to use environment text files > > > board/km: remove obsolete ARCH_KIRKWOOD > > > km/ppc: migrate all mpc83xx to DM_I2C > > > km/mpc8360: remove unused CONFIG_SYS_PAXE defines > > > > Thanks for doing this. As this is the first in my mind big environment conversion, > > do you have any further feedback on the mechanism, things that would make > > this easier / more useful, etc? > > > > it was quite straight forward and especially for board series which use a > hierarchical structure as we do it is easy to use and afterwards much easier to > read and to maintain. > > I only struggled about the strings I had defined in Kconfig as discussed in another > thread about double quoted strings. I removed them from there in the end. > > What would maybe be helpful to have a small script which converts the > generated include/generated/environment.h into a textfile which then looks > like the environment in your u-boot if you dump it. Then you can quickly do > a diff between a dump from your old and your textfile to see if your > newly migrated environment is identical. Ah good. Perhaps https://patchwork.ozlabs.org/project/uboot/patch/20221128084122.3456680-2-max.oss.09@gmail.com/ and some documentation / guide around that would help then?
> On Wed, Dec 07, 2022 at 02:27:37PM +0000, Holger Brunck wrote: > > > > - migrate all boards to environment.txt files > > > > - migrate PPC boards to DM_I2C > > > > - some cleanup > > > > > > > > Holger Brunck (7): > > > > board/km: move ls102xa boards to environment text files > > > > km/powerpc: migrate to env.txt file > > > > board/km/cent2: migrate to environment text file > > > > board/km/secu: migrate to use environment text files > > > > board/km: remove obsolete ARCH_KIRKWOOD > > > > km/ppc: migrate all mpc83xx to DM_I2C > > > > km/mpc8360: remove unused CONFIG_SYS_PAXE defines > > > > > > Thanks for doing this. As this is the first in my mind big > > > environment conversion, do you have any further feedback on the > > > mechanism, things that would make this easier / more useful, etc? > > > > > > > it was quite straight forward and especially for board series which > > use a hierarchical structure as we do it is easy to use and afterwards > > much easier to read and to maintain. > > > > I only struggled about the strings I had defined in Kconfig as > > discussed in another thread about double quoted strings. I removed them > from there in the end. > > > > What would maybe be helpful to have a small script which converts the > > generated include/generated/environment.h into a textfile which then > > looks like the environment in your u-boot if you dump it. Then you can > > quickly do a diff between a dump from your old and your textfile to > > see if your newly migrated environment is identical. > > Ah good. Perhaps > https://patchwork.ozlabs.org/project/uboot/patch/20221128084122.3456680 > -2-max.oss.09@gmail.com/ > and some documentation / guide around that would help then? > yes this would have been helpful for me. Best regards Holger