| Message ID | 20220304122228.71412-1-ariel.dalessandro@collabora.com |
|---|---|
| Headers | show |
| Series | imx8mn-smm-s2/pro: Add iMX8MN BSH SMM S2 boards | expand |
Hi Tom, Stefano, Gentle ping :-) Can we get this merged now? On 3/4/22 09:22, Ariel D'Alessandro wrote: > Introduce BSH SystemMaster (SMM) S2 board family, which consists of: > iMX8MN SMM S2 and iMX8MN SMM S2 PRO boards. > > This patchset also adds support for NXP TJA11xx Ethernet PHYs. > > Changes in v4: > * Add new Reviewed-by tags to patches. > * Set atf-bl31 blob type in device tree binman configuration. > > Changes in v3: > * Added nxp-c45-tja11xx driver. > * Added ethernet support to iMX8MN BSH SMM S2 boards. > > Changes in v2: > * Properly added MAINTAINERS entry. > * Fixed binman configuration. > * Picked device tree from kernel. > * Removed CONFIG_SPL_BUILD anti-pattern in board config. > * Removed downstream stuff in bootargs. > * Added board documentation. > > Ariel D'Alessandro (4): > phy: nxp-c45-tja11xx: Rename functions to be c45 tja11xx specific > iopoll: Extend read_poll_timeout macro to support variable parameters > net: phy: Add phy_modify() accessor > bsh: imx8mn-smm-s2/pro: Add iMX8MN BSH SMM S2 boards > > Michael Trimarchi (2): > imx8m: add regs used by GPMI > net: phy: nxp-tja11xx: Add NXP TJA11xx PHY driver > > arch/arm/dts/Makefile | 2 + > arch/arm/dts/imx8mn-bsh-smm-s2-common.dtsi | 423 ++++++++ > .../dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi | 225 +++++ > arch/arm/dts/imx8mn-bsh-smm-s2-u-boot.dtsi | 15 + > arch/arm/dts/imx8mn-bsh-smm-s2.dts | 48 + > arch/arm/dts/imx8mn-bsh-smm-s2pro-u-boot.dtsi | 15 + > arch/arm/dts/imx8mn-bsh-smm-s2pro.dts | 80 ++ > arch/arm/include/asm/arch-imx8m/imx-regs.h | 7 + > arch/arm/mach-imx/imx8m/Kconfig | 15 + > arch/arm/mach-socfpga/reset_manager_s10.c | 20 +- > board/bsh/imx8mn_smm_s2/Kconfig | 49 + > board/bsh/imx8mn_smm_s2/MAINTAINERS | 8 + > board/bsh/imx8mn_smm_s2/Makefile | 13 + > board/bsh/imx8mn_smm_s2/ddr3l_timing_256m.c | 941 ++++++++++++++++++ > board/bsh/imx8mn_smm_s2/ddr3l_timing_512m.c | 941 ++++++++++++++++++ > board/bsh/imx8mn_smm_s2/imx8mn_smm_s2.c | 23 + > board/bsh/imx8mn_smm_s2/imximage-8mn-ddr3.cfg | 10 + > board/bsh/imx8mn_smm_s2/spl.c | 93 ++ > configs/imx8mn_bsh_smm_s2_defconfig | 97 ++ > configs/imx8mn_bsh_smm_s2pro_defconfig | 94 ++ > doc/board/bsh/imx8mn_bsh_smm_s2.rst | 62 ++ > doc/board/bsh/index.rst | 9 + > doc/board/index.rst | 1 + > drivers/mmc/rockchip_sdhci.c | 9 +- > drivers/net/phy/Kconfig | 5 + > drivers/net/phy/Makefile | 1 + > drivers/net/phy/nxp-c45-tja11xx.c | 6 +- > drivers/net/phy/nxp-tja11xx.c | 277 ++++++ > drivers/net/phy/phy.c | 23 + > include/configs/imx8mn_bsh_smm_s2.h | 52 + > include/configs/imx8mn_bsh_smm_s2_common.h | 62 ++ > include/configs/imx8mn_bsh_smm_s2pro.h | 35 + > include/linux/iopoll.h | 12 +- > include/phy.h | 3 + > 34 files changed, 3654 insertions(+), 22 deletions(-) > create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2-common.dtsi > create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi > create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2-u-boot.dtsi > create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2.dts > create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2pro-u-boot.dtsi > create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2pro.dts > create mode 100644 board/bsh/imx8mn_smm_s2/Kconfig > create mode 100644 board/bsh/imx8mn_smm_s2/MAINTAINERS > create mode 100644 board/bsh/imx8mn_smm_s2/Makefile > create mode 100644 board/bsh/imx8mn_smm_s2/ddr3l_timing_256m.c > create mode 100644 board/bsh/imx8mn_smm_s2/ddr3l_timing_512m.c > create mode 100644 board/bsh/imx8mn_smm_s2/imx8mn_smm_s2.c > create mode 100644 board/bsh/imx8mn_smm_s2/imximage-8mn-ddr3.cfg > create mode 100644 board/bsh/imx8mn_smm_s2/spl.c > create mode 100644 configs/imx8mn_bsh_smm_s2_defconfig > create mode 100644 configs/imx8mn_bsh_smm_s2pro_defconfig > create mode 100644 doc/board/bsh/imx8mn_bsh_smm_s2.rst > create mode 100644 doc/board/bsh/index.rst > create mode 100644 drivers/net/phy/nxp-tja11xx.c > create mode 100644 include/configs/imx8mn_bsh_smm_s2.h > create mode 100644 include/configs/imx8mn_bsh_smm_s2_common.h > create mode 100644 include/configs/imx8mn_bsh_smm_s2pro.h >
Yes, there's a lot of iMX things I would like to see a PR come in for soon. On Tue, Apr 05, 2022 at 05:44:47PM -0300, Ariel D'Alessandro wrote: > Hi Tom, Stefano, > > Gentle ping :-) Can we get this merged now? > > On 3/4/22 09:22, Ariel D'Alessandro wrote: > > Introduce BSH SystemMaster (SMM) S2 board family, which consists of: > > iMX8MN SMM S2 and iMX8MN SMM S2 PRO boards. > > > > This patchset also adds support for NXP TJA11xx Ethernet PHYs. > > > > Changes in v4: > > * Add new Reviewed-by tags to patches. > > * Set atf-bl31 blob type in device tree binman configuration. > > > > Changes in v3: > > * Added nxp-c45-tja11xx driver. > > * Added ethernet support to iMX8MN BSH SMM S2 boards. > > > > Changes in v2: > > * Properly added MAINTAINERS entry. > > * Fixed binman configuration. > > * Picked device tree from kernel. > > * Removed CONFIG_SPL_BUILD anti-pattern in board config. > > * Removed downstream stuff in bootargs. > > * Added board documentation. > > > > Ariel D'Alessandro (4): > > phy: nxp-c45-tja11xx: Rename functions to be c45 tja11xx specific > > iopoll: Extend read_poll_timeout macro to support variable parameters > > net: phy: Add phy_modify() accessor > > bsh: imx8mn-smm-s2/pro: Add iMX8MN BSH SMM S2 boards > > > > Michael Trimarchi (2): > > imx8m: add regs used by GPMI > > net: phy: nxp-tja11xx: Add NXP TJA11xx PHY driver > > > > arch/arm/dts/Makefile | 2 + > > arch/arm/dts/imx8mn-bsh-smm-s2-common.dtsi | 423 ++++++++ > > .../dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi | 225 +++++ > > arch/arm/dts/imx8mn-bsh-smm-s2-u-boot.dtsi | 15 + > > arch/arm/dts/imx8mn-bsh-smm-s2.dts | 48 + > > arch/arm/dts/imx8mn-bsh-smm-s2pro-u-boot.dtsi | 15 + > > arch/arm/dts/imx8mn-bsh-smm-s2pro.dts | 80 ++ > > arch/arm/include/asm/arch-imx8m/imx-regs.h | 7 + > > arch/arm/mach-imx/imx8m/Kconfig | 15 + > > arch/arm/mach-socfpga/reset_manager_s10.c | 20 +- > > board/bsh/imx8mn_smm_s2/Kconfig | 49 + > > board/bsh/imx8mn_smm_s2/MAINTAINERS | 8 + > > board/bsh/imx8mn_smm_s2/Makefile | 13 + > > board/bsh/imx8mn_smm_s2/ddr3l_timing_256m.c | 941 ++++++++++++++++++ > > board/bsh/imx8mn_smm_s2/ddr3l_timing_512m.c | 941 ++++++++++++++++++ > > board/bsh/imx8mn_smm_s2/imx8mn_smm_s2.c | 23 + > > board/bsh/imx8mn_smm_s2/imximage-8mn-ddr3.cfg | 10 + > > board/bsh/imx8mn_smm_s2/spl.c | 93 ++ > > configs/imx8mn_bsh_smm_s2_defconfig | 97 ++ > > configs/imx8mn_bsh_smm_s2pro_defconfig | 94 ++ > > doc/board/bsh/imx8mn_bsh_smm_s2.rst | 62 ++ > > doc/board/bsh/index.rst | 9 + > > doc/board/index.rst | 1 + > > drivers/mmc/rockchip_sdhci.c | 9 +- > > drivers/net/phy/Kconfig | 5 + > > drivers/net/phy/Makefile | 1 + > > drivers/net/phy/nxp-c45-tja11xx.c | 6 +- > > drivers/net/phy/nxp-tja11xx.c | 277 ++++++ > > drivers/net/phy/phy.c | 23 + > > include/configs/imx8mn_bsh_smm_s2.h | 52 + > > include/configs/imx8mn_bsh_smm_s2_common.h | 62 ++ > > include/configs/imx8mn_bsh_smm_s2pro.h | 35 + > > include/linux/iopoll.h | 12 +- > > include/phy.h | 3 + > > 34 files changed, 3654 insertions(+), 22 deletions(-) > > create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2-common.dtsi > > create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi > > create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2-u-boot.dtsi > > create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2.dts > > create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2pro-u-boot.dtsi > > create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2pro.dts > > create mode 100644 board/bsh/imx8mn_smm_s2/Kconfig > > create mode 100644 board/bsh/imx8mn_smm_s2/MAINTAINERS > > create mode 100644 board/bsh/imx8mn_smm_s2/Makefile > > create mode 100644 board/bsh/imx8mn_smm_s2/ddr3l_timing_256m.c > > create mode 100644 board/bsh/imx8mn_smm_s2/ddr3l_timing_512m.c > > create mode 100644 board/bsh/imx8mn_smm_s2/imx8mn_smm_s2.c > > create mode 100644 board/bsh/imx8mn_smm_s2/imximage-8mn-ddr3.cfg > > create mode 100644 board/bsh/imx8mn_smm_s2/spl.c > > create mode 100644 configs/imx8mn_bsh_smm_s2_defconfig > > create mode 100644 configs/imx8mn_bsh_smm_s2pro_defconfig > > create mode 100644 doc/board/bsh/imx8mn_bsh_smm_s2.rst > > create mode 100644 doc/board/bsh/index.rst > > create mode 100644 drivers/net/phy/nxp-tja11xx.c > > create mode 100644 include/configs/imx8mn_bsh_smm_s2.h > > create mode 100644 include/configs/imx8mn_bsh_smm_s2_common.h > > create mode 100644 include/configs/imx8mn_bsh_smm_s2pro.h > >
Hi, Gentle re-ping. What's blocking this? This has been reviewed and queued for some time already. Please, be clear on the status or what's the plan for this patchset. Regards, Ariel On 4/5/22 19:46, Tom Rini wrote: > Yes, there's a lot of iMX things I would like to see a PR come in for > soon. > > On Tue, Apr 05, 2022 at 05:44:47PM -0300, Ariel D'Alessandro wrote: >> Hi Tom, Stefano, >> >> Gentle ping :-) Can we get this merged now? >> >> On 3/4/22 09:22, Ariel D'Alessandro wrote: >>> Introduce BSH SystemMaster (SMM) S2 board family, which consists of: >>> iMX8MN SMM S2 and iMX8MN SMM S2 PRO boards. >>> >>> This patchset also adds support for NXP TJA11xx Ethernet PHYs. >>> >>> Changes in v4: >>> * Add new Reviewed-by tags to patches. >>> * Set atf-bl31 blob type in device tree binman configuration. >>> >>> Changes in v3: >>> * Added nxp-c45-tja11xx driver. >>> * Added ethernet support to iMX8MN BSH SMM S2 boards. >>> >>> Changes in v2: >>> * Properly added MAINTAINERS entry. >>> * Fixed binman configuration. >>> * Picked device tree from kernel. >>> * Removed CONFIG_SPL_BUILD anti-pattern in board config. >>> * Removed downstream stuff in bootargs. >>> * Added board documentation. >>> >>> Ariel D'Alessandro (4): >>> phy: nxp-c45-tja11xx: Rename functions to be c45 tja11xx specific >>> iopoll: Extend read_poll_timeout macro to support variable parameters >>> net: phy: Add phy_modify() accessor >>> bsh: imx8mn-smm-s2/pro: Add iMX8MN BSH SMM S2 boards >>> >>> Michael Trimarchi (2): >>> imx8m: add regs used by GPMI >>> net: phy: nxp-tja11xx: Add NXP TJA11xx PHY driver >>> >>> arch/arm/dts/Makefile | 2 + >>> arch/arm/dts/imx8mn-bsh-smm-s2-common.dtsi | 423 ++++++++ >>> .../dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi | 225 +++++ >>> arch/arm/dts/imx8mn-bsh-smm-s2-u-boot.dtsi | 15 + >>> arch/arm/dts/imx8mn-bsh-smm-s2.dts | 48 + >>> arch/arm/dts/imx8mn-bsh-smm-s2pro-u-boot.dtsi | 15 + >>> arch/arm/dts/imx8mn-bsh-smm-s2pro.dts | 80 ++ >>> arch/arm/include/asm/arch-imx8m/imx-regs.h | 7 + >>> arch/arm/mach-imx/imx8m/Kconfig | 15 + >>> arch/arm/mach-socfpga/reset_manager_s10.c | 20 +- >>> board/bsh/imx8mn_smm_s2/Kconfig | 49 + >>> board/bsh/imx8mn_smm_s2/MAINTAINERS | 8 + >>> board/bsh/imx8mn_smm_s2/Makefile | 13 + >>> board/bsh/imx8mn_smm_s2/ddr3l_timing_256m.c | 941 ++++++++++++++++++ >>> board/bsh/imx8mn_smm_s2/ddr3l_timing_512m.c | 941 ++++++++++++++++++ >>> board/bsh/imx8mn_smm_s2/imx8mn_smm_s2.c | 23 + >>> board/bsh/imx8mn_smm_s2/imximage-8mn-ddr3.cfg | 10 + >>> board/bsh/imx8mn_smm_s2/spl.c | 93 ++ >>> configs/imx8mn_bsh_smm_s2_defconfig | 97 ++ >>> configs/imx8mn_bsh_smm_s2pro_defconfig | 94 ++ >>> doc/board/bsh/imx8mn_bsh_smm_s2.rst | 62 ++ >>> doc/board/bsh/index.rst | 9 + >>> doc/board/index.rst | 1 + >>> drivers/mmc/rockchip_sdhci.c | 9 +- >>> drivers/net/phy/Kconfig | 5 + >>> drivers/net/phy/Makefile | 1 + >>> drivers/net/phy/nxp-c45-tja11xx.c | 6 +- >>> drivers/net/phy/nxp-tja11xx.c | 277 ++++++ >>> drivers/net/phy/phy.c | 23 + >>> include/configs/imx8mn_bsh_smm_s2.h | 52 + >>> include/configs/imx8mn_bsh_smm_s2_common.h | 62 ++ >>> include/configs/imx8mn_bsh_smm_s2pro.h | 35 + >>> include/linux/iopoll.h | 12 +- >>> include/phy.h | 3 + >>> 34 files changed, 3654 insertions(+), 22 deletions(-) >>> create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2-common.dtsi >>> create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi >>> create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2-u-boot.dtsi >>> create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2.dts >>> create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2pro-u-boot.dtsi >>> create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2pro.dts >>> create mode 100644 board/bsh/imx8mn_smm_s2/Kconfig >>> create mode 100644 board/bsh/imx8mn_smm_s2/MAINTAINERS >>> create mode 100644 board/bsh/imx8mn_smm_s2/Makefile >>> create mode 100644 board/bsh/imx8mn_smm_s2/ddr3l_timing_256m.c >>> create mode 100644 board/bsh/imx8mn_smm_s2/ddr3l_timing_512m.c >>> create mode 100644 board/bsh/imx8mn_smm_s2/imx8mn_smm_s2.c >>> create mode 100644 board/bsh/imx8mn_smm_s2/imximage-8mn-ddr3.cfg >>> create mode 100644 board/bsh/imx8mn_smm_s2/spl.c >>> create mode 100644 configs/imx8mn_bsh_smm_s2_defconfig >>> create mode 100644 configs/imx8mn_bsh_smm_s2pro_defconfig >>> create mode 100644 doc/board/bsh/imx8mn_bsh_smm_s2.rst >>> create mode 100644 doc/board/bsh/index.rst >>> create mode 100644 drivers/net/phy/nxp-tja11xx.c >>> create mode 100644 include/configs/imx8mn_bsh_smm_s2.h >>> create mode 100644 include/configs/imx8mn_bsh_smm_s2_common.h >>> create mode 100644 include/configs/imx8mn_bsh_smm_s2pro.h >>> >
Hi Ariel, On 11.04.22 13:56, Ariel D'Alessandro wrote: > Hi, > > Gentle re-ping. What's blocking this? > This has been reviewed and queued for some time already. Please, be > clear on the status or what's the plan for this patchset. > After first run, build is blocked by CI due to CONFIG_ that should be se in configs/imx8mn_bsh_smm_s2_defconfig instead of include/configs/imx8mn_bsh_smm_s2_common.h. I can recognize at least CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR (and family), but it looks like there are some more. See error here: https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/420878 Regards, Stefano > Regards, > Ariel > > On 4/5/22 19:46, Tom Rini wrote: >> Yes, there's a lot of iMX things I would like to see a PR come in for >> soon. >> >> On Tue, Apr 05, 2022 at 05:44:47PM -0300, Ariel D'Alessandro wrote: >>> Hi Tom, Stefano, >>> >>> Gentle ping :-) Can we get this merged now? >>> >>> On 3/4/22 09:22, Ariel D'Alessandro wrote: >>>> Introduce BSH SystemMaster (SMM) S2 board family, which consists of: >>>> iMX8MN SMM S2 and iMX8MN SMM S2 PRO boards. >>>> >>>> This patchset also adds support for NXP TJA11xx Ethernet PHYs. >>>> >>>> Changes in v4: >>>> * Add new Reviewed-by tags to patches. >>>> * Set atf-bl31 blob type in device tree binman configuration. >>>> >>>> Changes in v3: >>>> * Added nxp-c45-tja11xx driver. >>>> * Added ethernet support to iMX8MN BSH SMM S2 boards. >>>> >>>> Changes in v2: >>>> * Properly added MAINTAINERS entry. >>>> * Fixed binman configuration. >>>> * Picked device tree from kernel. >>>> * Removed CONFIG_SPL_BUILD anti-pattern in board config. >>>> * Removed downstream stuff in bootargs. >>>> * Added board documentation. >>>> >>>> Ariel D'Alessandro (4): >>>> phy: nxp-c45-tja11xx: Rename functions to be c45 tja11xx specific >>>> iopoll: Extend read_poll_timeout macro to support variable parameters >>>> net: phy: Add phy_modify() accessor >>>> bsh: imx8mn-smm-s2/pro: Add iMX8MN BSH SMM S2 boards >>>> >>>> Michael Trimarchi (2): >>>> imx8m: add regs used by GPMI >>>> net: phy: nxp-tja11xx: Add NXP TJA11xx PHY driver >>>> >>>> arch/arm/dts/Makefile | 2 + >>>> arch/arm/dts/imx8mn-bsh-smm-s2-common.dtsi | 423 ++++++++ >>>> .../dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi | 225 +++++ >>>> arch/arm/dts/imx8mn-bsh-smm-s2-u-boot.dtsi | 15 + >>>> arch/arm/dts/imx8mn-bsh-smm-s2.dts | 48 + >>>> arch/arm/dts/imx8mn-bsh-smm-s2pro-u-boot.dtsi | 15 + >>>> arch/arm/dts/imx8mn-bsh-smm-s2pro.dts | 80 ++ >>>> arch/arm/include/asm/arch-imx8m/imx-regs.h | 7 + >>>> arch/arm/mach-imx/imx8m/Kconfig | 15 + >>>> arch/arm/mach-socfpga/reset_manager_s10.c | 20 +- >>>> board/bsh/imx8mn_smm_s2/Kconfig | 49 + >>>> board/bsh/imx8mn_smm_s2/MAINTAINERS | 8 + >>>> board/bsh/imx8mn_smm_s2/Makefile | 13 + >>>> board/bsh/imx8mn_smm_s2/ddr3l_timing_256m.c | 941 ++++++++++++++++++ >>>> board/bsh/imx8mn_smm_s2/ddr3l_timing_512m.c | 941 ++++++++++++++++++ >>>> board/bsh/imx8mn_smm_s2/imx8mn_smm_s2.c | 23 + >>>> board/bsh/imx8mn_smm_s2/imximage-8mn-ddr3.cfg | 10 + >>>> board/bsh/imx8mn_smm_s2/spl.c | 93 ++ >>>> configs/imx8mn_bsh_smm_s2_defconfig | 97 ++ >>>> configs/imx8mn_bsh_smm_s2pro_defconfig | 94 ++ >>>> doc/board/bsh/imx8mn_bsh_smm_s2.rst | 62 ++ >>>> doc/board/bsh/index.rst | 9 + >>>> doc/board/index.rst | 1 + >>>> drivers/mmc/rockchip_sdhci.c | 9 +- >>>> drivers/net/phy/Kconfig | 5 + >>>> drivers/net/phy/Makefile | 1 + >>>> drivers/net/phy/nxp-c45-tja11xx.c | 6 +- >>>> drivers/net/phy/nxp-tja11xx.c | 277 ++++++ >>>> drivers/net/phy/phy.c | 23 + >>>> include/configs/imx8mn_bsh_smm_s2.h | 52 + >>>> include/configs/imx8mn_bsh_smm_s2_common.h | 62 ++ >>>> include/configs/imx8mn_bsh_smm_s2pro.h | 35 + >>>> include/linux/iopoll.h | 12 +- >>>> include/phy.h | 3 + >>>> 34 files changed, 3654 insertions(+), 22 deletions(-) >>>> create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2-common.dtsi >>>> create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi >>>> create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2-u-boot.dtsi >>>> create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2.dts >>>> create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2pro-u-boot.dtsi >>>> create mode 100644 arch/arm/dts/imx8mn-bsh-smm-s2pro.dts >>>> create mode 100644 board/bsh/imx8mn_smm_s2/Kconfig >>>> create mode 100644 board/bsh/imx8mn_smm_s2/MAINTAINERS >>>> create mode 100644 board/bsh/imx8mn_smm_s2/Makefile >>>> create mode 100644 board/bsh/imx8mn_smm_s2/ddr3l_timing_256m.c >>>> create mode 100644 board/bsh/imx8mn_smm_s2/ddr3l_timing_512m.c >>>> create mode 100644 board/bsh/imx8mn_smm_s2/imx8mn_smm_s2.c >>>> create mode 100644 board/bsh/imx8mn_smm_s2/imximage-8mn-ddr3.cfg >>>> create mode 100644 board/bsh/imx8mn_smm_s2/spl.c >>>> create mode 100644 configs/imx8mn_bsh_smm_s2_defconfig >>>> create mode 100644 configs/imx8mn_bsh_smm_s2pro_defconfig >>>> create mode 100644 doc/board/bsh/imx8mn_bsh_smm_s2.rst >>>> create mode 100644 doc/board/bsh/index.rst >>>> create mode 100644 drivers/net/phy/nxp-tja11xx.c >>>> create mode 100644 include/configs/imx8mn_bsh_smm_s2.h >>>> create mode 100644 include/configs/imx8mn_bsh_smm_s2_common.h >>>> create mode 100644 include/configs/imx8mn_bsh_smm_s2pro.h >>>> >>
On Mon, Apr 11, 2022 at 05:56:52PM +0200, Stefano Babic wrote: > Hi Ariel, > > On 11.04.22 13:56, Ariel D'Alessandro wrote: > > Hi, > > > > Gentle re-ping. What's blocking this? > > This has been reviewed and queued for some time already. Please, be > > clear on the status or what's the plan for this patchset. > > > > After first run, build is blocked by CI due to CONFIG_ that should be se in > configs/imx8mn_bsh_smm_s2_defconfig instead of > include/configs/imx8mn_bsh_smm_s2_common.h. I can recognize at least > CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR (and family), but it looks like > there are some more. > > See error here: > > https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/420878 Since this is going to pop up a bit I suspect, https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/420878#L24 shows the shell command to run that gives "Unmigrated symbols found in include/configs/imx8mn_bsh_smm_s2_common.h". And if instead of: NUM=`comm -123 --total --output-delimiter=, ${KSYMLST} ${KUSEDLST} | cut -d , -f 3`; if [[ $NUM -ne 0 ]]; then echo "Unmigrated symbols found in $CFG"; exit 1; fi You do: comm -12 ${KSYMLST} ${KUSEDLST} You'll see the whole list of unmigrated symbols. Many of which are easy to migrate and it's just a matter of ./tools/moveconfig.py -y FOO and then sanity checking the output. And a currently failing patchset is also maybe motivation to expand the CI check to note them too? As I can certainly see how it would be good to have the what failed more visible.
On 11.04.22 18:03, Tom Rini wrote: > On Mon, Apr 11, 2022 at 05:56:52PM +0200, Stefano Babic wrote: >> Hi Ariel, >> >> On 11.04.22 13:56, Ariel D'Alessandro wrote: >>> Hi, >>> >>> Gentle re-ping. What's blocking this? >>> This has been reviewed and queued for some time already. Please, be >>> clear on the status or what's the plan for this patchset. >>> >> >> After first run, build is blocked by CI due to CONFIG_ that should be se in >> configs/imx8mn_bsh_smm_s2_defconfig instead of >> include/configs/imx8mn_bsh_smm_s2_common.h. I can recognize at least >> CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR (and family), but it looks like >> there are some more. >> >> See error here: >> >> https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/420878 > > Since this is going to pop up a bit I suspect, > https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/420878#L24 > shows the shell command to run that gives "Unmigrated symbols found in > include/configs/imx8mn_bsh_smm_s2_common.h". And if instead of: > NUM=`comm -123 --total --output-delimiter=, ${KSYMLST} ${KUSEDLST} | cut > -d , -f 3`; if [[ $NUM -ne 0 ]]; then echo "Unmigrated symbols found in > $CFG"; exit 1; fi > > You do: > comm -12 ${KSYMLST} ${KUSEDLST} It is much better because CI does not report which CONFIG_ were found. > > You'll see the whole list of unmigrated symbols. Many of which are easy > to migrate and it's just a matter of ./tools/moveconfig.py -y FOO and > then sanity checking the output. > > And a currently failing patchset is also maybe motivation to expand the > CI check to note them too? As I can certainly see how it would be good > to have the what failed more visible. Sure, at least to get the whole list of CONFIG_ that clash. Regards, Stefano >
On Mon, Apr 11, 2022 at 06:27:06PM +0200, Stefano Babic wrote: > On 11.04.22 18:03, Tom Rini wrote: > > On Mon, Apr 11, 2022 at 05:56:52PM +0200, Stefano Babic wrote: > > > Hi Ariel, > > > > > > On 11.04.22 13:56, Ariel D'Alessandro wrote: > > > > Hi, > > > > > > > > Gentle re-ping. What's blocking this? > > > > This has been reviewed and queued for some time already. Please, be > > > > clear on the status or what's the plan for this patchset. > > > > > > > > > > After first run, build is blocked by CI due to CONFIG_ that should be se in > > > configs/imx8mn_bsh_smm_s2_defconfig instead of > > > include/configs/imx8mn_bsh_smm_s2_common.h. I can recognize at least > > > CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR (and family), but it looks like > > > there are some more. > > > > > > See error here: > > > > > > https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/420878 > > > > Since this is going to pop up a bit I suspect, > > https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/420878#L24 > > shows the shell command to run that gives "Unmigrated symbols found in > > include/configs/imx8mn_bsh_smm_s2_common.h". And if instead of: > > NUM=`comm -123 --total --output-delimiter=, ${KSYMLST} ${KUSEDLST} | cut > > -d , -f 3`; if [[ $NUM -ne 0 ]]; then echo "Unmigrated symbols found in > > $CFG"; exit 1; fi > > > > You do: > > comm -12 ${KSYMLST} ${KUSEDLST} > > It is much better because CI does not report which CONFIG_ were found. > > > > > You'll see the whole list of unmigrated symbols. Many of which are easy > > to migrate and it's just a matter of ./tools/moveconfig.py -y FOO and > > then sanity checking the output. > > > > And a currently failing patchset is also maybe motivation to expand the > > CI check to note them too? As I can certainly see how it would be good > > to have the what failed more visible. > > Sure, at least to get the whole list of CONFIG_ that clash. OK, I've got an updated test that gives more information: https://source.denx.de/u-boot/u-boot/-/jobs/421202
Hi Stefano, On 4/11/22 12:56, Stefano Babic wrote: > Hi Ariel, > > On 11.04.22 13:56, Ariel D'Alessandro wrote: >> Hi, >> >> Gentle re-ping. What's blocking this? >> This has been reviewed and queued for some time already. Please, be >> clear on the status or what's the plan for this patchset. >> > > After first run, build is blocked by CI due to CONFIG_ that should be se > in configs/imx8mn_bsh_smm_s2_defconfig instead of > include/configs/imx8mn_bsh_smm_s2_common.h. I can recognize at least > CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR (and family), but it looks like > there are some more. > > See error here: > > https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/420878 Thanks! Fixed, will send patchset v5 right away. Regards, Ariel
On 12.04.22 13:50, Ariel D'Alessandro wrote: > Hi Stefano, > > On 4/11/22 12:56, Stefano Babic wrote: >> Hi Ariel, >> >> On 11.04.22 13:56, Ariel D'Alessandro wrote: >>> Hi, >>> >>> Gentle re-ping. What's blocking this? >>> This has been reviewed and queued for some time already. Please, be >>> clear on the status or what's the plan for this patchset. >>> >> >> After first run, build is blocked by CI due to CONFIG_ that should be se >> in configs/imx8mn_bsh_smm_s2_defconfig instead of >> include/configs/imx8mn_bsh_smm_s2_common.h. I can recognize at least >> CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR (and family), but it looks like >> there are some more. >> >> See error here: >> >> https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/420878 > > Thanks! Fixed, will send patchset v5 right away. > Ok, thanks - I will then apply V5 and let CI run again. Regards, Stefano