mbox series

[v2,0/6] drivers: tpm: Fix Atmel/Microchip TPMv1.2 issues

Message ID 20211111040631.21262-1-matt@traverse.com.au
Headers show
Series drivers: tpm: Fix Atmel/Microchip TPMv1.2 issues | expand

Message

Mathew McBride Nov. 11, 2021, 4:06 a.m. UTC 
While doing bringup/rebase for the Ten64 I did some troubleshooting
for the tpm (v1.2, NOT tpm2) command which did not appear to function,
despite the Linux driver and tools (tcsd) working on the same board.

Evidently the Atmel TPM driver hasn't kept up with various step
changes in the I2C and TPM stacks, and while TPMv1.2 is quite
dated to TPMv2 it would be nice to make some use of the hardware
that is there.
(Admittedly I would love to replace our hardware TPM with an fTPM
but that is a project for another day)

There are also subcommands in tpm-v1 which also have been
missed in changes to the TPMv1 API and are fixed in this patchset.

Changes in v2:
- Include model number in get_desc output
  Example: "Atmel AT97SC3204T I2C 1.2 TPM (tpm@29)"

Mathew McBride (6):
  cmd: tpm-v1: fix compile error in TPMv1 list resources command
  cmd: tpm-v1: fix load_key_by_sha1 compile errors
  drivers: tpm: atmel_twi: drop non-DM_I2C compatibility
  drivers: tpm: atmel_twi: do not use an offset byte
  drivers: tpm: atmel_twi: implement get_desc operation
  drivers: tpm: atmel_twi: fix printf specifier compile warning

 cmd/tpm-v1.c                | 17 +++++++++++------
 drivers/tpm/tpm_atmel_twi.c | 22 +++++++---------------
 lib/tpm-v1.c                |  4 ++--
 3 files changed, 20 insertions(+), 23 deletions(-)

Comments

Ilias Apalodimas Nov. 17, 2021, 1:57 p.m. UTC | #1 
Hi Mathew,

I've picked this up on the -tpm tree

Thanks
/Ilias

On Thu, 11 Nov 2021 at 06:06, Mathew McBride <matt@traverse.com.au> wrote:
>
> While doing bringup/rebase for the Ten64 I did some troubleshooting
> for the tpm (v1.2, NOT tpm2) command which did not appear to function,
> despite the Linux driver and tools (tcsd) working on the same board.
>
> Evidently the Atmel TPM driver hasn't kept up with various step
> changes in the I2C and TPM stacks, and while TPMv1.2 is quite
> dated to TPMv2 it would be nice to make some use of the hardware
> that is there.
> (Admittedly I would love to replace our hardware TPM with an fTPM
> but that is a project for another day)
>
> There are also subcommands in tpm-v1 which also have been
> missed in changes to the TPMv1 API and are fixed in this patchset.
>
> Changes in v2:
> - Include model number in get_desc output
>   Example: "Atmel AT97SC3204T I2C 1.2 TPM (tpm@29)"
>
> Mathew McBride (6):
>   cmd: tpm-v1: fix compile error in TPMv1 list resources command
>   cmd: tpm-v1: fix load_key_by_sha1 compile errors
>   drivers: tpm: atmel_twi: drop non-DM_I2C compatibility
>   drivers: tpm: atmel_twi: do not use an offset byte
>   drivers: tpm: atmel_twi: implement get_desc operation
>   drivers: tpm: atmel_twi: fix printf specifier compile warning
>
>  cmd/tpm-v1.c                | 17 +++++++++++------
>  drivers/tpm/tpm_atmel_twi.c | 22 +++++++---------------
>  lib/tpm-v1.c                |  4 ++--
>  3 files changed, 20 insertions(+), 23 deletions(-)
>
> --
> 2.30.1
>