mbox series

[0/6] Use -ENOSYS consistently

Message ID 20210321031824.2170848-1-sjg@chromium.org
Headers show
Series Use -ENOSYS consistently | expand

Message

Simon Glass March 21, 2021, 3:18 a.m. UTC
A few places use -ENOTSUPP when they should use -ENOSYS. In two cases both
are used. This little series tidies this up.


Simon Glass (6):
  usb: Return -ENOSYS when system call is not available
  spi: Return -ENOSYS when system call is not available
  tlv_eeprom: Return -ENOSYS when system call is not available
  clk: Return -ENOSYS when system call is not available
  simple-pm-bus: Use -ENOSYS for checking missing system call
  pinctrl: Return -ENOSYS when system call is not available

 drivers/clk/clk-composite.c         |  8 ++++----
 drivers/core/simple-pm-bus.c        |  4 ++--
 drivers/pinctrl/pinctrl-uclass.c    | 10 ++++++----
 drivers/usb/gadget/udc/udc-uclass.c |  2 +-
 include/spi-mem.h                   |  2 +-
 include/tlv_eeprom.h                |  6 +++---
 6 files changed, 17 insertions(+), 15 deletions(-)

Comments

Tom Rini March 21, 2021, 4:38 p.m. UTC | #1
On Sun, Mar 21, 2021 at 04:18:18PM +1300, Simon Glass wrote:

> A few places use -ENOTSUPP when they should use -ENOSYS. In two cases both
> are used. This little series tidies this up.
> 
> 
> Simon Glass (6):
>   usb: Return -ENOSYS when system call is not available
>   spi: Return -ENOSYS when system call is not available
>   tlv_eeprom: Return -ENOSYS when system call is not available
>   clk: Return -ENOSYS when system call is not available
>   simple-pm-bus: Use -ENOSYS for checking missing system call
>   pinctrl: Return -ENOSYS when system call is not available
> 
>  drivers/clk/clk-composite.c         |  8 ++++----
>  drivers/core/simple-pm-bus.c        |  4 ++--
>  drivers/pinctrl/pinctrl-uclass.c    | 10 ++++++----
>  drivers/usb/gadget/udc/udc-uclass.c |  2 +-
>  include/spi-mem.h                   |  2 +-
>  include/tlv_eeprom.h                |  6 +++---
>  6 files changed, 17 insertions(+), 15 deletions(-)

I think we need to start this series with a doc update that makes it
clear why this is correct and when it should be used.   There's two
instances of "ENOSYS" in doc/driver-model/ today and neither explains
why this series is correct (which I'm sure it is).  Thanks.