mbox series

[u-boot-marvell,v2,00/18] Upgrade A38x DDR3 training to version 14.0.0

Message ID 20210219161126.3523-1-marek.behun@nic.cz
Headers show
Series Upgrade A38x DDR3 training to version 14.0.0 | expand

Message

Marek Behún Feb. 19, 2021, 4:11 p.m. UTC
Hi Stefan,

this is v2 of series that syncs drivers/ddr/marvell/a38x/ with the
mv-ddr-devel branch of
https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell.git.

I have tested how the SPL image increases for all a38x boards.
Here are sizes of spl/u-boot-spl.bin before applying this series
(in bytes, hexadecimal), by how much these files are increased
after applying this series (in bytes, decimal).

                   before    inc
                   ------    ---
        clearfog   0x1f9c9    28
 controlcenterdc   0x2263c   108
  db-88f6820-amc   0x241d0   108  SPL too big (before and after)
   db-88f6820-gp   0x23c14   108
         helios4   0x1f68d    28
    turris_omnia   0x1c932    36
            x530   0x249ed   108  SPL too big (before and after)

As can be seen, these patches do not increase the size of SPL
much, and the only boards where SPL is too big after the series
have the same problem even before applying this series.

For these boards I recommend increasing in include/configs/*.h
  CONFIG_SPL_SIZE from (140 << 10) to (160 << 10)
and in configs/*_defconfig
  CONFIG_SYS_SPI_U_BOOT_OFFS from 0x24000 to 0x29000

Changes from v1:
- original author names are now in the From headers
- added Chris' Tested-by

Marek

Alex Leibovich (2):
  ddr: marvell: a38x: add ddr32 support
  ddr: marvell: a38x: add ddr 32bit ECC support

Baruch Siach (1):
  ddr: marvell: a38x: allow board specific ODT configuration

Marek Behún (7):
  ddr: marvell: a38x: import header change from upstream
  ddr: marvell: a38x: import header change from upstream
  ddr: marvell: a38x: import header change from upstream
  ddr: marvell: a38x: import header change from upstream
  ddr: marvell: a38x: import code change from upstream
  ddr: marvell: a38x: bump version to 14.0.0
  ddr: marvell: a38x: fix comment in conditional macro

Moti Buskila (7):
  ddr: marvell: a38x: fix write leveling suplementary algo
  ddr: marvell: a38x: fix 32bit
  ddr: marvell: a38x: fix memory size calculation using 32bit bus width
  ddr: marvell: a38x: add 16Gbit memory devices support
  ddr: marvell: a38x: add support for twin-die combined memory device
  ddr: marvell: a38x: disable WL phase correction stage in case of
    bus_width=16bit
  ddr: marvell: a38x: fix memory cs size function

heaterC (1):
  ddr: marvell: a38x: enum mv_ddr_twin_die: change order

 board/CZ.NIC/turris_omnia/turris_omnia.c      |  2 ++
 board/Marvell/db-88f6820-amc/db-88f6820-amc.c |  1 +
 board/Marvell/db-88f6820-gp/db-88f6820-gp.c   |  1 +
 board/alliedtelesis/x530/x530.c               |  1 +
 board/gdsys/a38x/controlcenterdc.c            |  1 +
 board/kobol/helios4/helios4.c                 |  1 +
 board/solidrun/clearfog/clearfog.c            |  1 +
 drivers/ddr/marvell/a38x/ddr3_init.c          |  5 ++++
 drivers/ddr/marvell/a38x/ddr3_training.c      |  5 +++-
 drivers/ddr/marvell/a38x/ddr3_training_db.c   |  3 +++
 .../ddr/marvell/a38x/ddr3_training_ip_def.h   |  2 ++
 .../marvell/a38x/ddr3_training_ip_engine.c    |  5 +++-
 drivers/ddr/marvell/a38x/ddr_topology_def.h   | 23 ++++++++++++++++++-
 .../ddr/marvell/a38x/mv_ddr_build_message.c   |  2 +-
 drivers/ddr/marvell/a38x/mv_ddr_plat.c        |  9 ++++++--
 drivers/ddr/marvell/a38x/mv_ddr_topology.c    | 14 ++++++++---
 drivers/ddr/marvell/a38x/mv_ddr_topology.h    |  2 ++
 drivers/ddr/marvell/a38x/xor.c                |  6 ++---
 18 files changed, 72 insertions(+), 12 deletions(-)

Comments

Stefan Roese Feb. 26, 2021, 11:13 a.m. UTC | #1
On 19.02.21 17:11, Marek Behún wrote:
> Hi Stefan,
> 
> this is v2 of series that syncs drivers/ddr/marvell/a38x/ with the
> mv-ddr-devel branch of
> https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell.git.
> 
> I have tested how the SPL image increases for all a38x boards.
> Here are sizes of spl/u-boot-spl.bin before applying this series
> (in bytes, hexadecimal), by how much these files are increased
> after applying this series (in bytes, decimal).
> 
>                     before    inc
>                     ------    ---
>          clearfog   0x1f9c9    28
>   controlcenterdc   0x2263c   108
>    db-88f6820-amc   0x241d0   108  SPL too big (before and after)
>     db-88f6820-gp   0x23c14   108
>           helios4   0x1f68d    28
>      turris_omnia   0x1c932    36
>              x530   0x249ed   108  SPL too big (before and after)
> 
> As can be seen, these patches do not increase the size of SPL
> much, and the only boards where SPL is too big after the series
> have the same problem even before applying this series.
> 
> For these boards I recommend increasing in include/configs/*.h
>    CONFIG_SPL_SIZE from (140 << 10) to (160 << 10)
> and in configs/*_defconfig
>    CONFIG_SYS_SPI_U_BOOT_OFFS from 0x24000 to 0x29000
> 
> Changes from v1:
> - original author names are now in the From headers
> - added Chris' Tested-by
> 
> Marek
> 
> Alex Leibovich (2):
>    ddr: marvell: a38x: add ddr32 support
>    ddr: marvell: a38x: add ddr 32bit ECC support
> 
> Baruch Siach (1):
>    ddr: marvell: a38x: allow board specific ODT configuration
> 
> Marek Behún (7):
>    ddr: marvell: a38x: import header change from upstream
>    ddr: marvell: a38x: import header change from upstream
>    ddr: marvell: a38x: import header change from upstream
>    ddr: marvell: a38x: import header change from upstream
>    ddr: marvell: a38x: import code change from upstream
>    ddr: marvell: a38x: bump version to 14.0.0
>    ddr: marvell: a38x: fix comment in conditional macro
> 
> Moti Buskila (7):
>    ddr: marvell: a38x: fix write leveling suplementary algo
>    ddr: marvell: a38x: fix 32bit
>    ddr: marvell: a38x: fix memory size calculation using 32bit bus width
>    ddr: marvell: a38x: add 16Gbit memory devices support
>    ddr: marvell: a38x: add support for twin-die combined memory device
>    ddr: marvell: a38x: disable WL phase correction stage in case of
>      bus_width=16bit
>    ddr: marvell: a38x: fix memory cs size function
> 
> heaterC (1):
>    ddr: marvell: a38x: enum mv_ddr_twin_die: change order
> 
>   board/CZ.NIC/turris_omnia/turris_omnia.c      |  2 ++
>   board/Marvell/db-88f6820-amc/db-88f6820-amc.c |  1 +
>   board/Marvell/db-88f6820-gp/db-88f6820-gp.c   |  1 +
>   board/alliedtelesis/x530/x530.c               |  1 +
>   board/gdsys/a38x/controlcenterdc.c            |  1 +
>   board/kobol/helios4/helios4.c                 |  1 +
>   board/solidrun/clearfog/clearfog.c            |  1 +
>   drivers/ddr/marvell/a38x/ddr3_init.c          |  5 ++++
>   drivers/ddr/marvell/a38x/ddr3_training.c      |  5 +++-
>   drivers/ddr/marvell/a38x/ddr3_training_db.c   |  3 +++
>   .../ddr/marvell/a38x/ddr3_training_ip_def.h   |  2 ++
>   .../marvell/a38x/ddr3_training_ip_engine.c    |  5 +++-
>   drivers/ddr/marvell/a38x/ddr_topology_def.h   | 23 ++++++++++++++++++-
>   .../ddr/marvell/a38x/mv_ddr_build_message.c   |  2 +-
>   drivers/ddr/marvell/a38x/mv_ddr_plat.c        |  9 ++++++--
>   drivers/ddr/marvell/a38x/mv_ddr_topology.c    | 14 ++++++++---
>   drivers/ddr/marvell/a38x/mv_ddr_topology.h    |  2 ++
>   drivers/ddr/marvell/a38x/xor.c                |  6 ++---
>   18 files changed, 72 insertions(+), 12 deletions(-)
> 

Applied to u-boot-marvell/master

Only this series for now. If we need some follow-up patches, please
let me know after this is merged in master.

Thanks,
Stefan
Marek Behún Feb. 26, 2021, 11:21 a.m. UTC | #2
On Fri, 26 Feb 2021 12:13:14 +0100
Stefan Roese <sr@denx.de> wrote:

> Applied to u-boot-marvell/master
> 
> Only this series for now. If we need some follow-up patches, please
> let me know after this is merged in master.

Very well.