mbox series

[U-Boot,0/5] Enable usage of SDP for i.MX6 Sabre Auto Boards

Message ID 20190603190029.10373-1-sjoerd.simons@collabora.co.uk
Headers show
Series Enable usage of SDP for i.MX6 Sabre Auto Boards | expand

Message

Sjoerd Simons June 3, 2019, 7 p.m. UTC
Being able to upload u-boot over USB is rather useful, so ideally this
functionality should be enabled by the default config for these boards.
Currently however no USB support is built into the SPL nor is SDP
enabled for i.MX6 Sabre Auto boards.

The first two patches in this series adjust the defconfig in a similar
way as Fabio has done in a recent patchset for Sabre SD. The first one
drops SPL DM support as there is no way to fit that *and* USB support in
at the moment, the second one adds missing pinctrl configuration for the
main u-boot binary.

The third patch enabled USB & SPL SDP support.

Patch four adds support for loading FIT images over SDP as that is what
is in use for the Sabre auto's main u-boot image. This is simply the
patch Frieder Schrempf submitted to the mainlinglist earlier, but made
to build on current git master. (Frieder could you be so kind to add
your SoB?).

The final patch fixes the u-boot image failing to start due to DM_VIDEO.

Patchset tested by using uuu with the following configuration:
```
uuu_version 1.2
SDP: boot -f  SPL
SDPU: write -f u-boot-dtb.img -addr 0x10000000
SDPU: jump -addr 0x10000000
SPDU: done
```

I suspect these patches are to late for 2019.07, especially since FIT
support in SDP would be a new feature? If so I'm happy to split this set
out of patches that should definatly land for 2019.07 (Making sabre auto
work) and submit the others for 2019.10


Frieder Schrempf (1):
  usb: gadget: f_sdp: Allow SPL to load and boot FIT via SDP

Sjoerd Simons (4):
  mx6sabreauto: Remove CONFIG_SPL_DM to decrease the SPL size
  mx6sabreauto: Select pinctrl driver
  mx6sabreauto: Enable SPL SDP support
  mx6sabreauto: set SYS_MALLOC_F for video

 common/spl/spl_sdp.c           | 11 +++++++--
 configs/mx6sabreauto_defconfig |  8 +++++--
 drivers/usb/gadget/f_sdp.c     | 41 +++++++++++++++++++++++++++++-----
 include/sdp.h                  |  4 +++-
 4 files changed, 53 insertions(+), 11 deletions(-)

Comments

Lukasz Majewski June 3, 2019, 9:15 p.m. UTC | #1
Hi Sjoerd,

> Being able to upload u-boot over USB is rather useful, so ideally this
> functionality should be enabled by the default config for these
> boards. Currently however no USB support is built into the SPL nor is
> SDP enabled for i.MX6 Sabre Auto boards.
> 
> The first two patches in this series adjust the defconfig in a similar
> way as Fabio has done in a recent patchset for Sabre SD. The first one
> drops SPL DM support as there is no way to fit that *and* USB support
> in at the moment, the second one adds missing pinctrl configuration
> for the main u-boot binary.
> 
> The third patch enabled USB & SPL SDP support.
> 
> Patch four adds support for loading FIT images over SDP as that is
> what is in use for the Sabre auto's main u-boot image. This is simply
> the patch Frieder Schrempf submitted to the mainlinglist earlier, but
> made to build on current git master. (Frieder could you be so kind to
> add your SoB?).
> 
> The final patch fixes the u-boot image failing to start due to
> DM_VIDEO.
> 
> Patchset tested by using uuu with the following configuration:
> ```
> uuu_version 1.2
> SDP: boot -f  SPL
> SDPU: write -f u-boot-dtb.img -addr 0x10000000
> SDPU: jump -addr 0x10000000
> SPDU: done
> ```
> 
> I suspect these patches are to late for 2019.07, especially since FIT
> support in SDP would be a new feature? If so I'm happy to split this
> set out of patches that should definatly land for 2019.07 (Making
> sabre auto work) and submit the others for 2019.10

I think that Fabio and Stefano would have a final opinion, but IMHO,
it would be best if you would split those patches.

> 
> 
> Frieder Schrempf (1):
>   usb: gadget: f_sdp: Allow SPL to load and boot FIT via SDP
> 
> Sjoerd Simons (4):
>   mx6sabreauto: Remove CONFIG_SPL_DM to decrease the SPL size
>   mx6sabreauto: Select pinctrl driver
>   mx6sabreauto: Enable SPL SDP support
>   mx6sabreauto: set SYS_MALLOC_F for video
> 
>  common/spl/spl_sdp.c           | 11 +++++++--
>  configs/mx6sabreauto_defconfig |  8 +++++--
>  drivers/usb/gadget/f_sdp.c     | 41
> +++++++++++++++++++++++++++++----- include/sdp.h                  |
> 4 +++- 4 files changed, 53 insertions(+), 11 deletions(-)
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de