mbox series

[U-Boot,0/4] fix propagation of flags from do_env_default()

Message ID 20180624161657.32632-1-yaniv.levinsky@compulab.co.il
Headers show
Series fix propagation of flags from do_env_default() | expand

Message

Yaniv Levinsky June 24, 2018, 4:16 p.m. UTC 
The function do_env_default() doesn't propagate flags to himport_r(). It causes
the "-f" option to have no effect on the execution of "env default" commands.

Fix the call paths from do_env_default() to himport_r() to pass flags correctly.

Yaniv Levinsky (4):
  cmd: nvedit: rename flags in do_env_default
  cmd: nvedit: propagate envflag to set_default_vars
  cmd: nvedit: set H_INTERACTIVE in do_env_default
  env: common: accept flags on reset to default env

 arch/arm/mach-imx/mx6/opos6ul.c |  2 +-
 cmd/nvedit.c                    | 11 ++++++-----
 common/board_r.c                |  2 +-
 common/spl/spl_dfu.c            |  2 +-
 env/common.c                    | 27 ++++++++++++---------------
 env/ext4.c                      |  2 +-
 env/fat.c                       |  2 +-
 env/mmc.c                       | 12 ++++++------
 env/nand.c                      |  6 +++---
 env/sata.c                      |  2 +-
 env/sf.c                        | 10 +++++-----
 env/ubi.c                       |  6 +++---
 include/environment.h           |  4 ++--
 13 files changed, 43 insertions(+), 45 deletions(-)

Comments

Yaniv Levinsky July 11, 2018, 3:21 p.m. UTC | #1 
Gentle ping.

On 06/24/2018 07:16 PM, Yaniv Levinsky wrote:
> The function do_env_default() doesn't propagate flags to himport_r(). It causes
> the "-f" option to have no effect on the execution of "env default" commands.
> 
> Fix the call paths from do_env_default() to himport_r() to pass flags correctly.
> 
> Yaniv Levinsky (4):
>   cmd: nvedit: rename flags in do_env_default
>   cmd: nvedit: propagate envflag to set_default_vars
>   cmd: nvedit: set H_INTERACTIVE in do_env_default
>   env: common: accept flags on reset to default env
> 
>  arch/arm/mach-imx/mx6/opos6ul.c |  2 +-
>  cmd/nvedit.c                    | 11 ++++++-----
>  common/board_r.c                |  2 +-
>  common/spl/spl_dfu.c            |  2 +-
>  env/common.c                    | 27 ++++++++++++---------------
>  env/ext4.c                      |  2 +-
>  env/fat.c                       |  2 +-
>  env/mmc.c                       | 12 ++++++------
>  env/nand.c                      |  6 +++---
>  env/sata.c                      |  2 +-
>  env/sf.c                        | 10 +++++-----
>  env/ubi.c                       |  6 +++---
>  include/environment.h           |  4 ++--
>  13 files changed, 43 insertions(+), 45 deletions(-)
>