mbox series

[U-Boot,v2,0/4] mmc: omap_hsmmc: Reduce the footprint of the driver and fix am335x clock

Message ID 1519378819-19867-1-git-send-email-jjhiblot@ti.com
Headers show
Series mmc: omap_hsmmc: Reduce the footprint of the driver and fix am335x clock | expand

Message

Jean-Jacques Hiblot Feb. 23, 2018, 9:40 a.m. UTC
This series aims at reducing the footprint of the omap_hsmmc driver in
the SPL (1.5 kB gain in the case of the SPL for the am335x evm).
It also fixes an issue with the am335x_evm by setting a default maximum
frequency if none is defined in the dts.

tested on am335x_evm, bbb, bbb (vboot), and dra7 evm

Changes in v2:
- Use a Kconfig option to compile out the ADMA support instead of relying
  on the platform architecture

Jean-Jacques Hiblot (4):
  mmc: omap_hsmmc: do not embed struct mmc in struct omap_hsmmc_plat
  mmc: omap_hsmmc: compile out write support if not needed
  mmc: omap_hsmmc: make it possible to compile out ADMA support
  mmc: omap_hsmmc: use a default 52MHz max clock rate if none is
    specified

 arch/arm/include/asm/omap_mmc.h |  2 +-
 drivers/mmc/Kconfig             |  9 +++++++++
 drivers/mmc/omap_hsmmc.c        | 31 ++++++++++++++++++++-----------
 3 files changed, 30 insertions(+), 12 deletions(-)

Comments

Adam Ford Feb. 23, 2018, 10:24 a.m. UTC | #1
On Fri, Feb 23, 2018 at 3:40 AM, Jean-Jacques Hiblot <jjhiblot@ti.com>
wrote:

>
> This series aims at reducing the footprint of the omap_hsmmc driver in
> the SPL (1.5 kB gain in the case of the SPL for the am335x evm).
> It also fixes an issue with the am335x_evm by setting a default maximum
> frequency if none is defined in the dts.
>
> tested on am335x_evm, bbb, bbb (vboot), and dra7 evm
>
>
I tested this version as well.

This series fixes 2d7482cf793f ("mmc: omap_hsmmc: use mmc_of_parse to
populate mmc_config") which made my DM3730 unable to probe the MMC.

Tested-by: Adam Ford <aford173@gmail.com> #omap3_logic


> Changes in v2:
> - Use a Kconfig option to compile out the ADMA support instead of relying
>   on the platform architecture
>
> Jean-Jacques Hiblot (4):
>   mmc: omap_hsmmc: do not embed struct mmc in struct omap_hsmmc_plat
>   mmc: omap_hsmmc: compile out write support if not needed
>   mmc: omap_hsmmc: make it possible to compile out ADMA support
>   mmc: omap_hsmmc: use a default 52MHz max clock rate if none is
>     specified
>
>  arch/arm/include/asm/omap_mmc.h |  2 +-
>  drivers/mmc/Kconfig             |  9 +++++++++
>  drivers/mmc/omap_hsmmc.c        | 31 ++++++++++++++++++++-----------
>  3 files changed, 30 insertions(+), 12 deletions(-)
>
> --
> 1.9.1
>
>
Jaehoon Chung Feb. 23, 2018, 10:40 a.m. UTC | #2
On 02/23/2018 07:24 PM, Adam Ford wrote:
> On Fri, Feb 23, 2018 at 3:40 AM, Jean-Jacques Hiblot <jjhiblot@ti.com>
> wrote:
> 
>>
>> This series aims at reducing the footprint of the omap_hsmmc driver in
>> the SPL (1.5 kB gain in the case of the SPL for the am335x evm).
>> It also fixes an issue with the am335x_evm by setting a default maximum
>> frequency if none is defined in the dts.
>>
>> tested on am335x_evm, bbb, bbb (vboot), and dra7 evm
>>
>>
> I tested this version as well.
> 
> This series fixes 2d7482cf793f ("mmc: omap_hsmmc: use mmc_of_parse to
> populate mmc_config") which made my DM3730 unable to probe the MMC.
> 
> Tested-by: Adam Ford <aford173@gmail.com> #omap3_logic

After testing, I will apply these patches with your tag.

Best Regards,
Jaehoon Chung

> 
> 
>> Changes in v2:
>> - Use a Kconfig option to compile out the ADMA support instead of relying
>>   on the platform architecture
>>
>> Jean-Jacques Hiblot (4):
>>   mmc: omap_hsmmc: do not embed struct mmc in struct omap_hsmmc_plat
>>   mmc: omap_hsmmc: compile out write support if not needed
>>   mmc: omap_hsmmc: make it possible to compile out ADMA support
>>   mmc: omap_hsmmc: use a default 52MHz max clock rate if none is
>>     specified
>>
>>  arch/arm/include/asm/omap_mmc.h |  2 +-
>>  drivers/mmc/Kconfig             |  9 +++++++++
>>  drivers/mmc/omap_hsmmc.c        | 31 ++++++++++++++++++++-----------
>>  3 files changed, 30 insertions(+), 12 deletions(-)
>>
>> --
>> 1.9.1
>>
>>
>