| Message ID | 20171212052255.17214-5-benh@kernel.crashing.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/5] xive: Mark a freed IRQ's IVE as valid and masked | expand |
On Tue, Dec 12, 2017 at 4:22 PM, Benjamin Herrenschmidt < benh@kernel.crashing.org> wrote: > Some HostBoot versions leave those as checkstop, they are harmless > and can sometimes occur during normal operations. > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Tested-by: Oliver O'Halloran <oohall@gmail.com> > --- > hw/xive.c | 5 +++++ > include/xive.h | 6 ++++++ > 2 files changed, 11 insertions(+) > I had similar fixes in my skiboot (kdump was broken with gpus), hostboot has fixes coming in soon for these, so I never pushed them. Balbir <div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 12, 2017 at 4:22 PM, Benjamin Herrenschmidt <span dir="ltr"><<a href="mailto:benh@kernel.crashing.org" target="_blank">benh@kernel.crashing.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Some HostBoot versions leave those as checkstop, they are harmless<br> and can sometimes occur during normal operations.<br> <br> Signed-off-by: Benjamin Herrenschmidt <<a href="mailto:benh@kernel.crashing.org">benh@kernel.crashing.org</a>><br> Tested-by: Oliver O'Halloran <<a href="mailto:oohall@gmail.com">oohall@gmail.com</a>><br> ---<br> hw/xive.c | 5 +++++<br> include/xive.h | 6 ++++++<br> 2 files changed, 11 insertions(+)<br></blockquote><div><br></div><div><br></div><div>I had similar fixes in my skiboot (kdump was broken with gpus), hostboot has fixes coming in soon for these, so I never pushed them. </div><div><br></div><div><br></div><div>Balbir </div></div></div></div>
diff --git a/hw/xive.c b/hw/xive.c index bab4892f..04dceda6 100644 --- a/hw/xive.c +++ b/hw/xive.c @@ -1780,6 +1780,11 @@ static bool xive_config_init(struct xive *x) val |= VC_EQC_CONF_ENABLE_END_u_BIT; xive_regw(x, VC_EQC_CONFIG, val); + /* Disable error reporting in the FIR for info errors + * from the VC. + */ + xive_regw(x, CQ_FIRMASK_OR, 3ull); + return true; } diff --git a/include/xive.h b/include/xive.h index 22e6a895..824ca0b8 100644 --- a/include/xive.h +++ b/include/xive.h @@ -70,6 +70,12 @@ #define CQ_AIB_CTL 0x110 #define X_CQ_RST_CTL 0x23 #define CQ_RST_CTL 0x118 +#define X_CQ_FIRMASK 0x33 +#define CQ_FIRMASK 0x198 +#define X_CQ_FIRMASK_AND 0x34 +#define CQ_FIRMASK_AND 0x1a0 +#define X_CQ_FIRMASK_OR 0x35 +#define CQ_FIRMASK_OR 0x1a8 /* PC LBS1 register offsets */ #define X_PC_TCTXT_CFG 0x100