| Message ID | 1491285921-14965-1-git-send-email-ppaidipe@linux.vnet.ibm.com |
|---|---|
| State | Rejected |
| Headers | show |
Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> writes: > Currently waiting for PHB pcie slot link timeout error messages > are in debug log level. Make them to PR_ERR, so that users can > check in console itself, as well as tests can catch these errors > easily. > > Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> > --- > hw/phb3.c | 4 ++-- > hw/phb4.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/phb3.c b/hw/phb3.c > index 9bc9d78..b37cf65 100644 > --- a/hw/phb3.c > +++ b/hw/phb3.c > @@ -2281,7 +2281,7 @@ static int64_t phb3_poll_link(struct pci_slot *slot) > } > > if (slot->retries-- == 0) { > - PHBDBG(p, "LINK: Timeout waiting for electrical link\n"); > + PHBERR(p, "LINK: Timeout waiting for electrical link\n"); > PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg); > rc = phb3_retry_state(slot); > if (rc >= OPAL_SUCCESS) (going through really old patches sitting in patchwork and cleaning things up, and even though Pridhiviraj as left IBM, it's probably good to follow up publicly) So, we merged this: commit e6bca4a0aa985920e985e3a654f4740347ebbf0e Author: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: Mon Apr 9 13:41:44 2018 +1000 phb4: Quieten and improve "Timeout waiting for electrical link" This happens normally if a slot doesn't have a working HW presence detect and relies instead of inband presence detect. The message we display is scary and not very useful unless ou are debugging, so quiten it up and change it to something more meaningful. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Acked-By: Michael Neuling <mikey@neuling.org> Signed-off-by: Stewart Smith <stewart@linux.ibm.com> Which made things quieter and more accurately reflect the reality of hardware. As such, not going to merge this patch.
diff --git a/hw/phb3.c b/hw/phb3.c index 9bc9d78..b37cf65 100644 --- a/hw/phb3.c +++ b/hw/phb3.c @@ -2281,7 +2281,7 @@ static int64_t phb3_poll_link(struct pci_slot *slot) } if (slot->retries-- == 0) { - PHBDBG(p, "LINK: Timeout waiting for electrical link\n"); + PHBERR(p, "LINK: Timeout waiting for electrical link\n"); PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg); rc = phb3_retry_state(slot); if (rc >= OPAL_SUCCESS) @@ -2302,7 +2302,7 @@ static int64_t phb3_poll_link(struct pci_slot *slot) } if (slot->retries-- == 0) { - PHBDBG(p, "LINK: Timeout waiting for link up\n"); + PHBERR(p, "LINK: Timeout waiting for link up\n"); PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg); rc = phb3_retry_state(slot); if (rc >= OPAL_SUCCESS) diff --git a/hw/phb4.c b/hw/phb4.c index 571f703..590bb30 100644 --- a/hw/phb4.c +++ b/hw/phb4.c @@ -1807,7 +1807,7 @@ static int64_t phb4_poll_link(struct pci_slot *slot) } if (slot->retries-- == 0) { - PHBDBG(p, "LINK: Timeout waiting for electrical link\n"); + PHBERR(p, "LINK: Timeout waiting for electrical link\n"); PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg); rc = phb4_retry_state(slot); if (rc >= OPAL_SUCCESS) @@ -1828,7 +1828,7 @@ static int64_t phb4_poll_link(struct pci_slot *slot) } if (slot->retries-- == 0) { - PHBDBG(p, "LINK: Timeout waiting for link up\n"); + PHBERR(p, "LINK: Timeout waiting for link up\n"); PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg); rc = phb4_retry_state(slot); if (rc >= OPAL_SUCCESS)
Currently waiting for PHB pcie slot link timeout error messages are in debug log level. Make them to PR_ERR, so that users can check in console itself, as well as tests can catch these errors easily. Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> --- hw/phb3.c | 4 ++-- hw/phb4.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)