From patchwork Tue Apr 4 06:05:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ppaidipe X-Patchwork-Id: 746703 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vxz522WNRz9s8H for ; Tue, 4 Apr 2017 16:06:46 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3vxz521XQZzDqJ8 for ; Tue, 4 Apr 2017 16:06:46 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vxz4q6hSGzDq7c for ; Tue, 4 Apr 2017 16:06:35 +1000 (AEST) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v3463sxJ157251 for ; Tue, 4 Apr 2017 02:06:23 -0400 Received: from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141]) by mx0b-001b2d01.pphosted.com with ESMTP id 29kxe31v1x-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 04 Apr 2017 02:06:23 -0400 Received: from localhost by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 4 Apr 2017 16:06:20 +1000 Received: from d23relay08.au.ibm.com (202.81.31.227) by e23smtp08.au.ibm.com (202.81.31.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 4 Apr 2017 16:06:18 +1000 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v3466AMt50921548 for ; Tue, 4 Apr 2017 16:06:18 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v3465jLE023540 for ; Tue, 4 Apr 2017 16:05:45 +1000 Received: from localhost.in.ibm.com ([9.124.31.19]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id v3465i8K023279; Tue, 4 Apr 2017 16:05:44 +1000 From: Pridhiviraj Paidipeddi To: skiboot@lists.ozlabs.org Date: Tue, 4 Apr 2017 11:35:21 +0530 X-Mailer: git-send-email 2.7.4 X-TM-AS-MML: disable x-cbid: 17040406-0048-0000-0000-0000021A33A6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17040406-0049-0000-0000-000047C63B21 Message-Id: <1491285921-14965-1-git-send-email-ppaidipe@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-04-04_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704040056 Subject: [Skiboot] [PATCH] hw/phb[3/4]: Increase the severity level for pcie slot link timeouts X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Currently waiting for PHB pcie slot link timeout error messages are in debug log level. Make them to PR_ERR, so that users can check in console itself, as well as tests can catch these errors easily. Signed-off-by: Pridhiviraj Paidipeddi --- hw/phb3.c | 4 ++-- hw/phb4.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/phb3.c b/hw/phb3.c index 9bc9d78..b37cf65 100644 --- a/hw/phb3.c +++ b/hw/phb3.c @@ -2281,7 +2281,7 @@ static int64_t phb3_poll_link(struct pci_slot *slot) } if (slot->retries-- == 0) { - PHBDBG(p, "LINK: Timeout waiting for electrical link\n"); + PHBERR(p, "LINK: Timeout waiting for electrical link\n"); PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg); rc = phb3_retry_state(slot); if (rc >= OPAL_SUCCESS) @@ -2302,7 +2302,7 @@ static int64_t phb3_poll_link(struct pci_slot *slot) } if (slot->retries-- == 0) { - PHBDBG(p, "LINK: Timeout waiting for link up\n"); + PHBERR(p, "LINK: Timeout waiting for link up\n"); PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg); rc = phb3_retry_state(slot); if (rc >= OPAL_SUCCESS) diff --git a/hw/phb4.c b/hw/phb4.c index 571f703..590bb30 100644 --- a/hw/phb4.c +++ b/hw/phb4.c @@ -1807,7 +1807,7 @@ static int64_t phb4_poll_link(struct pci_slot *slot) } if (slot->retries-- == 0) { - PHBDBG(p, "LINK: Timeout waiting for electrical link\n"); + PHBERR(p, "LINK: Timeout waiting for electrical link\n"); PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg); rc = phb4_retry_state(slot); if (rc >= OPAL_SUCCESS) @@ -1828,7 +1828,7 @@ static int64_t phb4_poll_link(struct pci_slot *slot) } if (slot->retries-- == 0) { - PHBDBG(p, "LINK: Timeout waiting for link up\n"); + PHBERR(p, "LINK: Timeout waiting for link up\n"); PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg); rc = phb4_retry_state(slot); if (rc >= OPAL_SUCCESS)