| Message ID | 51E65168.5080907@siemens.com |
|---|---|
| State | New |
| Headers | show |
On 2013-07-17 10:10, Jan Kiszka wrote: > With this patch QEMU handles qAttached request from gdb. When QEMU > replies 1, GDB sends a "detach" command at the end of a debugging > session otherwise GDB sends "kill". > > The default value for qAttached is 1 on system emulation and 0 on user > emulation. > > Based on original version by Fabien Chouteau. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- > gdbstub.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 0ee82a9..bc626f5 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -42,6 +42,12 @@ > #include "sysemu/kvm.h" > #include "qemu/bitops.h" > > +#ifdef CONFIG_USER_ONLY > +#define GDB_ATTACHED "0" > +#else > +#define GDB_ATTACHED "1" > +#endif > + > #ifndef TARGET_CPU_MEMORY_RW_DEBUG > static inline int target_memory_rw_debug(CPUArchState *env, target_ulong addr, > uint8_t *buf, int len, int is_write) > @@ -2504,6 +2510,10 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) > break; > } > #endif > + if (strncmp(p, "Attached", 8) == 0) { > + put_packet(s, GDB_ATTACHED); > + break; > + } > /* Unrecognised 'q' command. */ > goto unknown_command; > > Peter, could you pick up these two almost trivial long-pending patches? They still apply and are still useful. If you prefer that I repost them, just let me know. Thanks, Jan
On 12 March 2014 07:37, Jan Kiszka <jan.kiszka@siemens.com> wrote: > Peter, could you pick up these two almost trivial long-pending patches? > They still apply and are still useful. If you prefer that I repost them, > just let me know. I don't really want to apply more patches directly than I absolutely have to, because it basically obliges me to do a full review and functionality test of those patches... thanks -- PMM
diff --git a/gdbstub.c b/gdbstub.c index 0ee82a9..bc626f5 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -42,6 +42,12 @@ #include "sysemu/kvm.h" #include "qemu/bitops.h" +#ifdef CONFIG_USER_ONLY +#define GDB_ATTACHED "0" +#else +#define GDB_ATTACHED "1" +#endif + #ifndef TARGET_CPU_MEMORY_RW_DEBUG static inline int target_memory_rw_debug(CPUArchState *env, target_ulong addr, uint8_t *buf, int len, int is_write) @@ -2504,6 +2510,10 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) break; } #endif + if (strncmp(p, "Attached", 8) == 0) { + put_packet(s, GDB_ATTACHED); + break; + } /* Unrecognised 'q' command. */ goto unknown_command;
With this patch QEMU handles qAttached request from gdb. When QEMU replies 1, GDB sends a "detach" command at the end of a debugging session otherwise GDB sends "kill". The default value for qAttached is 1 on system emulation and 0 on user emulation. Based on original version by Fabien Chouteau. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- gdbstub.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)