mbox

[PULL] Remove unused function parameters

Message ID 4DAEA168.4050901@mail.berlios.de
State Accepted
Headers show

Pull-request

git://qemu.weilnetz.de/git/qemu.git/ patches

Message

Stefan Weil April 20, 2011, 9:03 a.m. UTC
Hello,

I updated the first patch as suggested by Peter Maydell
(Fix [] typo, fix copy+paste error with SHA1 object name
in commit message). The rest is identical, so I don't
resend it to qemu-devel.

Cheers,
Stefan Weil


The following changes since commit 8d5192ee15bc519f83741f5e413ebba5d57a6abd:
   Alexander Graf (1):
         s390x: virtio machine storage keys

are available in the git repository at:

   git://qemu.weilnetz.de/git/qemu.git/ patches

Stefan Weil (2):
       Remove unused function parameters from gen_pc_load and rename the 
function
       Remove unused function parameter from cpu_restore_state

  cpu-exec.c                    |    2 +-
  exec-all.h                    |    7 +++----
  exec.c                        |    9 ++++-----
  target-alpha/op_helper.c      |    2 +-
  target-alpha/translate.c      |    3 +--
  target-arm/op_helper.c        |    2 +-
  target-arm/translate.c        |    7 +++----
  target-cris/op_helper.c       |    2 +-
  target-cris/translate.c       |    3 +--
  target-i386/op_helper.c       |    2 +-
  target-i386/translate.c       |    7 +++----
  target-lm32/op_helper.c       |    2 +-
  target-lm32/translate.c       |    3 +--
  target-m68k/op_helper.c       |    2 +-
  target-m68k/translate.c       |    3 +--
  target-microblaze/op_helper.c |    2 +-
  target-microblaze/translate.c |    3 +--
  target-mips/op_helper.c       |    4 ++--
  target-mips/translate.c       |    3 +--
  target-ppc/op_helper.c        |    2 +-
  target-ppc/translate.c        |    3 +--
  target-s390x/op_helper.c      |    2 +-
  target-s390x/translate.c      |    3 +--
  target-sh4/op_helper.c        |    2 +-
  target-sh4/translate.c        |    3 +--
  target-sparc/op_helper.c      |    2 +-
  target-sparc/translate.c      |    3 +--
  target-unicore32/translate.c  |    3 +--
  translate-all.c               |    5 ++---
  29 files changed, 40 insertions(+), 56 deletions(-)

Comments

Aurelien Jarno April 20, 2011, 10:53 a.m. UTC | #1
On Wed, Apr 20, 2011 at 11:03:36AM +0200, Stefan Weil wrote:
> Hello,
> 
> I updated the first patch as suggested by Peter Maydell
> (Fix [] typo, fix copy+paste error with SHA1 object name
> in commit message). The rest is identical, so I don't
> resend it to qemu-devel.

Thanks, pulled. In the future please resend the patches on the mailing
list anyway if they differ from the previous patches. This can be in the
same thread as the pull. This is quite handy when you want to work on
QEMU without Internet access.

> Cheers,
> Stefan Weil
> 
> 
> The following changes since commit 8d5192ee15bc519f83741f5e413ebba5d57a6abd:
>   Alexander Graf (1):
>         s390x: virtio machine storage keys
> 
> are available in the git repository at:
> 
>   git://qemu.weilnetz.de/git/qemu.git/ patches
> 
> Stefan Weil (2):
>       Remove unused function parameters from gen_pc_load and rename
> the function
>       Remove unused function parameter from cpu_restore_state
> 
>  cpu-exec.c                    |    2 +-
>  exec-all.h                    |    7 +++----
>  exec.c                        |    9 ++++-----
>  target-alpha/op_helper.c      |    2 +-
>  target-alpha/translate.c      |    3 +--
>  target-arm/op_helper.c        |    2 +-
>  target-arm/translate.c        |    7 +++----
>  target-cris/op_helper.c       |    2 +-
>  target-cris/translate.c       |    3 +--
>  target-i386/op_helper.c       |    2 +-
>  target-i386/translate.c       |    7 +++----
>  target-lm32/op_helper.c       |    2 +-
>  target-lm32/translate.c       |    3 +--
>  target-m68k/op_helper.c       |    2 +-
>  target-m68k/translate.c       |    3 +--
>  target-microblaze/op_helper.c |    2 +-
>  target-microblaze/translate.c |    3 +--
>  target-mips/op_helper.c       |    4 ++--
>  target-mips/translate.c       |    3 +--
>  target-ppc/op_helper.c        |    2 +-
>  target-ppc/translate.c        |    3 +--
>  target-s390x/op_helper.c      |    2 +-
>  target-s390x/translate.c      |    3 +--
>  target-sh4/op_helper.c        |    2 +-
>  target-sh4/translate.c        |    3 +--
>  target-sparc/op_helper.c      |    2 +-
>  target-sparc/translate.c      |    3 +--
>  target-unicore32/translate.c  |    3 +--
>  translate-all.c               |    5 ++---
>  29 files changed, 40 insertions(+), 56 deletions(-)
> 
> 
>
Peter Maydell April 20, 2011, 10:57 a.m. UTC | #2
On 20 April 2011 11:53, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On Wed, Apr 20, 2011 at 11:03:36AM +0200, Stefan Weil wrote:
>> Hello,
>>
>> I updated the first patch as suggested by Peter Maydell
>> (Fix [] typo, fix copy+paste error with SHA1 object name
>> in commit message). The rest is identical, so I don't
>> resend it to qemu-devel.
>
> Thanks, pulled. In the future please resend the patches on the mailing
> list anyway if they differ from the previous patches. This can be in the
> same thread as the pull. This is quite handy when you want to work on
> QEMU without Internet access.

Maybe we should document "how to send a pull request" on the wiki?
I remember having to quiz Anthony on irc about the preferred format
the first time I did one...

-- PMM