| Message ID | 20230622161646.32005-9-max.chou@sifive.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add RISC-V vector cryptographic instruction set support | expand |
On 6/22/23 13:16, Max Chou wrote: > The 5th parameter of tcg_gen_gvec_2s should be replaces by the temporary s/replaces/replaced > tmp variable in the tcg_gen_gvec_andcs function. > > Signed-off-by: Max Chou <max.chou@sifive.com> > --- Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > tcg/tcg-op-gvec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c > index 95a588d6d2..a062239804 100644 > --- a/tcg/tcg-op-gvec.c > +++ b/tcg/tcg-op-gvec.c > @@ -2774,7 +2774,7 @@ void tcg_gen_gvec_andcs(unsigned vece, uint32_t dofs, uint32_t aofs, > > TCGv_i64 tmp = tcg_temp_ebb_new_i64(); > tcg_gen_dup_i64(vece, tmp, c); > - tcg_gen_gvec_2s(dofs, aofs, oprsz, maxsz, c, &g); > + tcg_gen_gvec_2s(dofs, aofs, oprsz, maxsz, tmp, &g); > tcg_temp_free_i64(tmp); > } >
On 6/22/23 19:30, Daniel Henrique Barboza wrote: > > > On 6/22/23 13:16, Max Chou wrote: >> The 5th parameter of tcg_gen_gvec_2s should be replaces by the temporary > > s/replaces/replaced > > >> tmp variable in the tcg_gen_gvec_andcs function. >> >> Signed-off-by: Max Chou <max.chou@sifive.com> >> --- > > Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> Queued to tcg-next with the typo fixed. r~ > >> tcg/tcg-op-gvec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c >> index 95a588d6d2..a062239804 100644 >> --- a/tcg/tcg-op-gvec.c >> +++ b/tcg/tcg-op-gvec.c >> @@ -2774,7 +2774,7 @@ void tcg_gen_gvec_andcs(unsigned vece, uint32_t dofs, uint32_t aofs, >> TCGv_i64 tmp = tcg_temp_ebb_new_i64(); >> tcg_gen_dup_i64(vece, tmp, c); >> - tcg_gen_gvec_2s(dofs, aofs, oprsz, maxsz, c, &g); >> + tcg_gen_gvec_2s(dofs, aofs, oprsz, maxsz, tmp, &g); >> tcg_temp_free_i64(tmp); >> }
diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c index 95a588d6d2..a062239804 100644 --- a/tcg/tcg-op-gvec.c +++ b/tcg/tcg-op-gvec.c @@ -2774,7 +2774,7 @@ void tcg_gen_gvec_andcs(unsigned vece, uint32_t dofs, uint32_t aofs, TCGv_i64 tmp = tcg_temp_ebb_new_i64(); tcg_gen_dup_i64(vece, tmp, c); - tcg_gen_gvec_2s(dofs, aofs, oprsz, maxsz, c, &g); + tcg_gen_gvec_2s(dofs, aofs, oprsz, maxsz, tmp, &g); tcg_temp_free_i64(tmp); }
The 5th parameter of tcg_gen_gvec_2s should be replaces by the temporary tmp variable in the tcg_gen_gvec_andcs function. Signed-off-by: Max Chou <max.chou@sifive.com> --- tcg/tcg-op-gvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)