diff mbox series

[v10,02/11] target/arm: Remove dead code from cpu_max_set_sve_max_vq

Message ID 20230412121829.14452-3-farosas@suse.de
State New
Headers show
Series target/arm: Allow CONFIG_TCG=n builds | expand

Commit Message

Fabiano Rosas April 12, 2023, 12:18 p.m. UTC 
The sve-max-vq property has been removed from the -cpu max used with
KVM, so code under kvm_enabled in cpu_max_set_sve_max_vq is not
reachable.

Fixes: 0baa21be49 ("target/arm: Make KVM -cpu max exactly like -cpu host")
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 target/arm/cpu64.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Philippe Mathieu-Daudé April 21, 2023, 5:53 p.m. UTC | #1 
On 12/4/23 14:18, Fabiano Rosas wrote:
> The sve-max-vq property has been removed from the -cpu max used with
> KVM, so code under kvm_enabled in cpu_max_set_sve_max_vq is not
> reachable.
> 
> Fixes: 0baa21be49 ("target/arm: Make KVM -cpu max exactly like -cpu host")
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>   target/arm/cpu64.c | 6 ------
>   1 file changed, 6 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Richard Henderson April 23, 2023, 10:48 a.m. UTC | #2 
On 4/12/23 13:18, Fabiano Rosas wrote:
> The sve-max-vq property has been removed from the -cpu max used with
> KVM, so code under kvm_enabled in cpu_max_set_sve_max_vq is not
> reachable.
> 
> Fixes: 0baa21be49 ("target/arm: Make KVM -cpu max exactly like -cpu host")
> Signed-off-by: Fabiano Rosas<farosas@suse.de>
> ---
>   target/arm/cpu64.c | 6 ------
>   1 file changed, 6 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
diff mbox series

Patch

diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
index 61a6b52aa6..f0dd041cfb 100644
--- a/target/arm/cpu64.c
+++ b/target/arm/cpu64.c
@@ -336,12 +336,6 @@  static void cpu_max_set_sve_max_vq(Object *obj, Visitor *v, const char *name,
         return;
     }
 
-    if (kvm_enabled() && !kvm_arm_sve_supported()) {
-        error_setg(errp, "cannot set sve-max-vq");
-        error_append_hint(errp, "SVE not supported by KVM on this host\n");
-        return;
-    }
-
     if (max_vq == 0 || max_vq > ARM_MAX_VQ) {
         error_setg(errp, "unsupported SVE vector length");
         error_append_hint(errp, "Valid sve-max-vq in range [1-%d]\n",