diff mbox series

[v3,3/3] hvf: handle singlestepping over instructions which trigger a VM exit

Message ID 20230114161302.94595-4-fcagnin@quarkslab.com
State New
Headers show
Series Add gdbstub support to HVF | expand

Commit Message

Francesco Cagnin Jan. 14, 2023, 4:13 p.m. UTC 
From: Francesco Cagnin <fcagnin@quarkslab.com>

Signed-off-by: Francesco Cagnin <fcagnin@quarkslab.com>
---
 target/arm/hvf/hvf.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Peter Maydell Feb. 13, 2023, 11:53 a.m. UTC | #1 
On Sat, 14 Jan 2023 at 16:13, <francesco.cagnin@gmail.com> wrote:
>
> From: Francesco Cagnin <fcagnin@quarkslab.com>
>
> Signed-off-by: Francesco Cagnin <fcagnin@quarkslab.com>
> ---
>  target/arm/hvf/hvf.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c
> index c63e8da6a5..87c531508e 100644
> --- a/target/arm/hvf/hvf.c
> +++ b/target/arm/hvf/hvf.c
> @@ -1807,6 +1807,10 @@ int hvf_vcpu_exec(CPUState *cpu)
>          pc += 4;
>          r = hv_vcpu_set_reg(cpu->hvf->fd, HV_REG_PC, pc);
>          assert_hvf_ok(r);
> +
> +        if (cpu->singlestep_enabled) {
> +            ret = EXCP_DEBUG;
> +        }
>      }
>
>      return ret;

I think this is probably best folded into patch 2 rather than
being a separate patch.

thanks
-- PMM
diff mbox series

Patch

diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c
index c63e8da6a5..87c531508e 100644
--- a/target/arm/hvf/hvf.c
+++ b/target/arm/hvf/hvf.c
@@ -1807,6 +1807,10 @@  int hvf_vcpu_exec(CPUState *cpu)
         pc += 4;
         r = hv_vcpu_set_reg(cpu->hvf->fd, HV_REG_PC, pc);
         assert_hvf_ok(r);
+
+        if (cpu->singlestep_enabled) {
+            ret = EXCP_DEBUG;
+        }
     }
 
     return ret;