| Message ID | 20230110164406.94366-3-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw/arm: Move various objects to softmmu_ss to build them once (part 1) | expand |
On 1/10/23 08:43, Philippe Mathieu-Daudé wrote: > default_reset_secondary() uses address_space_stl_notdirty(), > itself declared in "exec/cpu-all.h". Include this header in > order to avoid when refactoring headers: > > ../hw/arm/boot.c:281:5: error: implicit declaration of function 'address_space_stl_notdirty' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > address_space_stl_notdirty(as, info->smp_bootreg_addr, > ^ > > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org> > --- > hw/arm/boot.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 3d7d11f782..f5bfb922b1 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -25,6 +25,7 @@ #include "qemu/config-file.h" #include "qemu/option.h" #include "qemu/units.h" +#include "exec/cpu-all.h" /* Kernel boot protocol is specified in the kernel docs * Documentation/arm/Booting and Documentation/arm64/booting.txt
default_reset_secondary() uses address_space_stl_notdirty(), itself declared in "exec/cpu-all.h". Include this header in order to avoid when refactoring headers: ../hw/arm/boot.c:281:5: error: implicit declaration of function 'address_space_stl_notdirty' is invalid in C99 [-Werror,-Wimplicit-function-declaration] address_space_stl_notdirty(as, info->smp_bootreg_addr, ^ Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/arm/boot.c | 1 + 1 file changed, 1 insertion(+)