| Message ID | 20221111201337.3320349-1-atishp@rivosinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | hw/riscv: virt: Remove the redundant ipi-id property | expand |
On Sat, Nov 12, 2022 at 4:14 AM Atish Patra <atishp@rivosinc.com> wrote: > > The imsic DT binding has changed and no longer require an ipi-id. requires Could you please put a link here to the upstream imsic DT binding for reference? > The latest IMSIC driver dynamically allocates ipi id if slow-ipi > is not defined. > > Get rid of the unused dt property which may lead to confusion. > > Signed-off-by: Atish Patra <atishp@rivosinc.com> > --- > hw/riscv/virt.c | 2 -- > include/hw/riscv/virt.h | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > index a5bc7353b412..0bc0964e42a8 100644 > --- a/hw/riscv/virt.c > +++ b/hw/riscv/virt.c > @@ -546,8 +546,6 @@ static void create_fdt_imsic(RISCVVirtState *s, const MemMapEntry *memmap, > riscv_socket_count(mc) * sizeof(uint32_t) * 4); > qemu_fdt_setprop_cell(mc->fdt, imsic_name, "riscv,num-ids", > VIRT_IRQCHIP_NUM_MSIS); > - qemu_fdt_setprop_cells(mc->fdt, imsic_name, "riscv,ipi-id", > - VIRT_IRQCHIP_IPI_MSI); > if (riscv_socket_count(mc) > 1) { > qemu_fdt_setprop_cell(mc->fdt, imsic_name, "riscv,hart-index-bits", > imsic_num_bits(imsic_max_hart_per_socket)); > diff --git a/include/hw/riscv/virt.h b/include/hw/riscv/virt.h > index be4ab8fe7f71..62513e075c47 100644 > --- a/include/hw/riscv/virt.h > +++ b/include/hw/riscv/virt.h > @@ -93,7 +93,6 @@ enum { > > #define VIRT_PLATFORM_BUS_NUM_IRQS 32 > > -#define VIRT_IRQCHIP_IPI_MSI 1 > #define VIRT_IRQCHIP_NUM_MSIS 255 > #define VIRT_IRQCHIP_NUM_SOURCES VIRTIO_NDEV > #define VIRT_IRQCHIP_NUM_PRIO_BITS 3 > -- Regards, Bin
On Fri, Nov 11, 2022 at 4:39 PM Bin Meng <bmeng.cn@gmail.com> wrote: > On Sat, Nov 12, 2022 at 4:14 AM Atish Patra <atishp@rivosinc.com> wrote: > > > > The imsic DT binding has changed and no longer require an ipi-id. > > requires > > Sure. Will fix it. > Could you please put a link here to the upstream imsic DT binding for > reference? > > It's not merged yet. Here is the latest version: https://lore.kernel.org/lkml/20221111044207.1478350-5-apatel@ventanamicro.com/ > > The latest IMSIC driver dynamically allocates ipi id if slow-ipi > > is not defined. > > > > Get rid of the unused dt property which may lead to confusion. > > > > Signed-off-by: Atish Patra <atishp@rivosinc.com> > > --- > > hw/riscv/virt.c | 2 -- > > include/hw/riscv/virt.h | 1 - > > 2 files changed, 3 deletions(-) > > > > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > > index a5bc7353b412..0bc0964e42a8 100644 > > --- a/hw/riscv/virt.c > > +++ b/hw/riscv/virt.c > > @@ -546,8 +546,6 @@ static void create_fdt_imsic(RISCVVirtState *s, > const MemMapEntry *memmap, > > riscv_socket_count(mc) * sizeof(uint32_t) * 4); > > qemu_fdt_setprop_cell(mc->fdt, imsic_name, "riscv,num-ids", > > VIRT_IRQCHIP_NUM_MSIS); > > - qemu_fdt_setprop_cells(mc->fdt, imsic_name, "riscv,ipi-id", > > - VIRT_IRQCHIP_IPI_MSI); > > if (riscv_socket_count(mc) > 1) { > > qemu_fdt_setprop_cell(mc->fdt, imsic_name, > "riscv,hart-index-bits", > > imsic_num_bits(imsic_max_hart_per_socket)); > > diff --git a/include/hw/riscv/virt.h b/include/hw/riscv/virt.h > > index be4ab8fe7f71..62513e075c47 100644 > > --- a/include/hw/riscv/virt.h > > +++ b/include/hw/riscv/virt.h > > @@ -93,7 +93,6 @@ enum { > > > > #define VIRT_PLATFORM_BUS_NUM_IRQS 32 > > > > -#define VIRT_IRQCHIP_IPI_MSI 1 > > #define VIRT_IRQCHIP_NUM_MSIS 255 > > #define VIRT_IRQCHIP_NUM_SOURCES VIRTIO_NDEV > > #define VIRT_IRQCHIP_NUM_PRIO_BITS 3 > > -- > > Regards, > Bin >
On Sat, Nov 12, 2022 at 8:42 AM Atish Kumar Patra <atishp@rivosinc.com> wrote: > > > > On Fri, Nov 11, 2022 at 4:39 PM Bin Meng <bmeng.cn@gmail.com> wrote: >> >> On Sat, Nov 12, 2022 at 4:14 AM Atish Patra <atishp@rivosinc.com> wrote: >> > >> > The imsic DT binding has changed and no longer require an ipi-id. >> >> requires >> > > Sure. Will fix it. > >> >> Could you please put a link here to the upstream imsic DT binding for reference? >> > > It's not merged yet. Here is the latest version: > > https://lore.kernel.org/lkml/20221111044207.1478350-5-apatel@ventanamicro.com/ Thanks. Putting this link in the commit message helps a lot. > >> >> > The latest IMSIC driver dynamically allocates ipi id if slow-ipi >> > is not defined. >> > >> > Get rid of the unused dt property which may lead to confusion. >> > >> > Signed-off-by: Atish Patra <atishp@rivosinc.com> >> > --- >> > hw/riscv/virt.c | 2 -- >> > include/hw/riscv/virt.h | 1 - >> > 2 files changed, 3 deletions(-) >> > Regards, Bin
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index a5bc7353b412..0bc0964e42a8 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -546,8 +546,6 @@ static void create_fdt_imsic(RISCVVirtState *s, const MemMapEntry *memmap, riscv_socket_count(mc) * sizeof(uint32_t) * 4); qemu_fdt_setprop_cell(mc->fdt, imsic_name, "riscv,num-ids", VIRT_IRQCHIP_NUM_MSIS); - qemu_fdt_setprop_cells(mc->fdt, imsic_name, "riscv,ipi-id", - VIRT_IRQCHIP_IPI_MSI); if (riscv_socket_count(mc) > 1) { qemu_fdt_setprop_cell(mc->fdt, imsic_name, "riscv,hart-index-bits", imsic_num_bits(imsic_max_hart_per_socket)); diff --git a/include/hw/riscv/virt.h b/include/hw/riscv/virt.h index be4ab8fe7f71..62513e075c47 100644 --- a/include/hw/riscv/virt.h +++ b/include/hw/riscv/virt.h @@ -93,7 +93,6 @@ enum { #define VIRT_PLATFORM_BUS_NUM_IRQS 32 -#define VIRT_IRQCHIP_IPI_MSI 1 #define VIRT_IRQCHIP_NUM_MSIS 255 #define VIRT_IRQCHIP_NUM_SOURCES VIRTIO_NDEV #define VIRT_IRQCHIP_NUM_PRIO_BITS 3
The imsic DT binding has changed and no longer require an ipi-id. The latest IMSIC driver dynamically allocates ipi id if slow-ipi is not defined. Get rid of the unused dt property which may lead to confusion. Signed-off-by: Atish Patra <atishp@rivosinc.com> --- hw/riscv/virt.c | 2 -- include/hw/riscv/virt.h | 1 - 2 files changed, 3 deletions(-)