| Message ID | 20220404154658.565020-14-peter.maydell@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw/arm: Make exynos4210 use TYPE_SPLIT_IRQ | expand |
On 4/4/22 10:46, Peter Maydell wrote: > In exynos4210_init_board_irqs(), the loop that handles IRQ lines that > are in a range that applies to the internal combiner only creates a > splitter for those interrupts which go to both the internal combiner > and to the external GIC, but it does nothing at all for the > interrupts which don't go to the external GIC, leaving the > irq_table[] array element empty for those. (This will result in > those interrupts simply being lost, not in a QEMU crash.) > > I don't have a reliable datasheet for this SoC, but since we do wire > up one interrupt line in this category (the HDMI I2C device on > interrupt 16,1), this seems like it must be a bug in the existing > QEMU code. Fill in the irq_table[] entries where we're not splitting > the IRQ to both the internal combiner and the external GIC with the > IRQ line of the internal combiner. (That is, these IRQ lines go to > just one device, not multiple.) > > This bug didn't have any visible guest effects because the only > implemented device that was affected was the HDMI I2C controller, > and we never connect any I2C devices to that bus. > > Signed-off-by: Peter Maydell<peter.maydell@linaro.org> > --- > hw/arm/exynos4210.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c index 919821833b5..a4527f819ef 100644 --- a/hw/arm/exynos4210.c +++ b/hw/arm/exynos4210.c @@ -310,6 +310,8 @@ static void exynos4210_init_board_irqs(Exynos4210State *s) qdev_connect_gpio_out(splitter, 0, is->int_combiner_irq[n]); qdev_connect_gpio_out(splitter, 1, qdev_get_gpio_in(extgicdev, irq_id - 32)); + } else { + s->irq_table[n] = is->int_combiner_irq[n]; } } /*
In exynos4210_init_board_irqs(), the loop that handles IRQ lines that are in a range that applies to the internal combiner only creates a splitter for those interrupts which go to both the internal combiner and to the external GIC, but it does nothing at all for the interrupts which don't go to the external GIC, leaving the irq_table[] array element empty for those. (This will result in those interrupts simply being lost, not in a QEMU crash.) I don't have a reliable datasheet for this SoC, but since we do wire up one interrupt line in this category (the HDMI I2C device on interrupt 16,1), this seems like it must be a bug in the existing QEMU code. Fill in the irq_table[] entries where we're not splitting the IRQ to both the internal combiner and the external GIC with the IRQ line of the internal combiner. (That is, these IRQ lines go to just one device, not multiple.) This bug didn't have any visible guest effects because the only implemented device that was affected was the HDMI I2C controller, and we never connect any I2C devices to that bus. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- hw/arm/exynos4210.c | 2 ++ 1 file changed, 2 insertions(+)