| Message ID | 20220324175015.232794-5-victortoso@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Fix some qapi examples and a TODO section | expand |
On Thu, Mar 24, 2022, 1:50 PM Victor Toso <victortoso@redhat.com> wrote: > * Event's name: BLOCK_JOB_WAITING -> BLOCK_JOB_PENDING > * Argument device -> id > > Signed-off-by: Victor Toso <victortoso@redhat.com> > --- > qapi/block-core.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 5b6c069dd9..ea96e1b009 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -5226,8 +5226,8 @@ > # > # Example: > # > -# <- { "event": "BLOCK_JOB_WAITING", > -# "data": { "device": "drive0", "type": "mirror" }, > +# <- { "event": "BLOCK_JOB_PENDING", > +# "data": { "type": "mirror", "id": "backup_1" }, > # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } > # > ## > -- > 2.35.1 > Ow, how'd I get away with this? It was just always wrong and we never noticed? Cool. Reviewed-by: John Snow <jsnow@redhat.com> (Whoa, this is from 2018? It feels like it was from way before then.) >
Victor Toso <victortoso@redhat.com> writes: > * Event's name: BLOCK_JOB_WAITING -> BLOCK_JOB_PENDING > * Argument device -> id > > Signed-off-by: Victor Toso <victortoso@redhat.com> > --- > qapi/block-core.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 5b6c069dd9..ea96e1b009 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -5226,8 +5226,8 @@ > # > # Example: > # > -# <- { "event": "BLOCK_JOB_WAITING", > -# "data": { "device": "drive0", "type": "mirror" }, > +# <- { "event": "BLOCK_JOB_PENDING", > +# "data": { "type": "mirror", "id": "backup_1" }, > # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } > # > ## Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff --git a/qapi/block-core.json b/qapi/block-core.json index 5b6c069dd9..ea96e1b009 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -5226,8 +5226,8 @@ # # Example: # -# <- { "event": "BLOCK_JOB_WAITING", -# "data": { "device": "drive0", "type": "mirror" }, +# <- { "event": "BLOCK_JOB_PENDING", +# "data": { "type": "mirror", "id": "backup_1" }, # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ##
* Event's name: BLOCK_JOB_WAITING -> BLOCK_JOB_PENDING * Argument device -> id Signed-off-by: Victor Toso <victortoso@redhat.com> --- qapi/block-core.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)