| Message ID | 20220324175015.232794-10-victortoso@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Fix some qapi examples and a TODO section | expand |
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso <victortoso@redhat.com> wrote: > > As reason member in not optional. Suggest: "The 'reason' member is not optional." I also like how you included the type/structure name in the other commit messages, can you work "SHUTDOWN" into this one? > > Signed-off-by: Victor Toso <victortoso@redhat.com> > --- > qapi/run-state.json | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/qapi/run-state.json b/qapi/run-state.json > index 43d66d700f..1b9f64c9cd 100644 > --- a/qapi/run-state.json > +++ b/qapi/run-state.json > @@ -150,7 +150,8 @@ > # > # Example: > # > -# <- { "event": "SHUTDOWN", "data": { "guest": true }, > +# <- { "event": "SHUTDOWN", > +# "data": { "guest": true, "reason": "guest-shutdown" }, > # "timestamp": { "seconds": 1267040730, "microseconds": 682951 } } > # > ## > @@ -188,7 +189,8 @@ > # > # Example: > # > -# <- { "event": "RESET", "data": { "guest": false }, > +# <- { "event": "RESET", > +# "data": { "guest": false, "reason": "guest-reset" }, > # "timestamp": { "seconds": 1267041653, "microseconds": 9518 } } > # > ## > -- > 2.35.1 > With commit tweaks: Reviewed-by: John Snow <jsnow@redhat.com>
diff --git a/qapi/run-state.json b/qapi/run-state.json index 43d66d700f..1b9f64c9cd 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -150,7 +150,8 @@ # # Example: # -# <- { "event": "SHUTDOWN", "data": { "guest": true }, +# <- { "event": "SHUTDOWN", +# "data": { "guest": true, "reason": "guest-shutdown" }, # "timestamp": { "seconds": 1267040730, "microseconds": 682951 } } # ## @@ -188,7 +189,8 @@ # # Example: # -# <- { "event": "RESET", "data": { "guest": false }, +# <- { "event": "RESET", +# "data": { "guest": false, "reason": "guest-reset" }, # "timestamp": { "seconds": 1267041653, "microseconds": 9518 } } # ##
As reason member in not optional. Signed-off-by: Victor Toso <victortoso@redhat.com> --- qapi/run-state.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)