| Message ID | 20220308170302.2582820-1-peter.maydell@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw/misc/npcm7xx_clk: Don't leak string in npcm7xx_clk_sel_init() | expand |
On 3/8/22 07:03, Peter Maydell wrote: > In npcm7xx_clk_sel_init() we allocate a string with g_strdup_printf(). > Use g_autofree so we free it rather than leaking it. > > (Detected with the clang leak sanitizer.) > > Signed-off-by: Peter Maydell<peter.maydell@linaro.org> > --- > hw/misc/npcm7xx_clk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 8/3/22 18:03, Peter Maydell wrote: > In npcm7xx_clk_sel_init() we allocate a string with g_strdup_printf(). > Use g_autofree so we free it rather than leaking it. > > (Detected with the clang leak sanitizer.) > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/misc/npcm7xx_clk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On Tue, Mar 8, 2022 at 10:09 AM Richard Henderson < richard.henderson@linaro.org> wrote: > On 3/8/22 07:03, Peter Maydell wrote: > > In npcm7xx_clk_sel_init() we allocate a string with g_strdup_printf(). > > Use g_autofree so we free it rather than leaking it. > > > > (Detected with the clang leak sanitizer.) > > > > Signed-off-by: Peter Maydell<peter.maydell@linaro.org> > > --- > > hw/misc/npcm7xx_clk.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > > Reviewed-by: Hao Wu <wuhaotsh@google.com> > r~ > >
diff --git a/hw/misc/npcm7xx_clk.c b/hw/misc/npcm7xx_clk.c index 0b61070c52f..bc2b879feb5 100644 --- a/hw/misc/npcm7xx_clk.c +++ b/hw/misc/npcm7xx_clk.c @@ -612,8 +612,8 @@ static void npcm7xx_clk_sel_init(Object *obj) NPCM7xxClockSELState *sel = NPCM7XX_CLOCK_SEL(obj); for (i = 0; i < NPCM7XX_CLK_SEL_MAX_INPUT; ++i) { - sel->clock_in[i] = qdev_init_clock_in(DEVICE(sel), - g_strdup_printf("clock-in[%d]", i), + g_autofree char *s = g_strdup_printf("clock-in[%d]", i); + sel->clock_in[i] = qdev_init_clock_in(DEVICE(sel), s, npcm7xx_clk_update_sel_cb, sel, ClockUpdate); } sel->clock_out = qdev_init_clock_out(DEVICE(sel), "clock-out");
In npcm7xx_clk_sel_init() we allocate a string with g_strdup_printf(). Use g_autofree so we free it rather than leaking it. (Detected with the clang leak sanitizer.) Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- hw/misc/npcm7xx_clk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)