| Message ID | 20211124100617.19786-5-quintela@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Migration: Transmit and detect zero pages in the multifd threads | expand |
* Juan Quintela (quintela@redhat.com) wrote: > Signed-off-by: Juan Quintela <quintela@redhat.com> Pretty obvious, but I guess to have the complete set of comments: Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > migration/multifd-zlib.c | 2 ++ > migration/multifd-zstd.c | 2 ++ > migration/multifd.c | 1 + > 3 files changed, 5 insertions(+) > > diff --git a/migration/multifd-zlib.c b/migration/multifd-zlib.c > index 3fc7813b44..d0437cce2a 100644 > --- a/migration/multifd-zlib.c > +++ b/migration/multifd-zlib.c > @@ -72,6 +72,7 @@ static int zlib_send_setup(MultiFDSendParams *p, Error **errp) > * Close the channel and return memory. > * > * @p: Params for the channel that we are using > + * @errp: pointer to an error > */ > static void zlib_send_cleanup(MultiFDSendParams *p, Error **errp) > { > @@ -94,6 +95,7 @@ static void zlib_send_cleanup(MultiFDSendParams *p, Error **errp) > * > * @p: Params for the channel that we are using > * @used: number of pages used > + * @errp: pointer to an error > */ > static int zlib_send_prepare(MultiFDSendParams *p, uint32_t used, Error **errp) > { > diff --git a/migration/multifd-zstd.c b/migration/multifd-zstd.c > index cc3b8869c0..09ae1cf91a 100644 > --- a/migration/multifd-zstd.c > +++ b/migration/multifd-zstd.c > @@ -84,6 +84,7 @@ static int zstd_send_setup(MultiFDSendParams *p, Error **errp) > * Close the channel and return memory. > * > * @p: Params for the channel that we are using > + * @errp: pointer to an error > */ > static void zstd_send_cleanup(MultiFDSendParams *p, Error **errp) > { > @@ -107,6 +108,7 @@ static void zstd_send_cleanup(MultiFDSendParams *p, Error **errp) > * > * @p: Params for the channel that we are using > * @used: number of pages used > + * @errp: pointer to an error > */ > static int zstd_send_prepare(MultiFDSendParams *p, uint32_t used, Error **errp) > { > diff --git a/migration/multifd.c b/migration/multifd.c > index 8ea86d81dc..cdeffdc4c5 100644 > --- a/migration/multifd.c > +++ b/migration/multifd.c > @@ -66,6 +66,7 @@ static int nocomp_send_setup(MultiFDSendParams *p, Error **errp) > * For no compression this function does nothing. > * > * @p: Params for the channel that we are using > + * @errp: pointer to an error > */ > static void nocomp_send_cleanup(MultiFDSendParams *p, Error **errp) > { > -- > 2.33.1 >
"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote: > * Juan Quintela (quintela@redhat.com) wrote: >> Signed-off-by: Juan Quintela <quintela@redhat.com> > > Pretty obvious, but I guess to have the complete set of comments: Yeap. When I was removing the used parameter, I found that we have this function without the comment. If we have the comments, just make them right. > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Thanks, Juan.
diff --git a/migration/multifd-zlib.c b/migration/multifd-zlib.c index 3fc7813b44..d0437cce2a 100644 --- a/migration/multifd-zlib.c +++ b/migration/multifd-zlib.c @@ -72,6 +72,7 @@ static int zlib_send_setup(MultiFDSendParams *p, Error **errp) * Close the channel and return memory. * * @p: Params for the channel that we are using + * @errp: pointer to an error */ static void zlib_send_cleanup(MultiFDSendParams *p, Error **errp) { @@ -94,6 +95,7 @@ static void zlib_send_cleanup(MultiFDSendParams *p, Error **errp) * * @p: Params for the channel that we are using * @used: number of pages used + * @errp: pointer to an error */ static int zlib_send_prepare(MultiFDSendParams *p, uint32_t used, Error **errp) { diff --git a/migration/multifd-zstd.c b/migration/multifd-zstd.c index cc3b8869c0..09ae1cf91a 100644 --- a/migration/multifd-zstd.c +++ b/migration/multifd-zstd.c @@ -84,6 +84,7 @@ static int zstd_send_setup(MultiFDSendParams *p, Error **errp) * Close the channel and return memory. * * @p: Params for the channel that we are using + * @errp: pointer to an error */ static void zstd_send_cleanup(MultiFDSendParams *p, Error **errp) { @@ -107,6 +108,7 @@ static void zstd_send_cleanup(MultiFDSendParams *p, Error **errp) * * @p: Params for the channel that we are using * @used: number of pages used + * @errp: pointer to an error */ static int zstd_send_prepare(MultiFDSendParams *p, uint32_t used, Error **errp) { diff --git a/migration/multifd.c b/migration/multifd.c index 8ea86d81dc..cdeffdc4c5 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -66,6 +66,7 @@ static int nocomp_send_setup(MultiFDSendParams *p, Error **errp) * For no compression this function does nothing. * * @p: Params for the channel that we are using + * @errp: pointer to an error */ static void nocomp_send_cleanup(MultiFDSendParams *p, Error **errp) {
Signed-off-by: Juan Quintela <quintela@redhat.com> --- migration/multifd-zlib.c | 2 ++ migration/multifd-zstd.c | 2 ++ migration/multifd.c | 1 + 3 files changed, 5 insertions(+)