Message ID | 20211124100617.19786-1-quintela@redhat.com |
---|---|
Headers | show |
Series | Migration: Transmit and detect zero pages in the multifd threads | expand |
On Wed, Nov 24, 2021 at 11:05:54AM +0100, Juan Quintela wrote: > Hi > > Trying with a different server. > As it used to happen, when I sent everything only to me, everything worked. > > Sorry folks. > > [v2] > This is a rebase against last master. > > And the reason for resend is to configure properly git-publish and > hope this time that git-publish send all the patches. I do suffer from this too. I normally use git-publish parameters "-S" plus "-R" together when it happens, then in the interactive console selectively send leftover series to complete previous attempt. I think it's not a bug for git-publish, but git-send-email with fail with an SMTP error. I'm no expert of that, but iirc last time we discussed Paolo mentioned it could be a git-send-email bug. Copy Paolo for that in case there's any further clue out of it. > > Please, review. > > [v1] > Since Friday version: > - More cleanups on the code > - Remove repeated calls to qemu_target_page_size() > - Establish normal pages and zero pages > - detect zero pages on the multifd threads > - send zero pages through the multifd channels. > - reviews by Richard addressed. > > It pases migration-test, so it should be perfect O:+) OK I "agree". :-D Besides, shall we try measure some real workloads? E.g. total migration time of an idle guest doing 8 channels multifd migration with/without the patchset? I'd expect there's a huge speedup on that even with a low speed NIC, and it'll be great to verify it.