| Message ID | 20210926105003.2716-1-bmeng.cn@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] hw/char: ibex_uart: Register device in 'input' category | expand |
On 9/26/21 12:50, Bin Meng wrote: > The category of ibex_uart device is not set. Put it into the > 'input' category. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > --- > > hw/char/ibex_uart.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/char/ibex_uart.c b/hw/char/ibex_uart.c > index 9b0a817713..e58181fcf4 100644 > --- a/hw/char/ibex_uart.c > +++ b/hw/char/ibex_uart.c > @@ -550,6 +550,7 @@ static void ibex_uart_class_init(ObjectClass *klass, void *data) > dc->realize = ibex_uart_realize; > dc->vmsd = &vmstate_ibex_uart; > device_class_set_props(dc, ibex_uart_properties); > + set_bit(DEVICE_CATEGORY_INPUT, dc->categories); > } A bit orthogonal but I wonder if ADC (to the extent sensors) and touch devices should be categorized as "input" ones. Maybe we deserve a DEVICE_CATEGORY_SENSOR category? Back to this patch: Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> But it would be nice to have a generic way to avoid adding uncategorized user-creatable devices.
On Sun, Sep 26, 2021 at 8:51 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > The category of ibex_uart device is not set. Put it into the > 'input' category. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > > hw/char/ibex_uart.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/char/ibex_uart.c b/hw/char/ibex_uart.c > index 9b0a817713..e58181fcf4 100644 > --- a/hw/char/ibex_uart.c > +++ b/hw/char/ibex_uart.c > @@ -550,6 +550,7 @@ static void ibex_uart_class_init(ObjectClass *klass, void *data) > dc->realize = ibex_uart_realize; > dc->vmsd = &vmstate_ibex_uart; > device_class_set_props(dc, ibex_uart_properties); > + set_bit(DEVICE_CATEGORY_INPUT, dc->categories); > } > > static const TypeInfo ibex_uart_info = { > -- > 2.25.1 > >
diff --git a/hw/char/ibex_uart.c b/hw/char/ibex_uart.c index 9b0a817713..e58181fcf4 100644 --- a/hw/char/ibex_uart.c +++ b/hw/char/ibex_uart.c @@ -550,6 +550,7 @@ static void ibex_uart_class_init(ObjectClass *klass, void *data) dc->realize = ibex_uart_realize; dc->vmsd = &vmstate_ibex_uart; device_class_set_props(dc, ibex_uart_properties); + set_bit(DEVICE_CATEGORY_INPUT, dc->categories); } static const TypeInfo ibex_uart_info = {
The category of ibex_uart device is not set. Put it into the 'input' category. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- hw/char/ibex_uart.c | 1 + 1 file changed, 1 insertion(+)