| Message ID | 20201027165114.71508-1-richard.henderson@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Tue, 27 Oct 2020 at 16:51, Richard Henderson <richard.henderson@linaro.org> wrote: > > The following changes since commit 4a74626970ab4ea475263d155b10fb75c9af0b33: > > Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/tracing-pull-request' into staging (2020-10-27 11:28:46 +0000) > > are available in the Git repository at: > > https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20201027 > > for you to fetch changes up to 1d705e8a5bbfe36294081baa45ab68a9ad987f33: > > accel/tcg: Add CPU_LOG_EXEC tracing for cpu_io_recompile() (2020-10-27 09:48:07 -0700) > > ---------------------------------------------------------------- > Optimize across branches. > Add logging for cpu_io_recompile. > > ---------------------------------------------------------------- > Peter Maydell (1): > accel/tcg: Add CPU_LOG_EXEC tracing for cpu_io_recompile() > > Richard Henderson (2): > tcg: Do not kill globals at conditional branches > tcg/optimize: Flush data at labels not TCG_OPF_BB_END Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 for any user-visible changes. -- PMM
On Tue, 27 Oct 2020 at 16:51, Richard Henderson <richard.henderson@linaro.org> wrote: > ---------------------------------------------------------------- > Optimize across branches. > Add logging for cpu_io_recompile. Igor2 reported on IRC that this seems to cause a crash when using an hppa guest. This is apparently happening on a proprietary disk image, so no reproducible test case, but the logging of the tail end of -d in_asm,op is at: http://igor2.repo.hu/tmp/in_asm_op.log QEMU asserts with ../tcg/tcg.c:3346: tcg fatal error The TB in question involves several conditional branches; the generated TCG ops look OK to me, and reverting the two commits b4cb76e6208cf6b5b and cd0372c515c4732d8b fixes the crash. (We didn't test reverting only one of the two commits separately.) thanks -- PMM
On 11/2/20 5:57 AM, Peter Maydell wrote: > On Tue, 27 Oct 2020 at 16:51, Richard Henderson > <richard.henderson@linaro.org> wrote: >> ---------------------------------------------------------------- >> Optimize across branches. >> Add logging for cpu_io_recompile. > > Igor2 reported on IRC that this seems to cause a crash when > using an hppa guest. This is apparently happening on a proprietary > disk image, so no reproducible test case, but the logging of > the tail end of -d in_asm,op is at: > http://igor2.repo.hu/tmp/in_asm_op.log > > QEMU asserts with > ../tcg/tcg.c:3346: tcg fatal error > > The TB in question involves several conditional branches; the > generated TCG ops look OK to me, and reverting the two commits > b4cb76e6208cf6b5b and cd0372c515c4732d8b fixes the crash. > (We didn't test reverting only one of the two commits separately.) Ok, thanks, I'll look into it. r~
The following changes since commit 4a74626970ab4ea475263d155b10fb75c9af0b33: Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/tracing-pull-request' into staging (2020-10-27 11:28:46 +0000) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20201027 for you to fetch changes up to 1d705e8a5bbfe36294081baa45ab68a9ad987f33: accel/tcg: Add CPU_LOG_EXEC tracing for cpu_io_recompile() (2020-10-27 09:48:07 -0700) ---------------------------------------------------------------- Optimize across branches. Add logging for cpu_io_recompile. ---------------------------------------------------------------- Peter Maydell (1): accel/tcg: Add CPU_LOG_EXEC tracing for cpu_io_recompile() Richard Henderson (2): tcg: Do not kill globals at conditional branches tcg/optimize: Flush data at labels not TCG_OPF_BB_END include/tcg/tcg-opc.h | 7 +++--- include/tcg/tcg.h | 4 +++- accel/tcg/translate-all.c | 4 ++++ tcg/optimize.c | 35 +++++++++++++++--------------- tcg/tcg.c | 55 +++++++++++++++++++++++++++++++++++++++++++++-- 5 files changed, 82 insertions(+), 23 deletions(-)