| Message ID | 20201020155656.8045-1-peter.maydell@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 10/20/20 5:56 PM, Peter Maydell wrote: > The following changes since commit 4c41341af76cfc85b5a6c0f87de4838672ab9f89: > > Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20201020' into staging (2020-10-20 11:20:36 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20201020 > > for you to fetch changes up to 6358890cb939192f6169fdf7664d903bf9b1d338: > > tests/tcg/aarch64: Add bti smoke tests (2020-10-20 16:12:02 +0100) > > ---------------------------------------------------------------- > target-arm queue: > * Fix AArch32 SMLAD incorrect setting of Q bit > * AArch32 VCVT fixed-point to float is always round-to-nearest > * strongarm: Fix 'time to transmit a char' unit comment > * Restrict APEI tables generation to the 'virt' machine > * bcm2835: minor code cleanups Just to clarify, the main part there is a bugfix ;) Only the first IRQ from the SYS_timer was delivered to the ARM core. It passed my smoke test because when I wrote the model only u-boot was using this peripheral, then Linux started to use it. Fixes: 0e5bbd74064 ("hw/arm/bcm2835_peripherals: Use the SYS_timer") > * correctly flush TLBs when TBI is enabled > * tests/qtest: Add npcm7xx timer test > * loads-stores.rst: add footnote that clarifies GETPC usage > * Fix reported EL for mte_check_fail > * Ignore HCR_EL2.ATA when {E2H,TGE} != 11 > * microbit_i2c: Fix coredump when dump-vmstate > * nseries: Fix loading kernel image on n8x0 machines > * Implement v8.1M low-overhead-loops > * linux-user: Support AArch64 BTI > > ---------------------------------------------------------------- > Emanuele Giuseppe Esposito (1): > loads-stores.rst: add footnote that clarifies GETPC usage > > Havard Skinnemoen (1): > tests/qtest: Add npcm7xx timer test > > Peng Liang (1): > microbit_i2c: Fix coredump when dump-vmstate > > Peter Maydell (12): > target/arm: Fix SMLAD incorrect setting of Q bit > target/arm: AArch32 VCVT fixed-point to float is always round-to-nearest > decodetree: Fix codegen for non-overlapping group inside overlapping group > target/arm: Implement v8.1M NOCP handling > target/arm: Implement v8.1M conditional-select insns > target/arm: Make the t32 insn[25:23]=111 group non-overlapping > target/arm: Don't allow BLX imm for M-profile > target/arm: Implement v8.1M branch-future insns (as NOPs) > target/arm: Implement v8.1M low-overhead-loop instructions > target/arm: Fix has_vfp/has_neon ID reg squashing for M-profile > target/arm: Allow M-profile CPUs with FP16 to set FPSCR.FP16 > target/arm: Implement FPSCR.LTPSIZE for M-profile LOB extension > > Philippe Mathieu-Daudé (10): > hw/arm/strongarm: Fix 'time to transmit a char' unit comment > hw/arm: Restrict APEI tables generation to the 'virt' machine > hw/timer/bcm2835: Introduce BCM2835_SYSTIMER_COUNT definition > hw/timer/bcm2835: Rename variable holding CTRL_STATUS register > hw/timer/bcm2835: Support the timer COMPARE registers > hw/arm/bcm2835_peripherals: Correctly wire the SYS_timer IRQs > hw/intc/bcm2835_ic: Trace GPU/CPU IRQ handlers > hw/intc/bcm2836_control: Use IRQ definitions instead of magic numbers > hw/arm/nseries: Fix loading kernel image on n8x0 machines > linux-user/elfload: Avoid leaking interp_name using GLib memory API > > Richard Henderson (16): > accel/tcg: Add tlb_flush_page_bits_by_mmuidx* > target/arm: Use tlb_flush_page_bits_by_mmuidx* > target/arm: Remove redundant mmu_idx lookup > target/arm: Fix reported EL for mte_check_fail > target/arm: Ignore HCR_EL2.ATA when {E2H,TGE} != 11 > linux-user/aarch64: Reset btype for signals > linux-user: Set PAGE_TARGET_1 for TARGET_PROT_BTI > include/elf: Add defines related to GNU property notes for AArch64 > linux-user/elfload: Fix coding style in load_elf_image > linux-user/elfload: Adjust iteration over phdr > linux-user/elfload: Move PT_INTERP detection to first loop > linux-user/elfload: Use Error for load_elf_image > linux-user/elfload: Use Error for load_elf_interp > linux-user/elfload: Parse NT_GNU_PROPERTY_TYPE_0 notes > linux-user/elfload: Parse GNU_PROPERTY_AARCH64_FEATURE_1_AND > tests/tcg/aarch64: Add bti smoke tests > > docs/devel/loads-stores.rst | 8 +- > default-configs/devices/arm-softmmu.mak | 1 - > include/elf.h | 22 ++ > include/exec/cpu-all.h | 2 + > include/exec/exec-all.h | 36 ++ > include/hw/timer/bcm2835_systmr.h | 17 +- > linux-user/qemu.h | 4 + > linux-user/syscall_defs.h | 4 + > target/arm/cpu.h | 13 + > target/arm/helper.h | 13 + > target/arm/internals.h | 9 +- > target/arm/m-nocp.decode | 10 +- > target/arm/t32.decode | 50 ++- > accel/tcg/cputlb.c | 275 +++++++++++++++- > hw/arm/bcm2835_peripherals.c | 13 +- > hw/arm/nseries.c | 1 + > hw/arm/strongarm.c | 2 +- > hw/i2c/microbit_i2c.c | 1 + > hw/intc/bcm2835_ic.c | 4 +- > hw/intc/bcm2836_control.c | 8 +- > hw/timer/bcm2835_systmr.c | 57 ++-- > linux-user/aarch64/signal.c | 10 +- > linux-user/elfload.c | 326 ++++++++++++++---- > linux-user/mmap.c | 16 + > target/arm/cpu.c | 38 ++- > target/arm/helper.c | 55 +++- > target/arm/mte_helper.c | 13 +- > target/arm/translate-a64.c | 6 +- > target/arm/translate.c | 239 +++++++++++++- > target/arm/vfp_helper.c | 76 +++-- > tests/qtest/npcm7xx_timer-test.c | 562 ++++++++++++++++++++++++++++++++ > tests/tcg/aarch64/bti-1.c | 62 ++++ > tests/tcg/aarch64/bti-2.c | 108 ++++++ > tests/tcg/aarch64/bti-crt.inc.c | 51 +++ > hw/arm/Kconfig | 1 + > hw/intc/trace-events | 4 + > hw/timer/trace-events | 6 +- > scripts/decodetree.py | 2 +- > target/arm/translate-vfp.c.inc | 41 ++- > tests/qtest/meson.build | 1 + > tests/tcg/aarch64/Makefile.target | 10 + > tests/tcg/configure.sh | 4 + > 42 files changed, 1973 insertions(+), 208 deletions(-) > create mode 100644 tests/qtest/npcm7xx_timer-test.c > create mode 100644 tests/tcg/aarch64/bti-1.c > create mode 100644 tests/tcg/aarch64/bti-2.c > create mode 100644 tests/tcg/aarch64/bti-crt.inc.c >
Patchew URL: https://patchew.org/QEMU/20201020155656.8045-1-peter.maydell@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201020155656.8045-1-peter.maydell@linaro.org
Subject: [PULL 00/41] target-arm queue
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20201020155656.8045-1-peter.maydell@linaro.org -> patchew/20201020155656.8045-1-peter.maydell@linaro.org
Switched to a new branch 'test'
6abc744 tests/tcg/aarch64: Add bti smoke tests
7a68af2 linux-user/elfload: Parse GNU_PROPERTY_AARCH64_FEATURE_1_AND
01490e2 linux-user/elfload: Parse NT_GNU_PROPERTY_TYPE_0 notes
acf0bee linux-user/elfload: Use Error for load_elf_interp
91b7dd8 linux-user/elfload: Use Error for load_elf_image
7049151 linux-user/elfload: Move PT_INTERP detection to first loop
a0f6f8a linux-user/elfload: Adjust iteration over phdr
f72dee2 linux-user/elfload: Fix coding style in load_elf_image
7596df6 linux-user/elfload: Avoid leaking interp_name using GLib memory API
3fe25e0 include/elf: Add defines related to GNU property notes for AArch64
13164fa linux-user: Set PAGE_TARGET_1 for TARGET_PROT_BTI
c4b76c8 linux-user/aarch64: Reset btype for signals
dc528f1 target/arm: Implement FPSCR.LTPSIZE for M-profile LOB extension
de2ff37 target/arm: Allow M-profile CPUs with FP16 to set FPSCR.FP16
f2c3512 target/arm: Fix has_vfp/has_neon ID reg squashing for M-profile
e0a512a target/arm: Implement v8.1M low-overhead-loop instructions
06a929a target/arm: Implement v8.1M branch-future insns (as NOPs)
b4a7269 target/arm: Don't allow BLX imm for M-profile
8e904bc target/arm: Make the t32 insn[25:23]=111 group non-overlapping
e3fcb8a target/arm: Implement v8.1M conditional-select insns
d166303 target/arm: Implement v8.1M NOCP handling
2ceaf26 decodetree: Fix codegen for non-overlapping group inside overlapping group
8c0c38f hw/arm/nseries: Fix loading kernel image on n8x0 machines
99b88b1 microbit_i2c: Fix coredump when dump-vmstate
e435b66 target/arm: Ignore HCR_EL2.ATA when {E2H,TGE} != 11
c55690c target/arm: Fix reported EL for mte_check_fail
b7d98d6 target/arm: Remove redundant mmu_idx lookup
81baae0 hw/intc/bcm2836_control: Use IRQ definitions instead of magic numbers
5860faf hw/intc/bcm2835_ic: Trace GPU/CPU IRQ handlers
76359b5 loads-stores.rst: add footnote that clarifies GETPC usage
b503f8f tests/qtest: Add npcm7xx timer test
37f9306 target/arm: Use tlb_flush_page_bits_by_mmuidx*
e4d595c accel/tcg: Add tlb_flush_page_bits_by_mmuidx*
323e682 hw/arm/bcm2835_peripherals: Correctly wire the SYS_timer IRQs
e10bde5 hw/timer/bcm2835: Support the timer COMPARE registers
86d375e hw/timer/bcm2835: Rename variable holding CTRL_STATUS register
5ffed07 hw/timer/bcm2835: Introduce BCM2835_SYSTIMER_COUNT definition
2540e23 hw/arm: Restrict APEI tables generation to the 'virt' machine
2bafeaf hw/arm/strongarm: Fix 'time to transmit a char' unit comment
8f189cc target/arm: AArch32 VCVT fixed-point to float is always round-to-nearest
a647677 target/arm: Fix SMLAD incorrect setting of Q bit
=== OUTPUT BEGIN ===
1/41 Checking commit a6476779ea51 (target/arm: Fix SMLAD incorrect setting of Q bit)
2/41 Checking commit 8f189ccc02db (target/arm: AArch32 VCVT fixed-point to float is always round-to-nearest)
3/41 Checking commit 2bafeaf8bf3f (hw/arm/strongarm: Fix 'time to transmit a char' unit comment)
4/41 Checking commit 2540e23a83dd (hw/arm: Restrict APEI tables generation to the 'virt' machine)
5/41 Checking commit 5ffed07b26c0 (hw/timer/bcm2835: Introduce BCM2835_SYSTIMER_COUNT definition)
6/41 Checking commit 86d375e278b1 (hw/timer/bcm2835: Rename variable holding CTRL_STATUS register)
7/41 Checking commit e10bde59e2a4 (hw/timer/bcm2835: Support the timer COMPARE registers)
8/41 Checking commit 323e6827dbbc (hw/arm/bcm2835_peripherals: Correctly wire the SYS_timer IRQs)
9/41 Checking commit e4d595cfa99f (accel/tcg: Add tlb_flush_page_bits_by_mmuidx*)
10/41 Checking commit 37f9306c03c9 (target/arm: Use tlb_flush_page_bits_by_mmuidx*)
11/41 Checking commit b503f8fa751d (tests/qtest: Add npcm7xx timer test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37:
new file mode 100644
total: 0 errors, 1 warnings, 569 lines checked
Patch 11/41 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/41 Checking commit 76359b58d121 (loads-stores.rst: add footnote that clarifies GETPC usage)
13/41 Checking commit 5860faf69fb1 (hw/intc/bcm2835_ic: Trace GPU/CPU IRQ handlers)
14/41 Checking commit 81baae0ed94e (hw/intc/bcm2836_control: Use IRQ definitions instead of magic numbers)
15/41 Checking commit b7d98d67ee25 (target/arm: Remove redundant mmu_idx lookup)
16/41 Checking commit c55690c5edb3 (target/arm: Fix reported EL for mte_check_fail)
17/41 Checking commit e435b66cfd75 (target/arm: Ignore HCR_EL2.ATA when {E2H,TGE} != 11)
18/41 Checking commit 99b88b1e120a (microbit_i2c: Fix coredump when dump-vmstate)
19/41 Checking commit 8c0c38fd2031 (hw/arm/nseries: Fix loading kernel image on n8x0 machines)
20/41 Checking commit 2ceaf26e4ebc (decodetree: Fix codegen for non-overlapping group inside overlapping group)
21/41 Checking commit d166303278b8 (target/arm: Implement v8.1M NOCP handling)
22/41 Checking commit e3fcb8a10bd0 (target/arm: Implement v8.1M conditional-select insns)
23/41 Checking commit 8e904bc6d157 (target/arm: Make the t32 insn[25:23]=111 group non-overlapping)
24/41 Checking commit b4a7269fe480 (target/arm: Don't allow BLX imm for M-profile)
25/41 Checking commit 06a929a984b3 (target/arm: Implement v8.1M branch-future insns (as NOPs))
26/41 Checking commit e0a512af2aea (target/arm: Implement v8.1M low-overhead-loop instructions)
27/41 Checking commit f2c351298873 (target/arm: Fix has_vfp/has_neon ID reg squashing for M-profile)
28/41 Checking commit de2ff3705cdc (target/arm: Allow M-profile CPUs with FP16 to set FPSCR.FP16)
29/41 Checking commit dc528f1d2564 (target/arm: Implement FPSCR.LTPSIZE for M-profile LOB extension)
30/41 Checking commit c4b76c81695c (linux-user/aarch64: Reset btype for signals)
31/41 Checking commit 13164fa337d7 (linux-user: Set PAGE_TARGET_1 for TARGET_PROT_BTI)
32/41 Checking commit 3fe25e0a9b47 (include/elf: Add defines related to GNU property notes for AArch64)
33/41 Checking commit 7596df60e0a7 (linux-user/elfload: Avoid leaking interp_name using GLib memory API)
34/41 Checking commit f72dee236706 (linux-user/elfload: Fix coding style in load_elf_image)
35/41 Checking commit a0f6f8a06f8b (linux-user/elfload: Adjust iteration over phdr)
36/41 Checking commit 7049151b6492 (linux-user/elfload: Move PT_INTERP detection to first loop)
37/41 Checking commit 91b7dd86b6f2 (linux-user/elfload: Use Error for load_elf_image)
38/41 Checking commit acf0beedd932 (linux-user/elfload: Use Error for load_elf_interp)
39/41 Checking commit 01490e235e98 (linux-user/elfload: Parse NT_GNU_PROPERTY_TYPE_0 notes)
40/41 Checking commit 7a68af21bbdd (linux-user/elfload: Parse GNU_PROPERTY_AARCH64_FEATURE_1_AND)
41/41 Checking commit 6abc744a59cb (tests/tcg/aarch64: Add bti smoke tests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39:
new file mode 100644
ERROR: externs should be avoided in .c files
#167: FILE: tests/tcg/aarch64/bti-2.c:56:
+extern char test_begin[], test_end[];
ERROR: use qemu_real_host_page_size instead of getpagesize()
#201: FILE: tests/tcg/aarch64/bti-2.c:90:
+ void *p = mmap(0, getpagesize(),
ERROR: externs should be avoided in .c files
#238: FILE: tests/tcg/aarch64/bti-crt.inc.c:13:
+int main(void);
total: 3 errors, 1 warnings, 247 lines checked
Patch 41/41 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20201020155656.8045-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
The following changes since commit 4c41341af76cfc85b5a6c0f87de4838672ab9f89: Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20201020' into staging (2020-10-20 11:20:36 +0100) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20201020 for you to fetch changes up to 6358890cb939192f6169fdf7664d903bf9b1d338: tests/tcg/aarch64: Add bti smoke tests (2020-10-20 16:12:02 +0100) ---------------------------------------------------------------- target-arm queue: * Fix AArch32 SMLAD incorrect setting of Q bit * AArch32 VCVT fixed-point to float is always round-to-nearest * strongarm: Fix 'time to transmit a char' unit comment * Restrict APEI tables generation to the 'virt' machine * bcm2835: minor code cleanups * correctly flush TLBs when TBI is enabled * tests/qtest: Add npcm7xx timer test * loads-stores.rst: add footnote that clarifies GETPC usage * Fix reported EL for mte_check_fail * Ignore HCR_EL2.ATA when {E2H,TGE} != 11 * microbit_i2c: Fix coredump when dump-vmstate * nseries: Fix loading kernel image on n8x0 machines * Implement v8.1M low-overhead-loops * linux-user: Support AArch64 BTI ---------------------------------------------------------------- Emanuele Giuseppe Esposito (1): loads-stores.rst: add footnote that clarifies GETPC usage Havard Skinnemoen (1): tests/qtest: Add npcm7xx timer test Peng Liang (1): microbit_i2c: Fix coredump when dump-vmstate Peter Maydell (12): target/arm: Fix SMLAD incorrect setting of Q bit target/arm: AArch32 VCVT fixed-point to float is always round-to-nearest decodetree: Fix codegen for non-overlapping group inside overlapping group target/arm: Implement v8.1M NOCP handling target/arm: Implement v8.1M conditional-select insns target/arm: Make the t32 insn[25:23]=111 group non-overlapping target/arm: Don't allow BLX imm for M-profile target/arm: Implement v8.1M branch-future insns (as NOPs) target/arm: Implement v8.1M low-overhead-loop instructions target/arm: Fix has_vfp/has_neon ID reg squashing for M-profile target/arm: Allow M-profile CPUs with FP16 to set FPSCR.FP16 target/arm: Implement FPSCR.LTPSIZE for M-profile LOB extension Philippe Mathieu-Daudé (10): hw/arm/strongarm: Fix 'time to transmit a char' unit comment hw/arm: Restrict APEI tables generation to the 'virt' machine hw/timer/bcm2835: Introduce BCM2835_SYSTIMER_COUNT definition hw/timer/bcm2835: Rename variable holding CTRL_STATUS register hw/timer/bcm2835: Support the timer COMPARE registers hw/arm/bcm2835_peripherals: Correctly wire the SYS_timer IRQs hw/intc/bcm2835_ic: Trace GPU/CPU IRQ handlers hw/intc/bcm2836_control: Use IRQ definitions instead of magic numbers hw/arm/nseries: Fix loading kernel image on n8x0 machines linux-user/elfload: Avoid leaking interp_name using GLib memory API Richard Henderson (16): accel/tcg: Add tlb_flush_page_bits_by_mmuidx* target/arm: Use tlb_flush_page_bits_by_mmuidx* target/arm: Remove redundant mmu_idx lookup target/arm: Fix reported EL for mte_check_fail target/arm: Ignore HCR_EL2.ATA when {E2H,TGE} != 11 linux-user/aarch64: Reset btype for signals linux-user: Set PAGE_TARGET_1 for TARGET_PROT_BTI include/elf: Add defines related to GNU property notes for AArch64 linux-user/elfload: Fix coding style in load_elf_image linux-user/elfload: Adjust iteration over phdr linux-user/elfload: Move PT_INTERP detection to first loop linux-user/elfload: Use Error for load_elf_image linux-user/elfload: Use Error for load_elf_interp linux-user/elfload: Parse NT_GNU_PROPERTY_TYPE_0 notes linux-user/elfload: Parse GNU_PROPERTY_AARCH64_FEATURE_1_AND tests/tcg/aarch64: Add bti smoke tests docs/devel/loads-stores.rst | 8 +- default-configs/devices/arm-softmmu.mak | 1 - include/elf.h | 22 ++ include/exec/cpu-all.h | 2 + include/exec/exec-all.h | 36 ++ include/hw/timer/bcm2835_systmr.h | 17 +- linux-user/qemu.h | 4 + linux-user/syscall_defs.h | 4 + target/arm/cpu.h | 13 + target/arm/helper.h | 13 + target/arm/internals.h | 9 +- target/arm/m-nocp.decode | 10 +- target/arm/t32.decode | 50 ++- accel/tcg/cputlb.c | 275 +++++++++++++++- hw/arm/bcm2835_peripherals.c | 13 +- hw/arm/nseries.c | 1 + hw/arm/strongarm.c | 2 +- hw/i2c/microbit_i2c.c | 1 + hw/intc/bcm2835_ic.c | 4 +- hw/intc/bcm2836_control.c | 8 +- hw/timer/bcm2835_systmr.c | 57 ++-- linux-user/aarch64/signal.c | 10 +- linux-user/elfload.c | 326 ++++++++++++++---- linux-user/mmap.c | 16 + target/arm/cpu.c | 38 ++- target/arm/helper.c | 55 +++- target/arm/mte_helper.c | 13 +- target/arm/translate-a64.c | 6 +- target/arm/translate.c | 239 +++++++++++++- target/arm/vfp_helper.c | 76 +++-- tests/qtest/npcm7xx_timer-test.c | 562 ++++++++++++++++++++++++++++++++ tests/tcg/aarch64/bti-1.c | 62 ++++ tests/tcg/aarch64/bti-2.c | 108 ++++++ tests/tcg/aarch64/bti-crt.inc.c | 51 +++ hw/arm/Kconfig | 1 + hw/intc/trace-events | 4 + hw/timer/trace-events | 6 +- scripts/decodetree.py | 2 +- target/arm/translate-vfp.c.inc | 41 ++- tests/qtest/meson.build | 1 + tests/tcg/aarch64/Makefile.target | 10 + tests/tcg/configure.sh | 4 + 42 files changed, 1973 insertions(+), 208 deletions(-) create mode 100644 tests/qtest/npcm7xx_timer-test.c create mode 100644 tests/tcg/aarch64/bti-1.c create mode 100644 tests/tcg/aarch64/bti-2.c create mode 100644 tests/tcg/aarch64/bti-crt.inc.c