Message ID | 20200703201911.26573-5-f4bug@amsat.org |
---|---|
State | New |
Headers | show |
Series | hw: Mark the device with no migratable fields | expand |
On Fri, 3 Jul 2020 at 21:19, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > This device doesn't have fields to migrate. Be explicit > by using vmstate_qdev_no_state_to_migrate. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/arm/armv7m.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c > index 3308211e9c..3f78fccc12 100644 > --- a/hw/arm/armv7m.c > +++ b/hw/arm/armv7m.c > @@ -366,6 +366,7 @@ static void bitband_class_init(ObjectClass *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > > dc->realize = bitband_realize; > + dc->vmsd = vmstate_qdev_no_state_to_migrate; > device_class_set_props(dc, bitband_properties); > } The commit message implies that this is changing the TYPE_ARMV7M device, but it's actually affecting TYPE_BITBAND. Code change looks good. Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index 3308211e9c..3f78fccc12 100644 --- a/hw/arm/armv7m.c +++ b/hw/arm/armv7m.c @@ -366,6 +366,7 @@ static void bitband_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); dc->realize = bitband_realize; + dc->vmsd = vmstate_qdev_no_state_to_migrate; device_class_set_props(dc, bitband_properties); }
This device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/arm/armv7m.c | 1 + 1 file changed, 1 insertion(+)